Description of problem: bash-4.1# oo-admin-ctl-district -c add-node -n dist1 -i non-exist /usr/sbin/oo-admin-ctl-district:215:in `block in <main>': undefined method `casecmp' for nil:NilClass (NoMethodError) from /usr/sbin/oo-admin-ctl-district:178:in `block in collate_errors' from /usr/sbin/oo-admin-ctl-district:176:in `each' from /usr/sbin/oo-admin-ctl-district:176:in `collate_errors' from /usr/sbin/oo-admin-ctl-district:213:in `<main>' Version-Release number of selected component (if applicable): devenv_4824 How reproducible: always Steps to Reproduce: 1. Create district on broker 2. Try to add non-existing node to the district 3. Actual results: bash-4.1# oo-admin-ctl-district -c add-node -n dist1 -i non-exist /usr/sbin/oo-admin-ctl-district:215:in `block in <main>': undefined method `casecmp' for nil:NilClass (NoMethodError) Expected results: Should return meaningful error message Additional info:
I think this is the same with bug 1122339. https://bugzilla.redhat.com/show_bug.cgi?id=1122339 I've submitted a pull request there. https://github.com/openshift/origin-server/pull/5663
Tested on devenv_5167, the bug has been fixed, thanks. Add a non-exist node to the district: [root@ip-10-81-186-51 ~]# oo-broker oo-admin-ctl-district -c add-node -n dist_1 -i node {"_id"=>"5417e19fe22aa22272000001", "uuid"=>"1499132e3d7011e48e60da48c8899057", "available_uids"=>"<6000 uids hidden>", "name"=>"dist_1", "platform"=>"linux", "gear_size"=>"small", "available_capacity"=>6000, "max_uid"=>6999, "max_capacity"=>6000, "active_servers_size"=>0, "updated_at"=>2014-09-16 07:07:11 UTC, "created_at"=>2014-09-16 07:07:11 UTC} ERROR OUTPUT: Cannot connect to node.