Spec URL: http://jjames.fedorapeople.org/python-repoze-sphinx-autointerface/python-repoze-sphinx-autointerface.spec SRPM URL: http://jjames.fedorapeople.org/python-repoze-sphinx-autointerface/python-repoze-sphinx-autointerface-0.7.1-1.fc21.src.rpm Fedora Account System Username: jjames Description: This package defines an extension for the Sphinx documentation system. The extension allows generation of API documentation by introspection of zope.interface instances in code.
Created attachment 900707 [details] fix and improve spec-file Package Review ============== Legend: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 7 files have unknown license. Detailed output of licensecheck in /home/besser82/shared/fedora/review/1102858-python- repoze-sphinx-autointerface/licensecheck.txt ---> It might be nice to ask upstream for adding copyright / license headers atop the source-files [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python3.4/site-packages, /usr/lib/python3.4 ---> owned by python3 on rawhide [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.4/site-packages, /usr/lib/python3.4 ---> owned by python3 on rawhide [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/python2.7/site- packages/repoze(python-repoze-what-plugins-sql, python-repoze-what, python-repoze-who-friendlyform, python-repoze-who-plugins-sa, python- repoze-who-testutil, python-repoze-what-pylons, python-repoze-tm2) ---> multiple ownership seems legit here [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. ---> package is noarch [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 8 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [!]: Package meets the Packaging Guidelines::Python ---> see additional information [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3 -repoze-sphinx-autointerface ---> python3-subpkg is a seperated build for use with python3. false positive. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. ---> package is noarch [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-repoze-sphinx-autointerface-0.7.1-1.fc21.noarch.rpm python3-repoze-sphinx-autointerface-0.7.1-1.fc21.noarch.rpm python-repoze-sphinx-autointerface-0.7.1-1.fc21.src.rpm python-repoze-sphinx-autointerface.noarch: W: spelling-error %description -l en_US zope -> ope, zone, nope python3-repoze-sphinx-autointerface.noarch: W: spelling-error %description -l en_US zope -> ope, zone, nope python3-repoze-sphinx-autointerface.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/repoze/sphinx/__pycache__/autointerface.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python3-repoze-sphinx-autointerface.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/repoze/sphinx/__pycache__/autointerface.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python-repoze-sphinx-autointerface.src: W: spelling-error %description -l en_US zope -> ope, zone, nope 3 packages and 0 specfiles checked; 2 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint python-repoze-sphinx-autointerface python3-repoze-sphinx-autointerface python-repoze-sphinx-autointerface.noarch: W: spelling-error %description -l en_US zope -> ope, zone, nope python3-repoze-sphinx-autointerface.noarch: W: spelling-error %description -l en_US zope -> ope, zone, nope python3-repoze-sphinx-autointerface.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/repoze/sphinx/__pycache__/autointerface.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python3-repoze-sphinx-autointerface.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/repoze/sphinx/__pycache__/autointerface.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) 2 packages and 0 specfiles checked; 2 errors, 2 warnings. # echo 'rpmlint-done:' Requires -------- python-repoze-sphinx-autointerface (rpmlib, GLIBC filtered): python(abi) python-sphinx python-zope-interface python3-repoze-sphinx-autointerface (rpmlib, GLIBC filtered): python(abi) python3-sphinx python3-zope-interface Provides -------- python-repoze-sphinx-autointerface: python-repoze-sphinx-autointerface python3-repoze-sphinx-autointerface: python3-repoze-sphinx-autointerface Source checksums ---------------- https://github.com/repoze/repoze.sphinx.autointerface/archive/0.7.1/python-repoze-sphinx-autointerface-0.7.1.tar.gz : CHECKSUM(SHA256) this package : 5e0e769a6d27c09a6a2827549c859ba48cc3609f4f9506600230f305b25c1087 CHECKSUM(SHA256) upstream package : 5e0e769a6d27c09a6a2827549c859ba48cc3609f4f9506600230f305b25c1087 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1102858 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG ===== Additional Information ===== * Please conditionalize the build of the py3-pkg, so this can be easily ported to other releases (EPEL7), which don't offer support for py3, yet. * The %%clean-section is unneccessary and will override the default %%clean in rpm-macros. Please drop it. * For a quick fix-up, I attached you a patch. ===== Solution ===== NOT approved. Please fix those issues and I'll take another review.
Thank you very much for the review, Björn. (In reply to Björn "besser82" Esser from comment #1) > ---> It might be nice to ask upstream for adding copyright / license > headers atop the source-files I will make the attempt. > ===== Additional Information ===== > > * Please conditionalize the build of the py3-pkg, so this can be easily > ported to other releases (EPEL7), which don't offer support for py3, yet. Done. > * The %%clean-section is unneccessary and will override the default %%clean > in rpm-macros. Please drop it. This is not true. With the %clean section as is, rpmbuild --clean removes both repoze.sphinx.autointerface-0.7.1 and python3-python-repoze-sphinx-autointerface-0.7.1-1.fc21 from BUILD. If I remove the %clean section, then rpmbuild --clean removes the former but leaves the latter behind. > * For a quick fix-up, I attached you a patch. Thank you, I appreciate the patch. I have modified your suggested patch a little due to differences in taste. New URLs: Spec URL: http://jjames.fedorapeople.org/python-repoze-sphinx-autointerface/python-repoze-sphinx-autointerface.spec SRPM URL: http://jjames.fedorapeople.org/python-repoze-sphinx-autointerface/python-repoze-sphinx-autointerface-0.7.1-2.fc21.src.rpm
> the %clean section Not the full story. The default %clean section removes the BUILDROOT. It doesn't remove the BUILD directory. rpmbuild --clean removes the BUILD dir in addition to %clean. If you override %clean the way you do so far, you don't remove the %buildroot. But if you added "rm -rf %buildroot", that would result in different behaviour compared with what %clean does by default. I've filed https://fedorahosted.org/fpc/ticket/435 about this.
Ah, thanks for the explanation Michael. I think I will avoid using %{py3dir} until this issue is addressed, then. Here is a new version that does not have a %clean script: Spec URL: http://jjames.fedorapeople.org/python-repoze-sphinx-autointerface/python-repoze-sphinx-autointerface.spec SRPM URL: http://jjames.fedorapeople.org/python-repoze-sphinx-autointerface/python-repoze-sphinx-autointerface-0.7.1-3.fc21.src.rpm
Björn: ping.
In accordance with the policy for stalled package reviews (https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews), I note that Björn has not commented on this bug in over 1 month. Björn, please respond within the next 1 week.
Per the stalled package review policy, I am resetting this bug back to the available state.
- This package seems licensed with a BSD (modification variant https://fedoraproject.org/wiki/Licensing:BSD?rd=Licensing/BSD#Modification_Variant) Can you confirm ? - Your package owns /usr/lib/python2.7/site-packages/repoze and /usr/lib/python3.3/site-packages/repoze directories; they are co-owned by other packages not required. Your package does not own directories created /usr/lib/python2.7/site-packages/repoze/sphinx /usr/lib/python3.3/site-packages/repoze/sphinx Please, explicit files/directories lists in '%files'. - %if 0%{?fedora} >= 12 || 0%{?rhel} >= 8 RHEL 8 ? Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [?]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [?]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 8 files have unknown license. Detailed output of licensecheck in /home/sagitter/1102858-python-repoze-sphinx- autointerface/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/python2.7/site- packages/repoze(python-repoze-what-plugins-sql, python-repoze-what, python-repoze-who-friendlyform, python-repoze-who-plugins-sa, python- repoze-who-testutil, python-repoze-what-pylons, python-repoze-tm2) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 8 files. [x]: Package complies to the Packaging Guidelines [-]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-repoze-sphinx-autointerface-0.7.1-3.fc20.noarch.rpm python3-repoze-sphinx-autointerface-0.7.1-3.fc20.noarch.rpm python-repoze-sphinx-autointerface-0.7.1-3.fc20.src.rpm python-repoze-sphinx-autointerface.noarch: W: spelling-error %description -l en_US zope -> ope, zone, nope python3-repoze-sphinx-autointerface.noarch: W: spelling-error %description -l en_US zope -> ope, zone, nope python-repoze-sphinx-autointerface.src: W: spelling-error %description -l en_US zope -> ope, zone, nope 3 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint python-repoze-sphinx-autointerface python3-repoze-sphinx-autointerface python-repoze-sphinx-autointerface.noarch: W: spelling-error %description -l en_US zope -> ope, zone, nope python3-repoze-sphinx-autointerface.noarch: W: spelling-error %description -l en_US zope -> ope, zone, nope 2 packages and 0 specfiles checked; 0 errors, 2 warnings. # echo 'rpmlint-done:' Requires -------- python-repoze-sphinx-autointerface (rpmlib, GLIBC filtered): python(abi) python-sphinx python-zope-interface python3-repoze-sphinx-autointerface (rpmlib, GLIBC filtered): python(abi) python3-sphinx python3-zope-interface Provides -------- python-repoze-sphinx-autointerface: python-repoze-sphinx-autointerface python3-repoze-sphinx-autointerface: python3-repoze-sphinx-autointerface Source checksums ---------------- https://github.com/repoze/repoze.sphinx.autointerface/archive/0.7.1/python-repoze-sphinx-autointerface-0.7.1.tar.gz : CHECKSUM(SHA256) this package : 5e0e769a6d27c09a6a2827549c859ba48cc3609f4f9506600230f305b25c1087 CHECKSUM(SHA256) upstream package : 5e0e769a6d27c09a6a2827549c859ba48cc3609f4f9506600230f305b25c1087 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b fedora-rawhide-i386 -b 1102858 Buildroot used: fedora-20-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
(In reply to Antonio Trande from comment #8) > - This package seems licensed with a BSD (modification variant > https://fedoraproject.org/wiki/Licensing:BSD?rd=Licensing/ > BSD#Modification_Variant) > Can you confirm ? Yes, that is correct. Since this is not one of the BSD variants that requires a distinct License tag (such as "BSD with advertising"), the license tag is just "BSD" anyway. > - Your package owns /usr/lib/python2.7/site-packages/repoze > and /usr/lib/python3.3/site-packages/repoze directories; they are co-owned > by other packages not required. It is true that other packages own those directories, too, but this package can be installed without any of those other packages. Therefore, this package must also own those directories. > Your package does not own directories created > /usr/lib/python2.7/site-packages/repoze/sphinx > /usr/lib/python3.3/site-packages/repoze/sphinx > > Please, explicit files/directories lists in '%files'. Not needed, since the parent directories, and everything they contain, are already owned. > - %if 0%{?fedora} >= 12 || 0%{?rhel} >= 8 > > RHEL 8 ? This was requested by the original reviewer. See the attachment in comment 1. It doesn't matter much to me, frankly, but this does offer a bit of future-proofing, since python3 support is likely to appear in RHEL 8.
(In reply to Jerry James from comment #9) > (In reply to Antonio Trande from comment #8) > > > Your package does not own directories created > > /usr/lib/python2.7/site-packages/repoze/sphinx > > /usr/lib/python3.3/site-packages/repoze/sphinx > > > > Please, explicit files/directories lists in '%files'. > > Not needed, since the parent directories, and everything they contain, are > already owned. > As you wish. Package approved.
Thank you very much for the review, Antonio!
New Package SCM Request ======================= Package Name: python-repoze-sphinx-autointerface Short Description: Auto-generate Sphinx API docs from Zope interfaces Upstream URL: https://github.com/repoze/repoze.sphinx.autointerface Owners: jjames Branches: f21 InitialCC:
Git done (by process-git-requests).
This has been built for Rawhide and F21.