Bug 1103050
| Summary: | nfs: reset command does not alter the result for nfs options earlier set | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | santosh pradhan <spradhan> |
| Component: | rpc | Assignee: | santosh pradhan <spradhan> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | mainline | CC: | gluster-bugs, saujain, vagarwal |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | glusterfs-3.5.2beta1 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1102647 | Environment: | |
| Last Closed: | 2014-07-31 11:43:04 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1102647 | ||
| Bug Blocks: | |||
|
Description
santosh pradhan
2014-05-30 07:06:43 UTC
REVIEW: http://review.gluster.org/7931 (rpc: Reconfigure() does not work for auth-reject) posted (#1) for review on master by Santosh Pradhan (spradhan) COMMIT: http://review.gluster.org/7931 committed in master by Anand Avati (avati) ------ commit 211785f29904995324bfd3c7fa4b35a498bf632a Author: Santosh Kumar Pradhan <spradhan> Date: Fri May 30 12:37:23 2014 +0530 rpc: Reconfigure() does not work for auth-reject Problem: If volume is set for rpc-auth.addr.<volname>.reject with value as "host1", ideally the NFS mount from "host1" should FAIL. It works as expected. But when the volume is RESET, then previous value set for auth-reject should go off, and further NFS mount from "host1" should PASS. But it FAILs because of stale value in dict for key "rpc-auth.addr.<volname>.reject". It does not impact rpc-auth.addr.<volname>.allow key because, each time NFS volfile gets generated, allow key ll have "*" as default value. But reject key does not have default value. FIX: Delete the OLD value for key irrespective of anything. Add NEW value for the key, if and only if that is SET in the reconfigured new volfile. Signed-off-by: Santosh Kumar Pradhan <spradhan> Change-Id: Ie80bd16cd1f9e32c51f324f2236122f6d118d860 BUG: 1103050 Reviewed-on: http://review.gluster.org/7931 Reviewed-by: Niels de Vos <ndevos> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Rajesh Joseph <rjoseph> Reviewed-by: Anand Avati <avati> REVIEW: http://review.gluster.org/8022 (rpc: Reconfigure() does not work for auth-reject) posted (#1) for review on release-3.5 by Santosh Pradhan (spradhan) COMMIT: http://review.gluster.org/8022 committed in release-3.5 by Niels de Vos (ndevos) ------ commit 55880a7168d5b7ef85f6de3b1870634156e6ddfa Author: Santosh Kumar Pradhan <spradhan> Date: Tue Jun 10 10:43:28 2014 +0530 rpc: Reconfigure() does not work for auth-reject Problem: If volume is set for rpc-auth.addr.<volname>.reject with value as "host1", ideally the NFS mount from "host1" should FAIL. It works as expected. But when the volume is RESET, then previous value set for auth-reject should go off, and further NFS mount from "host1" should PASS. But it FAILs because of stale value in dict for key "rpc-auth.addr.<volname>.reject". It does not impact rpc-auth.addr.<volname>.allow key because, each time NFS volfile gets generated, allow key ll have "*" as default value. But reject key does not have default value. FIX: Delete the OLD value for key irrespective of anything. Add NEW value for the key, if and only if that is SET in the reconfigured new volfile. Upstream review: http://review.gluster.org/7931 Change-Id: I9d1cb37002aad978a3a59e4b45b42d881d0d20e3 BUG: 1103050 Signed-off-by: Santosh Kumar Pradhan <spradhan> Reviewed-on: http://review.gluster.org/8022 Reviewed-by: Raghavendra G <rgowdapp> Reviewed-by: Niels de Vos <ndevos> Tested-by: Gluster Build System <jenkins.com> The first (and last?) Beta for GlusterFS 3.5.2 has been released [1]. Please verify if the release solves this bug report for you. In case the glusterfs-3.5.2beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED. Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution. [1] http://supercolony.gluster.org/pipermail/gluster-devel/2014-July/041636.html [2] http://supercolony.gluster.org/pipermail/gluster-users/ This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.2, please reopen this bug report. glusterfs-3.5.2 has been announced on the Gluster Users mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://supercolony.gluster.org/pipermail/gluster-users/2014-July/041217.html [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user |