Spec URL: http://bochecha.fedorapeople.org/packages/python-pyramid-chameleon.spec SRPM URL: http://bochecha.fedorapeople.org/packages/python-pyramid-chameleon-0.1-1.fc20.src.rpm Description: Bindings for the Chameleon templating system in the Pyramid web framework. Fedora Account System Username: bochecha
Look for a full review in a few...
Issues: 1. There's a bytecompile issue, it looks like it's using python2 to bytecompile the python3 .py's. See: https://fedoraproject.org/wiki/Packaging:Python#Bytecompiling_with_the_correct_python_version 2. Might ask upstream to include a copy of the license. (non blocker) Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 14 files have unknown license. Detailed output of licensecheck in /home/fedora/kevin/1103543-python-pyramid- chameleon/licensecheck.txt [-]: License file installed when any subpackage combination is installed. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [-]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 6 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [?]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3 -pyramid-chameleon [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-pyramid-chameleon-0.1-1.fc21.noarch.rpm python3-pyramid-chameleon-0.1-1.fc21.noarch.rpm python-pyramid-chameleon-0.1-1.fc21.src.rpm python-pyramid-chameleon.noarch: W: spelling-error Summary(en_US) templating -> contemplating, template, tempting python-pyramid-chameleon.noarch: W: spelling-error %description -l en_US templating -> contemplating, template, tempting python3-pyramid-chameleon.noarch: W: spelling-error Summary(en_US) templating -> contemplating, template, tempting python3-pyramid-chameleon.noarch: W: spelling-error %description -l en_US templating -> contemplating, template, tempting python3-pyramid-chameleon.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/pyramid_chameleon/tests/__pycache__/test_localization.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python3-pyramid-chameleon.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/pyramid_chameleon/tests/__pycache__/test_renderers.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python3-pyramid-chameleon.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/pyramid_chameleon/tests/__pycache__/test_text.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python3-pyramid-chameleon.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/pyramid_chameleon/tests/__pycache__/__init__.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python3-pyramid-chameleon.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/pyramid_chameleon/__pycache__/localization.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python3-pyramid-chameleon.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/pyramid_chameleon/tests/__pycache__/__init__.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python3-pyramid-chameleon.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/pyramid_chameleon/__pycache__/localization.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python3-pyramid-chameleon.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/pyramid_chameleon/__pycache__/__init__.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python3-pyramid-chameleon.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/pyramid_chameleon/__pycache__/__init__.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python3-pyramid-chameleon.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/pyramid_chameleon/tests/__pycache__/test_renderers.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python3-pyramid-chameleon.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/pyramid_chameleon/__pycache__/renderer.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python3-pyramid-chameleon.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/pyramid_chameleon/tests/__pycache__/test_localization.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python3-pyramid-chameleon.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/pyramid_chameleon/__pycache__/zpt.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python3-pyramid-chameleon.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/pyramid_chameleon/__pycache__/renderer.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python3-pyramid-chameleon.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/pyramid_chameleon/__pycache__/text.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python3-pyramid-chameleon.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/pyramid_chameleon/__pycache__/zpt.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python3-pyramid-chameleon.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/pyramid_chameleon/__pycache__/text.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python3-pyramid-chameleon.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/pyramid_chameleon/__pycache__/interfaces.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python3-pyramid-chameleon.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/pyramid_chameleon/tests/__pycache__/test_zpt.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python3-pyramid-chameleon.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/pyramid_chameleon/tests/__pycache__/test_text.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python3-pyramid-chameleon.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/pyramid_chameleon/tests/__pycache__/test_zpt.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python3-pyramid-chameleon.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/pyramid_chameleon/__pycache__/interfaces.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python-pyramid-chameleon.src: W: spelling-error Summary(en_US) templating -> contemplating, template, tempting python-pyramid-chameleon.src: W: spelling-error %description -l en_US templating -> contemplating, template, tempting 3 packages and 0 specfiles checked; 22 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint python-pyramid-chameleon python3-pyramid-chameleon python-pyramid-chameleon.noarch: W: spelling-error Summary(en_US) templating -> contemplating, template, tempting python-pyramid-chameleon.noarch: W: spelling-error %description -l en_US templating -> contemplating, template, tempting python3-pyramid-chameleon.noarch: W: spelling-error Summary(en_US) templating -> contemplating, template, tempting python3-pyramid-chameleon.noarch: W: spelling-error %description -l en_US templating -> contemplating, template, tempting 2 packages and 0 specfiles checked; 0 errors, 4 warnings. # echo 'rpmlint-done:' Requires -------- python-pyramid-chameleon (rpmlib, GLIBC filtered): python(abi) python-chameleon python-pyramid python-setuptools python-translationstring python-venusian python-zope-interface python3-pyramid-chameleon (rpmlib, GLIBC filtered): python(abi) python3-chameleon python3-pyramid python3-setuptools python3-translationstring python3-venusian python3-zope-interface Provides -------- python-pyramid-chameleon: python-pyramid-chameleon python3-pyramid-chameleon: python3-pyramid-chameleon Source checksums ---------------- https://pypi.python.org/packages/source/p/pyramid_chameleon/pyramid_chameleon-0.1.tar.gz : CHECKSUM(SHA256) this package : 1c7d2dffd7410e01476210d9212a7e42c234faf8c3fac95a81dc80641ba84deb CHECKSUM(SHA256) upstream package : 1c7d2dffd7410e01476210d9212a7e42c234faf8c3fac95a81dc80641ba84deb Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1103543 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
(In reply to Kevin Fenzi from comment #2) > Issues: > > 1. There's a bytecompile issue, it looks like it's using python2 to > bytecompile the python3 .py's. See: > https://fedoraproject.org/wiki/Packaging: > Python#Bytecompiling_with_the_correct_python_version Fixed. > 2. Might ask upstream to include a copy of the license. (non blocker) https://github.com/Pylons/pyramid_chameleon/pull/9 ----- Spec URL: http://bochecha.fedorapeople.org/packages/python-pyramid-chameleon.spec SRPM URL: http://bochecha.fedorapeople.org/packages/python-pyramid-chameleon-0.1-2.fc20.src.rpm
ok. It turns out those byte compile errors were some weird issue with my test system. :( Doing a clean scratch build and they don't show up (even with the first revision). So, this package is APPROVED, but please use the -1 reversion, there's no need to mess with byte compile as in the -2 one. Sorry about that.
New Package SCM Request ======================= Package Name: python-pyramid-chameleon Short Description: Bindings for the Chameleon templating system in the Pyramid web framework Upstream URL: https://pypi.python.org/pypi/pyramid_chameleon Owners: bochecha lmacken Branches: devel el6 el7 InitialCC:
Git done (by process-git-requests).
Thanks for the review Kevin, and thank you for the git Jon! Package built, closing.