Bug 1103665 - [SNAPSHOT]: delete only one oldest snapshot
Summary: [SNAPSHOT]: delete only one oldest snapshot
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: glusterd
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Raghavendra Bhat
QA Contact:
URL:
Whiteboard: SNAPSHOT
Depends On:
Blocks: 1103680
TreeView+ depends on / blocked
 
Reported: 2014-06-02 10:08 UTC by Raghavendra Bhat
Modified: 2014-11-11 08:33 UTC (History)
3 users (show)

Fixed In Version: glusterfs-3.6.0beta1
Clone Of:
Environment:
Last Closed: 2014-11-11 08:33:57 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Raghavendra Bhat 2014-06-02 10:08:36 UTC
Description of problem:

As part of autodelete glusterd should delete only one oldest snapshot even though current snap count is more than the soft limit.


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2014-06-02 10:10:25 UTC
REVIEW: http://review.gluster.org/7951 (mgmt/glusterd: delete only the oldest snapshot as part of autodelete) posted (#1) for review on master by Raghavendra Bhat (raghavendra)

Comment 2 Raghavendra Bhat 2014-06-02 11:11:19 UTC
http://review.gluster.org/#/c/7951/

Comment 3 Anand Avati 2014-06-04 09:06:22 UTC
REVIEW: http://review.gluster.org/7951 (mgmt/glusterd: delete only the oldest snapshot as part of autodelete) posted (#2) for review on master by Raghavendra Bhat (raghavendra)

Comment 4 Anand Avati 2014-06-04 12:57:03 UTC
REVIEW: http://review.gluster.org/7951 (mgmt/glusterd: delete only the oldest snapshot as part of autodelete) posted (#3) for review on master by Raghavendra Bhat (raghavendra)

Comment 5 Anand Avati 2014-06-10 06:12:35 UTC
COMMIT: http://review.gluster.org/7951 committed in master by Kaushal M (kaushal) 
------
commit 4b846dbb61fc6f41ba1bb3d52455f1b44e3a656e
Author: Raghavendra Bhat <raghavendra>
Date:   Mon Jun 2 14:47:15 2014 +0530

    mgmt/glusterd: delete only the oldest snapshot as part of autodelete
    
    Now this is how autodelete behaves:
    1) Upon creation when the max-soft-limit exceeds, the oldest snapshot is
       deleted. i.e if hard limit is 100 and by default soft limit is 90.
       Whenever snap count reaches 90, every new create results in the deletion
       of the oldest snapshot.
    2) If the snap limit (hard) is reconfigured and brought down
       the current snap count, then no snapshot is deleted and the next snapshot
       create fails as the current snapcount is more than the hard limit.
    3) When soft limit is brought down: say max limit is 100 and by default soft
       limit is 90 and current snap count is 90. Now, soft limit is changed to
       70 (70%). In this case the snapshot count remains 90 itself (i.e extra
       20 snapshots more than the soft limit are not deleted) and for every new
       create the oldest snapshot is deleted.
    
    Change-Id: I1f3b4b9eb093649f8628ebf09a15bd2570ddf340
    BUG: 1103665
    Signed-off-by: Raghavendra Bhat <raghavendra>
    Reviewed-on: http://review.gluster.org/7951
    Reviewed-by: Rajesh Joseph <rjoseph>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kaushal M <kaushal>

Comment 6 Niels de Vos 2014-09-22 12:41:44 UTC
A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 7 Niels de Vos 2014-11-11 08:33:57 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users


Note You need to log in before you can comment on or make changes to this bug.