Description of problem:

When trying to clone a volume from one pool to another (which looks possible according to the command documentation), virsh tries to create a new volume in the *origin* pool, not the destination one. This function thus can't work to clone a volume from one pool to another.

Looking at the code, it tries to lookup the original volume by name _through the destination pool_, and furthermore gives virStorageVolCreateXMLFrom() the original pool as first argument, while its documentation tells it should be the destination pool. Thus it doesn't work at all when cloning between different pools. The logic didn't change between 0.9.12 and the latest master revision I looked at.

Version-Release number of selected component (if applicable):

0.9.12

How reproducible:

Always, for me. Below is one example where I try to clone a volume *from* pool "vm-group" to pool "images".

Steps to Reproduce:
1. virsh vol-clone --pool images /dev/vm-group/ubuntu-12 ubuntu-12.img
2.
3.

Actual results:

error: Failed to clone vol from ubuntu-12
error: internal error Child process (/sbin/lvcreate --name ubuntu-12.img -L 20971520K vm-group) unexpected exit status 
5:   Volume group "vm-group" has insufficient free space (255 extents): 5120 required.


Expected results:

It clones the volume from "vm-group" to "images", instead of trying to create a volume in the original "vm-group" pool.

Additional info:

Using "virsh vol-create-from" with a manually copied XML works, though, as a workaround.