Bug 1103782
| Summary: | race condition in setting firewall zone for active connection | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Vladimir Benes <vbenes> | ||||||
| Component: | NetworkManager | Assignee: | Thomas Haller <thaller> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Desktop QE <desktop-qa-list> | ||||||
| Severity: | urgent | Docs Contact: | |||||||
| Priority: | urgent | ||||||||
| Version: | 7.1 | CC: | danw, dcbw, jklimes, jkurik, jruemker, thaller | ||||||
| Target Milestone: | rc | Keywords: | ZStream | ||||||
| Target Release: | 7.1 | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | NetworkManager-0.9.9.1-22.git20140326.4dba720.el7_0 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | |||||||||
| : | 1104728 (view as bug list) | Environment: | |||||||
| Last Closed: | 2015-03-05 13:51:28 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 1104728 | ||||||||
| Attachments: |
|
||||||||
|
Description
Vladimir Benes
2014-06-02 14:22:15 UTC
Created attachment 901468 [details]
firewalld log with error in the end
Created attachment 901469 [details]
journal log targzed
*** Bug 1103781 has been marked as a duplicate of this bug. *** Please review branch th/rh1103782_firewall_zone_conflict. It contains some cleanup/refactoring, that I did while fixing this. First I thought I would need them, but in the end the actual fix was much simpler. They are not needed, but I would still apply them as cleanup. > firewall: refactor CBInfo data in NMFirewallManager
I don't like declaring char iface[1]; and then allocating it dynamically. It is kind of unexpected.
Other than that, the branch looks good.
*** Bug 1104566 has been marked as a duplicate of this bug. *** (In reply to Jirka Klimes from comment #5) > > firewall: refactor CBInfo data in NMFirewallManager > I don't like declaring char iface[1]; and then allocating it dynamically. agreed. drop that patch. If we're always going to be passing FALSE for the "add" parameter to nm_firewall_manager_add_or_change_zone(), and always passing NULL for the "zone" parameter to nm_firewall_manager_remove_from_zone(), then we should probably just remove those arguments and the code that handles them. But that could be done as an additional patch on master separate from the z-stream fix.) Merged to master as: http://cgit.freedesktop.org/NetworkManager/NetworkManager/commit/?id=43e4b1b6f786e0e3482d15415f9b0d53bd3a1b1e it looks like I can see the bug again: after setting zone to drop, firewalld is stopped and connection upping fails. uhm, connection upping works but then I cannot see device via firewall-cmd --zone=drop --list-all (In reply to Vladimir Benes from comment #13) > uhm, connection upping works but then I cannot see device via > firewall-cmd --zone=drop --list-all Can you show a logfile? Or a failed test case? Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-0311.html |