Bug 1104041 - CVE-2013-6825 dcmtk: possible privilege escalation if setuid() fails [fedora-all]
Summary: CVE-2013-6825 dcmtk: possible privilege escalation if setuid() fails [fedora-...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: dcmtk
Version: rawhide
Hardware: All
OS: Linux
high
high
Target Milestone: ---
Assignee: Mario Ceresa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: fst_owner=ignatenkobrain
Depends On:
Blocks: CVE-2013-6825
TreeView+ depends on / blocked
 
Reported: 2014-06-03 07:11 UTC by Murray McAllister
Modified: 2016-08-29 14:45 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Release Note
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-08-29 14:45:29 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Murray McAllister 2014-06-03 07:11:03 UTC
This is an automatically created tracking bug!  It was created to ensure
that one or more security vulnerabilities are fixed in affected versions
of Fedora.

For comments that are specific to the vulnerability please use bugs filed
against the "Security Response" product referenced in the "Blocks" field.

For more information see:
http://fedoraproject.org/wiki/Security/TrackingBugs

When creating a Bodhi update request, use the bodhi submission link noted
in the next comment(s).  This will include the bug IDs of this tracking
bug as well as the relevant top-level CVE bugs.

Please also mention the CVE IDs being fixed in the RPM changelog and the
Bodhi notes field when available.

NOTE: this issue affects multiple supported versions of Fedora. While only
one tracking bug has been filed, please correct all affected versions at
the same time.  If you need to fix the versions independent of each other,
you may clone this bug as appropriate.

[bug automatically created by: add-tracking-bugs]

Comment 1 Murray McAllister 2014-06-03 07:11:10 UTC
Use the following update submission link to create the Bodhi request for
this issue as it contains the top-level parent bug(s) as well as this
tracking bug.  This will ensure that all associated bugs get updated when
new packages are pushed to stable.

IMPORTANT: ensure that the "Close bugs when update is stable" option
remains checked.

Bodhi update submission link:
https://admin.fedoraproject.org/updates/new/?type_=security&bugs=1104040,1104041

Comment 2 Igor Gnatenko 2014-07-15 06:52:51 UTC
Upstream patch: http://hmarco.org/bugs/patches/dcmtk-3.6.1-drop-privileges-fixed.patch

Comment 3 Igor Gnatenko 2014-07-15 06:59:22 UTC
Also when you created SCM request you added EPEL6 to branches, but we got
nothing in el6, fix it please ;)

Comment 4 pjp 2014-12-03 18:28:12 UTC
Hello mrceresa,

Could you please fix this soon?

Comment 5 Mario Ceresa 2014-12-04 16:40:20 UTC
Thanks pjp for the prodding. Unfortunately I'm traveling for work and I'm not  able to fix it readily. I'll be more than happy to step back as a mantainer or add you as a comantainer so to stop being the bottelneck here :)

Best,

Mario

Comment 6 pjp 2014-12-05 13:01:33 UTC
Hello Mario,

I've sent a notification to upstream about merging this patch, CC'd you. Could you write to fedora-devel list about a co-maintainer please?

Thank you.

Comment 7 pjp 2014-12-05 16:08:46 UTC
Upstream fixed since Feb 2014.

  -> http://git.dcmtk.org/web?p=dcmtk.git;a=commit;h=beaf5a5c24101daeeafa48c375120b16197c9e95

Comment 8 pjp 2014-12-06 18:36:16 UTC
The latest dcmtk snapshot build should fix this issue, see: BZ#1104040#c3

  -> http://dicom.offis.de/download/dcmtk/snapshot/

Comment 9 Fedora Update System 2014-12-15 16:09:49 UTC
dcmtk-3.6.1-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/dcmtk-3.6.1-1.fc21

Comment 10 Mario Ceresa 2014-12-15 16:13:10 UTC
I packaged the latest snapshot in rawhide and sent an update for f21. I'm not familiar with the CVE bugs. Should I submit also an update for f20? How can we be sure that the bug is solved?

Thanks and regards,

Mario

Comment 11 pjp 2014-12-15 17:32:22 UTC
(In reply to Mario Ceresa from comment #10)
> not familiar with the CVE bugs. Should I submit also an update for f20? How
> can we be sure that the bug is solved?

  Yes, please. The CVE bug was fixed in Feb '14, see comment #7. So the latest snapshot build would include that fix.

Thank you.

Comment 12 Fedora Update System 2014-12-16 10:54:19 UTC
dcmtk-3.6.1-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/dcmtk-3.6.1-1.fc20

Comment 13 Mario Ceresa 2014-12-16 11:28:56 UTC
There are two packages (orthanc and aeskulap) that depend from dcmtk, whose libraries have a different soname. I'm rebuilding them in rawhide but how can i update the branches so that *both* dcmtk and the dependent pacakages are available in the same moment and they don't get broken?

Comment 14 pjp 2014-12-16 11:47:59 UTC
(In reply to Mario Ceresa from comment #13)
> how can i update the branches so that *both* dcmtk and the dependent pacakages
> are available in the same moment and they don't get broken?

To confirm IIUC,

'orthanc' & 'aeskulap' depend on dcmtk, and their latest versions have a different SONAME, than their current builds in F20?

I'm not sure if that is related to CVE-2013-6825 issue. Do those packages need to be updated as result of 'dcmtk' update?

OR

Is it that the latest 'dcmtk' package has a different SONAME and so the update in comment #12 above has already broken those two packages?

Comment 15 Mario Ceresa 2014-12-16 11:54:40 UTC
The latest dcmtk update has a different soname and broke orthanc and aeskulap. Hoever, the change is minor 3.6 -> 3.6.1 and rebuilding orthanc in rawhide worked.

But once the new dcmtk lands into f21 and f20, how can I avoid breaking things there?

Comment 16 pjp 2014-12-16 16:56:51 UTC
(In reply to Mario Ceresa from comment #15)
> But once the new dcmtk lands into f21 and f20, how can I avoid breaking
> things there?

  Well, since the updates have already been pushed to F21 & 20, there is little that can be done now. In case they haven't reached to the -stable repositories yet,

  1. One option is to apply just the patch from comment #7 above to the existing versions in F21 & F20, and push a new update. That should override the earlier update.

  2. And second is to write to the fedora-devel & fedora-users lists to inform the users about the SONAME change in 'dcmtk', and check if it is okay with them.

Comment 17 Fedora Update System 2014-12-17 04:45:29 UTC
Package dcmtk-3.6.1-1.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing dcmtk-3.6.1-1.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-17055/dcmtk-3.6.1-1.fc21
then log in and leave karma (feedback).

Comment 18 Fedora Update System 2014-12-17 11:39:14 UTC
orthanc-0.8.5-2.fc20,dcmtk-3.6.1-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/orthanc-0.8.5-2.fc20,dcmtk-3.6.1-1.fc20

Comment 19 Mario Ceresa 2014-12-17 11:49:39 UTC
In the end, I unpushed all stable branch updates and submitted them again as buildroot overrides.

That should all be set now, just waiting for the testing

Comment 20 Fedora Update System 2014-12-17 12:05:21 UTC
orthanc-0.8.5-2.fc21,dcmtk-3.6.1-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/orthanc-0.8.5-2.fc21,dcmtk-3.6.1-1.fc21

Comment 22 Eric Christensen 2015-04-06 19:08:10 UTC
Did these packages ever get pushed?

Comment 23 Mario Ceresa 2015-04-07 10:10:27 UTC
Dear Eric,
I got a negative karma from mschwendt saying that I rebuilt against the wrong dcmtk but I didn't know what to do next.

Would you be so kind to help me?

Best,

Mario

Comment 24 Eric Christensen 2015-04-23 13:37:30 UTC
(In reply to Mario Ceresa from comment #23)
> Dear Eric,
> I got a negative karma from mschwendt saying that I rebuilt against the
> wrong dcmtk but I didn't know what to do next.
> 
> Would you be so kind to help me?

I'm not sure how I can help, specifically.  Did you contact mschwendt and ask?

Comment 25 Fedora End Of Life 2015-05-29 12:00:45 UTC
This message is a reminder that Fedora 20 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 20. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '20'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 20 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 26 pjp 2015-06-01 10:59:41 UTC
Hello Mario,

(In reply to Mario Ceresa from comment #23)
> I got a negative karma from mschwendt saying that I rebuilt against the
> wrong dcmtk but I didn't know what to do next.
> 
> Would you be so kind to help me?

  Were you able to build & push new updates? Does this issue affect 'dcmtk', in F22? If so we need to move this bug to F22, otherwise considering F20 EOL is approaching, we need to close this bug with canfix/wontfix or eol.

Comment 27 Jan Kurik 2015-07-15 14:40:06 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 23 development cycle.
Changing version to '23'.

(As we did not run this process for some time, it could affect also pre-Fedora 23 development
cycle bugs. We are very sorry. It will help us with cleanup during Fedora 23 End Of Life. Thank you.)

More information and reason for this action is here:
https://fedoraproject.org/wiki/BugZappers/HouseKeeping/Fedora23

Comment 28 Igor Gnatenko 2016-08-08 11:51:01 UTC
ping?

Comment 29 pjp 2016-08-29 12:31:21 UTC
Hello Mario,

Could this be closed?

Comment 30 Mario Ceresa 2016-08-29 14:45:29 UTC
Hello pjp,
current dcmtk has been on snapshot 3.6.1_20140617, which should have fixed the problem since december 2014. I've never closed that because I wasn't sure if I had properly propagated and pushed to all branches and build override. Since that day, we had several mass rebuild which took care of the problem.

I'm closing it now. In case you think there is still something more to do please reopen

Best,

Mario


Note You need to log in before you can comment on or make changes to this bug.