Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1104184

Summary: improper exception handling
Product: Red Hat Enterprise Virtualization Manager Reporter: Martin Mucha <mmucha>
Component: ovirt-engine-restapiAssignee: Martin Mucha <mmucha>
Status: CLOSED CURRENTRELEASE QA Contact: Martin Mucha <mmucha>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 3.5.0CC: aberezin, bazulay, gklein, iheim, juan.hernandez, lpeer, michal.skrivanek, oourfali, oramraz, pstehlik, rbalakri, Rhev-m-bugs, yeylon
Target Milestone: ---Keywords: CodeChange
Target Release: 3.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: infra
Fixed In Version: ovirt-engine-3.5.0_beta Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-02-17 17:07:28 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Infra RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1142923, 1156165    

Description Martin Mucha 2014-06-03 13:01:46 UTC 
Description of problem:
improper exception handling — printing to std.
org.ovirt.engine.api.restapi.types.MappingLocator.MethodInvokerMapper#map
Comment 1 Martin Mucha 2014-08-07 06:48:33 UTC 
tested via artifically throwing exception in method
org.ovirt.engine.api.restapi.types.MappingLocator.MethodInvokerMapper#map
simulating failure of invoking Mapper via reflect api. In that case, MappingExceptionMapper is correctly invoked, producing expected output:

<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<fault>
    <reason>Operation Failed</reason>
</fault>

Problem is (somehow, without stacktrace) logged into engine.log

However, when different exception is thrown here, this exception is printed to the output with full stacktrace, which could be considered as coding error (user should not be interrested in stacktraces in any way) and security issue(nobody but us should be informed about details of failure), both indicate exception handling error on some toplevel class. Will be discussed and potentially addressed in separate bug. But change related to this bug works as expected.
Comment 2 Eyal Edri 2015-02-17 17:07:28 UTC 
rhev 3.5.0 was released. closing.