Spec URL: http://jjames.fedorapeople.org/python-BTrees/python-BTrees.spec SRPM URL: http://jjames.fedorapeople.org/python-BTrees/python-BTrees-4.0.8-1.fc21.src.rpm Fedora Account System Username: jjames Description: This package contains a set of persistent object containers built around a modified BTree data structure. The trees are optimized for use inside ZODB's "optimistic concurrency" paradigm, and include explicit resolution of conflicts detected by that mechanism. Note that fedora-review complains that this package owns a directory owned by python-ZODB3. That is because the new upstream version of python-ZODB3 has split into multiple packages. This is one of them. Once all of the new packages have been reviewed, the new python-ZODB3 will no longer own that directory.
Python-persistent is now available in the Rawhide repo and will shortly hit the F21 repo. We should be able to go forward with this review now. Thanks!
Christopher: ping.
====================================================================== ERROR: testIIBTreeOverflow (BTrees.tests.test_IIBTree.IIBTreeTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/builddir/build/BUILD/python-BTrees-4.0.8/python3-BTrees-4.0.8/BTrees/tests/test_IIBTree.py", line 124, in testIIBTreeOverflow trial(i) File "/builddir/build/BUILD/python-BTrees-4.0.8/python3-BTrees-4.0.8/BTrees/tests/test_IIBTree.py", line 121, in trial self.assertEqual(b[0], i) File "/usr/lib/python3.4/unittest/case.py", line 835, in assertEqual assertion_func(first, second, msg=msg) File "/usr/lib/python3.4/unittest/case.py", line 826, in _baseAssertEqual standardMsg = '%s != %s' % _common_shorten_repr(first, second) File "/usr/lib/python3.4/unittest/util.py", line 25, in _common_shorten_repr args = tuple(map(safe_repr, args)) OverflowError: Python int too large to convert to C long ====================================================================== ERROR: test32 (BTrees.tests.testBTrees.FamilyTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/builddir/build/BUILD/python-BTrees-4.0.8/python3-BTrees-4.0.8/BTrees/tests/testBTrees.py", line 454, in test32 self.assertRaises(TypeError, s.insert, big) File "/usr/lib/python3.4/unittest/case.py", line 742, in assertRaises return context.handle('assertRaises', callableObj, args, kwargs) File "/usr/lib/python3.4/unittest/case.py", line 200, in handle callable_obj(*args, **kwargs) File "/usr/lib/python3.4/unittest/case.py", line 217, in __exit__ self.obj_name)) OverflowError: Python int too large to convert to C long ---------------------------------------------------------------------- Ran 3711 tests in 272.029s FAILED (errors=2)
That failure is specific to 32-bit python 3. A friendly upstream developer gave me a patch to fix the problem. New URLs: Spec URL: http://jjames.fedorapeople.org/python-BTrees/python-BTrees.spec SRPM URL: http://jjames.fedorapeople.org/python-BTrees/python-BTrees-4.0.8-2.fc22.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [-]: Package does not contain kernel modules. [-]: Package contains no static executables. [-]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 130 files have unknown license. Detailed output of licensecheck: Unknown or generated -------------------- python-BTrees-4.0.8/BTrees-4.0.8/BTrees/BTreeItemsTemplate.c python-BTrees-4.0.8/BTrees-4.0.8/BTrees/BTreeModuleTemplate.c python-BTrees-4.0.8/BTrees-4.0.8/BTrees/BTreeTemplate.c python-BTrees-4.0.8/BTrees-4.0.8/BTrees/BucketTemplate.c python-BTrees-4.0.8/BTrees-4.0.8/BTrees/IFBTree.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/IIBTree.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/IOBTree.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/Interfaces.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/LFBTree.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/LLBTree.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/LOBTree.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/Length.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/MergeTemplate.c python-BTrees-4.0.8/BTrees-4.0.8/BTrees/OIBTree.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/OLBTree.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/OOBTree.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/SetOpTemplate.c python-BTrees-4.0.8/BTrees-4.0.8/BTrees/SetTemplate.c python-BTrees-4.0.8/BTrees-4.0.8/BTrees/TreeSetTemplate.c python-BTrees-4.0.8/BTrees-4.0.8/BTrees/_IFBTree.c python-BTrees-4.0.8/BTrees-4.0.8/BTrees/_IIBTree.c python-BTrees-4.0.8/BTrees-4.0.8/BTrees/_IOBTree.c python-BTrees-4.0.8/BTrees-4.0.8/BTrees/_LFBTree.c python-BTrees-4.0.8/BTrees-4.0.8/BTrees/_LLBTree.c python-BTrees-4.0.8/BTrees-4.0.8/BTrees/_LOBTree.c python-BTrees-4.0.8/BTrees-4.0.8/BTrees/_OIBTree.c python-BTrees-4.0.8/BTrees-4.0.8/BTrees/_OLBTree.c python-BTrees-4.0.8/BTrees-4.0.8/BTrees/_OOBTree.c python-BTrees-4.0.8/BTrees-4.0.8/BTrees/__init__.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/_base.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/_compat.h python-BTrees-4.0.8/BTrees-4.0.8/BTrees/_compat.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/_fsBTree.c python-BTrees-4.0.8/BTrees-4.0.8/BTrees/check.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/floatvaluemacros.h python-BTrees-4.0.8/BTrees-4.0.8/BTrees/fsBTree.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/intkeymacros.h python-BTrees-4.0.8/BTrees-4.0.8/BTrees/intvaluemacros.h python-BTrees-4.0.8/BTrees-4.0.8/BTrees/objectkeymacros.h python-BTrees-4.0.8/BTrees-4.0.8/BTrees/objectvaluemacros.h python-BTrees-4.0.8/BTrees-4.0.8/BTrees/sorters.c python-BTrees-4.0.8/BTrees-4.0.8/BTrees/tests/__init__.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/tests/common.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/tests/testBTrees.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/tests/testBTreesUnicode.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/tests/testConflict.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/tests/test_IFBTree.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/tests/test_IIBTree.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/tests/test_IOBTree.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/tests/test_LFBTree.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/tests/test_LLBTree.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/tests/test_LOBTree.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/tests/test_Length.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/tests/test_OIBTree.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/tests/test_OLBTree.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/tests/test_OOBTree.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/tests/test__base.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/tests/test_btreesubclass.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/tests/test_check.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/tests/test_fsBTree.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/tests/test_utils.py python-BTrees-4.0.8/BTrees-4.0.8/BTrees/utils.py python-BTrees-4.0.8/BTrees-4.0.8/bootstrap.py python-BTrees-4.0.8/BTrees-4.0.8/docs/conf.py python-BTrees-4.0.8/BTrees-4.0.8/setup.py [x]: License file installed when any subpackage combination is installed. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/python2.7/site- packages/BTrees(python-ZODB3) [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-BTrees [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Rpmlint ------- Checking: python-BTrees-4.0.8-2.fc22.i686.rpm python3-BTrees-4.0.8-2.fc22.i686.rpm python-BTrees-4.0.8-2.fc22.src.rpm python-BTrees.i686: W: spelling-error Summary(en_US) Scalable -> Salable, Callable, Calculable python3-BTrees.i686: W: spelling-error Summary(en_US) Scalable -> Salable, Callable, Calculable python-BTrees.src: W: spelling-error Summary(en_US) Scalable -> Salable, Callable, Calculable 3 packages and 0 specfiles checked; 0 errors, 3 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint python-BTrees python3-BTrees python-BTrees.i686: W: spelling-error Summary(en_US) Scalable -> Salable, Callable, Calculable python3-BTrees.i686: W: spelling-error Summary(en_US) Scalable -> Salable, Callable, Calculable 2 packages and 0 specfiles checked; 0 errors, 2 warnings. # echo 'rpmlint-done:' Requires -------- python-BTrees (rpmlib, GLIBC filtered): libc.so.6 libpthread.so.0 libpython2.7.so.1.0 python(abi) python-persistent(x86-32) python-zope-interface(x86-32) rtld(GNU_HASH) python3-BTrees (rpmlib, GLIBC filtered): libc.so.6 libpthread.so.0 libpython3.4m.so.1.0 python(abi) python3-persistent(x86-32) python3-zope-interface(x86-32) rtld(GNU_HASH) Provides -------- python-BTrees: python-BTrees python-BTrees(x86-32) python3-BTrees: python3-BTrees python3-BTrees(x86-32) Unversioned so-files -------------------- python-BTrees: /usr/lib/python2.7/site-packages/BTrees/_IFBTree.so python-BTrees: /usr/lib/python2.7/site-packages/BTrees/_IIBTree.so python-BTrees: /usr/lib/python2.7/site-packages/BTrees/_IOBTree.so python-BTrees: /usr/lib/python2.7/site-packages/BTrees/_LFBTree.so python-BTrees: /usr/lib/python2.7/site-packages/BTrees/_LLBTree.so python-BTrees: /usr/lib/python2.7/site-packages/BTrees/_LOBTree.so python-BTrees: /usr/lib/python2.7/site-packages/BTrees/_OIBTree.so python-BTrees: /usr/lib/python2.7/site-packages/BTrees/_OLBTree.so python-BTrees: /usr/lib/python2.7/site-packages/BTrees/_OOBTree.so python-BTrees: /usr/lib/python2.7/site-packages/BTrees/_fsBTree.so python3-BTrees: /usr/lib/python3.4/site-packages/BTrees/_IFBTree.cpython-34m.so python3-BTrees: /usr/lib/python3.4/site-packages/BTrees/_IIBTree.cpython-34m.so python3-BTrees: /usr/lib/python3.4/site-packages/BTrees/_IOBTree.cpython-34m.so python3-BTrees: /usr/lib/python3.4/site-packages/BTrees/_LFBTree.cpython-34m.so python3-BTrees: /usr/lib/python3.4/site-packages/BTrees/_LLBTree.cpython-34m.so python3-BTrees: /usr/lib/python3.4/site-packages/BTrees/_LOBTree.cpython-34m.so python3-BTrees: /usr/lib/python3.4/site-packages/BTrees/_OIBTree.cpython-34m.so python3-BTrees: /usr/lib/python3.4/site-packages/BTrees/_OLBTree.cpython-34m.so python3-BTrees: /usr/lib/python3.4/site-packages/BTrees/_OOBTree.cpython-34m.so python3-BTrees: /usr/lib/python3.4/site-packages/BTrees/_fsBTree.cpython-34m.so Source checksums ---------------- https://pypi.python.org/packages/source/B/BTrees/BTrees-4.0.8.tar.gz : CHECKSUM(SHA256) this package : 51382eabccda66218f7adff838c939f54130e86038adff2b0ace35d192aba899 CHECKSUM(SHA256) upstream package : 51382eabccda66218f7adff838c939f54130e86038adff2b0ace35d192aba899 Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -rvn python-BTrees-4.0.8-2.fc22.src.rpm Buildroot used: fedora-rawhide-i386 Active plugins: Python, Generic, Shell-api, C/C++ Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG ---------------------------- PACKAGE APPROVED.
Thank you very much for the review!
New Package SCM Request ======================= Package Name: python-BTrees Short Description: Scalable persistent object containers Upstream URL: http://www.zodb.org/ Owners: jjames Branches: f21 InitialCC:
Git done (by process-git-requests).
This package has been built for Rawhide and F21.