Bug 1104318 - Console USB configuration not persisted on Edit VM window
Summary: Console USB configuration not persisted on Edit VM window
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: oVirt
Classification: Retired
Component: ovirt-engine-webadmin
Version: 3.5
Hardware: All
OS: All
medium
medium
Target Milestone: ---
: 3.5.0
Assignee: Tomas Jelinek
QA Contact: Ilanit Stein
URL:
Whiteboard: virt
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-06-03 18:20 UTC by Amador Pahim
Modified: 2016-02-10 19:51 UTC (History)
10 users (show)

Fixed In Version: ovirt-engine-3.5.0_beta
Clone Of:
Environment:
Last Closed: 2014-10-17 12:29:05 UTC
oVirt Team: Virt
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 28834 0 master MERGED webadmin: data copied from incorrect source Never

Description Amador Pahim 2014-06-03 18:20:02 UTC 
Description of problem:

Changing USB Support type (Disabled|Native|Legacy), the change takes place to the database and have expected effect. The issue is when edditing again VM, the USB Support option is shown as "Disabled". 

Version-Release number of selected component (if applicable):
3.5.0_master

How reproducible:
100%


Steps to Reproduce:
1. Edit VM
2. Console / USB Support
3. Select Legacy OR Native
4. Click OK
5. Edit VM again
6. Console / USB Support
7. Check selected option. It will be "Disabled"

Additional info:
User Portal affected as well.
Comment 1 Amador Pahim 2014-06-03 20:05:03 UTC 
Additional info:
Faced the issue even with commit a427a5a45f6dbaa7b09a125018e2da645c684d87 "userportal,webadmin: keep proper USB support selection" applied."
Comment 2 Tomas Jelinek 2014-06-06 09:38:17 UTC 
This does not reproduce to me on the current master branch.

I'd like to ask you the following details:

- what exact OS do you have selected on the VM?
- are you using a template? If yes, what OS and USB support is selected on the template?
- are you using instance types? If yes, what OS and USB support is selected on the instance type?
- what is the exact commit on which it happens to you?

Thank you
Comment 3 Amador Pahim 2014-06-06 12:14:14 UTC 
(In reply to Tomas Jelinek from comment #2)
> This does not reproduce to me on the current master branch.
> 
> I'd like to ask you the following details:
> 
> - what exact OS do you have selected on the VM?
> - are you using a template? If yes, what OS and USB support is selected on
> the template?
> - are you using instance types? If yes, what OS and USB support is selected
> on the instance type?
> - what is the exact commit on which it happens to you?
> 
> Thank you

I'm creating a simple VM, no OS or template selected.

Building ovirt on top of a427a5a45f6dbaa7b09a125018e2da645c684d87, it does work as expected. But after a git pull in branch master, the top of master is 181a7369553b522d68495db211293dd52d7be135 and the issue takes place. Seems like something between a427a5a45f6dbaa7b09a125018e2da645c684d87 and 181a7369553b522d68495db211293dd52d7be135 is messing your code.
Comment 4 Ilanit Stein 2014-08-07 07:34:37 UTC 
Verified on oVirt Engine Version: 3.5.0-0.0.master.20140722232058.git8e1babc.el6
Comment 5 Sandro Bonazzola 2014-10-17 12:29:05 UTC 
oVirt 3.5 has been released and should include the fix for this issue.
Note You need to log in before you can comment on or make changes to this bug.