1104642 – [SNAPSHOT]: Snapshot config set is not updated on a node which had glusterd offline and than rebooted

Bug 1104642 - [SNAPSHOT]: Snapshot config set is not updated on a node which had glusterd offline and than rebooted

Summary: [SNAPSHOT]: Snapshot config set is not updated on a node which had glusterd o...

Keywords:
Status:	CLOSED CURRENTRELEASE
Alias:	None
Product:	GlusterFS
Classification:	Community
Component:	glusterd
Sub Component:
Version:	mainline
Hardware:	x86_64
OS:	Linux
Priority:	high
Severity:	high
Target Milestone:	---
Assignee:	Sachin Pandit
QA Contact:
Docs Contact:
URL:
Whiteboard:	SNAPSHOT
Depends On:	1082951
Blocks:
TreeView+	depends on / blocked

Reported:	2014-06-04 12:11 UTC by Sachin Pandit
Modified:	2015-07-26 22:05 UTC (History)
CC List:	8 users (show)
Fixed In Version:	glusterfs-3.6.0beta1
Clone Of:	1082951
Environment:
Last Closed:	2014-11-11 08:34:01 UTC
Regression:	---
Mount Type:	---
Documentation:	---
CRM:
Verified Versions:
Embargoed:
Dependent Products:

Attachments	(Terms of Use)

Comment 1 Anand Avati 2014-06-04 12:12:35 UTC

REVIEW: http://review.gluster.org/7970 (mgmt/glusterd : Import the global options irrespective of change in volume information.) posted (#1) for review on master by Sachin Pandit (spandit)

Comment 2 Anand Avati 2014-06-04 12:12:39 UTC

REVIEW: http://review.gluster.org/7971 (glusterd/snapshot : Store the global snapshot config limit in options) posted (#1) for review on master by Sachin Pandit (spandit)

Comment 3 Anand Avati 2014-06-05 12:27:41 UTC

REVIEW: http://review.gluster.org/7971 (glusterd/snapshot : Store the global snapshot config limit in options) posted (#2) for review on master by Sachin Pandit (spandit)

Comment 4 Anand Avati 2014-06-05 12:27:45 UTC

REVIEW: http://review.gluster.org/7970 (mgmt/glusterd : Import the global options irrespective of change in volume information.) posted (#2) for review on master by Sachin Pandit (spandit)

Comment 5 Anand Avati 2014-06-05 13:10:30 UTC

REVIEW: http://review.gluster.org/7971 (glusterd/snapshot : Store the global snapshot config limit in options) posted (#3) for review on master by Sachin Pandit (spandit)

Comment 6 Anand Avati 2014-06-05 13:10:33 UTC

REVIEW: http://review.gluster.org/7970 (mgmt/glusterd : Import the global options irrespective of change in volume information.) posted (#3) for review on master by Sachin Pandit (spandit)

Comment 7 Anand Avati 2014-06-06 07:42:56 UTC

REVIEW: http://review.gluster.org/7971 (glusterd/snapshot : Store the global snapshot config limit in options) posted (#4) for review on master by Sachin Pandit (spandit)

Comment 8 Anand Avati 2014-06-06 07:43:00 UTC

REVIEW: http://review.gluster.org/7970 (mgmt/glusterd : Import the global options irrespective of change in volume information.) posted (#4) for review on master by Sachin Pandit (spandit)

Comment 9 Anand Avati 2014-06-06 11:02:30 UTC

REVIEW: http://review.gluster.org/7970 (mgmt/glusterd : Import the global options irrespective of change in volume information.) posted (#5) for review on master by Sachin Pandit (spandit)

Comment 10 Anand Avati 2014-06-06 11:03:43 UTC

REVIEW: http://review.gluster.org/7971 (glusterd/snapshot : Store the global snapshot config limit in options) posted (#5) for review on master by Sachin Pandit (spandit)

Comment 11 Anand Avati 2014-06-09 06:34:55 UTC

REVIEW: http://review.gluster.org/7971 (glusterd/snapshot : Store the global snapshot config limit in options) posted (#6) for review on master by Sachin Pandit (spandit)

Comment 12 Anand Avati 2014-06-09 10:27:50 UTC

COMMIT: http://review.gluster.org/7970 committed in master by Kaushal M (kaushal) 
------
commit e95dcdc3193cd33d98349d92218e438e5e37cebc
Author: Sachin Pandit <spandit>
Date:   Wed Jun 4 10:30:59 2014 +0530

    mgmt/glusterd : Import the global options irrespective of change in
    volume information.
    
    Problem : global options maintained by glusterd was getting
    synced only when there was change in volume information.
    
    Solution : Import the global option irrespective of change in
    volume information.
    
    Change-Id: I9e59b3cb25bdc19601a09fcf8df2e31a8481ece0
    BUG: 1104642
    Signed-off-by: Sachin Pandit <spandit>
    Reviewed-on: http://review.gluster.org/7970
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Rajesh Joseph <rjoseph>
    Reviewed-by: Raghavendra Bhat <raghavendra>
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Reviewed-by: Kaushal M <kaushal>

Comment 13 Anand Avati 2014-06-10 04:05:34 UTC

REVIEW: http://review.gluster.org/7971 (glusterd/snapshot : Store the global snapshot config limit in options) posted (#7) for review on master by Sachin Pandit (spandit)

Comment 14 Anand Avati 2014-06-10 12:26:43 UTC

REVIEW: http://review.gluster.org/7971 (glusterd/snapshot : Store the global snapshot config limit in options) posted (#8) for review on master by Sachin Pandit (spandit)

Comment 15 Anand Avati 2014-06-10 12:52:54 UTC

REVIEW: http://review.gluster.org/7971 (glusterd/snapshot : Store the global snapshot config limit in options) posted (#9) for review on master by Sachin Pandit (spandit)

Comment 16 Anand Avati 2014-06-10 16:03:47 UTC

REVIEW: http://review.gluster.org/7971 (glusterd/snapshot : Store the global snapshot config limit in options) posted (#10) for review on master by Sachin Pandit (spandit)

Comment 17 Anand Avati 2014-06-11 07:25:55 UTC

REVIEW: http://review.gluster.org/7971 (glusterd/snapshot : Store the global snapshot config limit in options) posted (#11) for review on master by Sachin Pandit (spandit)

Comment 18 Anand Avati 2014-06-11 07:43:06 UTC

REVIEW: http://review.gluster.org/7971 (glusterd/snapshot : Store the global snapshot config limit in options) posted (#12) for review on master by Sachin Pandit (spandit)

Comment 19 Anand Avati 2014-06-11 11:40:35 UTC

REVIEW: http://review.gluster.org/7971 (glusterd/snapshot : Store the global snapshot config limit in options) posted (#13) for review on master by Sachin Pandit (spandit)

Comment 20 Anand Avati 2014-06-11 11:58:13 UTC

REVIEW: http://review.gluster.org/7971 (glusterd/snapshot : Store the global snapshot config limit in options.) posted (#14) for review on master by Sachin Pandit (spandit)

Comment 21 Anand Avati 2014-06-12 04:54:15 UTC

COMMIT: http://review.gluster.org/7971 committed in master by Krishnan Parthasarathi (kparthas) 
------
commit 5906be31845f6a63ff9d5cd15ad0c13af51b81ea
Author: Sachin Pandit <spandit>
Date:   Wed Jun 4 03:41:35 2014 +0530

    glusterd/snapshot : Store the global snapshot config limit in options.
    
    Problem : Initially we used to save the global config
    limit in glusterd.info, The problem with that approach
    was glusterd.info is local to a particular glusterd
    and hence is not synced during the handshake of glusterds.
    
    Solution : Store the global snapshot config in options,
    which is synced during handshake.
    
    Change-Id: I4c688bb4052a57df28aadba8581b14e2ddb510ef
    BUG: 1104642
    Signed-off-by: Sachin Pandit <spandit>
    Reviewed-on: http://review.gluster.org/7971
    Reviewed-by: Rajesh Joseph <rjoseph>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Atin Mukherjee <amukherj>
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Krishnan Parthasarathi <kparthas>

Comment 22 Anand Avati 2014-06-12 06:13:27 UTC

REVIEW: http://review.gluster.org/8041 (tests : Fix for spurious failure of bug-1104642.t.) posted (#1) for review on master by Sachin Pandit (spandit)

Comment 23 Anand Avati 2014-06-12 06:23:00 UTC

REVIEW: http://review.gluster.org/8041 (tests : Fix for spurious failure of bug-1104642.t.) posted (#2) for review on master by Sachin Pandit (spandit)

Comment 24 Anand Avati 2014-06-12 10:58:11 UTC

COMMIT: http://review.gluster.org/8041 committed in master by Vijay Bellur (vbellur) 
------
commit 75279b20e956588ba7f6c7f2a5b8fa15da5672ed
Author: Sachin Pandit <spandit>
Date:   Thu Jun 12 04:31:47 2014 +0530

    tests : Fix for spurious failure of bug-1104642.t.
    
    Problem :
    This test case checks whether global option is updated
    when glusterd goes down and comes back up.
    
    There might be a scenario where the handshake is not
    completed yet and we issue a volume info in between.
    In that case when we try to grep a key from gluster volume info
    output it might not be there.
    
    Hence to get some time we can issue a peer status command
    and verify that the peer count is correct.
    
    Change-Id: I2933d55ce8c80517a555fa3c2e4cd768cde30abf
    BUG: 1104642
    Signed-off-by: Sachin Pandit <spandit>
    Reviewed-on: http://review.gluster.org/8041
    Reviewed-by: Raghavendra Talur <rtalur>
    Reviewed-by: Atin Mukherjee <amukherj>
    Reviewed-by: Pranith Kumar Karampuri <pkarampu>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 25 Anand Avati 2014-06-18 11:30:21 UTC

REVIEW: http://review.gluster.org/8099 (glusterd/snapshot: Updating "global-option-version" in /var/lib/glusterd/options) posted (#1) for review on master by Avra Sengupta (asengupt)

Comment 26 Anand Avati 2014-06-18 13:38:03 UTC

COMMIT: http://review.gluster.org/8099 committed in master by Kaushal M (kaushal) 
------
commit 2b87e157a50953b542d5fc49fac84813ee116ce5
Author: Avra Sengupta <asengupt>
Date:   Wed Jun 18 11:28:05 2014 +0000

    glusterd/snapshot: Updating "global-option-version" in
    /var/lib/glusterd/options
    
    When auto-delete option is set, we should update the
    "global-option-version" in /var/lib/glusterd/options
    to the next version.
    
    Change-Id: Ic561f33531a27cb8cca01d25632511205927268a
    BUG: 1104642
    Signed-off-by: Avra Sengupta <asengupt>
    Reviewed-on: http://review.gluster.org/8099
    Reviewed-by: Atin Mukherjee <amukherj>
    Reviewed-by: Sachin Pandit <spandit>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kaushal M <kaushal>

Comment 27 Niels de Vos 2014-09-22 12:41:48 UTC

A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 28 Niels de Vos 2014-11-11 08:34:01 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users

Note You need to log in before you can comment on or make changes to this bug.