Bug 1104661 - zero returncode on error
Summary: zero returncode on error
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-image-uploader
Version: 3.5.0
Hardware: Unspecified
OS: Unspecified
medium
medium
Target Milestone: ovirt-4.0.0-alpha
: 4.0.0
Assignee: Lev Veyde
QA Contact: Gonza
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-06-04 13:04 UTC by Petr Beňas
Modified: 2016-08-23 21:00 UTC (History)
10 users (show)

Fixed In Version: ovirt 4.0.0 alpha1
Doc Type: Bug Fix
Doc Text:
Previously, a returncode of 0 was returned, even if something went wrong during the file upload phase. Now, this has been corrected and makes the program return ExitCodes.UPLOAD_ERR code (3) if something went wrong during the file upload phase.
Clone Of:
Environment:
Last Closed: 2016-08-23 21:00:04 UTC
oVirt Team: Integration
Target Upstream Version:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHEA-2016:1746 0 normal SHIPPED_LIVE ovirt-image-uploader bug fix and enhancement update for RHV 4.0 2016-09-02 22:08:56 UTC
oVirt gerrit 47501 0 master MERGED ovirt-image-uploader: return non-zero returncodes Never

Description Petr Beňas 2014-06-04 13:04:16 UTC 
Description of problem:
When an image is uploaded twice with the --ovf-id option, error is properly reported, but the returncode is zero. 

Version-Release number of selected component (if applicable):
rhevm-image-uploader-3.4.0-2.el6ev.noarch

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 2 Sandro Bonazzola 2015-02-23 14:28:49 UTC 
Not critical, not urgent, not a regression, postponing to 3.6
Comment 3 Gonza 2016-06-24 12:22:59 UTC 
Verified with:
ovirt-image-uploader-4.0.0-1.el7ev.noarch

# engine-image-uploader -e export_domain -N appliance --ovf-id upload rhevm-appliance-20160623.0-1.x86_64.rhevm.ova 
WARNING: ovirt-image-uploader is deprecated in 4.0 and will be removed in 4.1
Please provide the REST API password for the admin@internal oVirt Engine user (CTRL+D to abort): 
ERROR: /tmp/tmpu5InQw/6f6d46f8-12a6-49c8-9814-c4903b95466f/master/vms/7b51fb3b-c42b-4f0b-89ce-a2d778a4734e/7b51fb3b-c42b-4f0b-89ce-a2d778a4734e.ovf exists on 10.34.63.199.  Either remove it or supply the --force option to overwrite it.
# echo $?
3
Comment 5 errata-xmlrpc 2016-08-23 21:00:04 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHEA-2016-1746.html
Note You need to log in before you can comment on or make changes to this bug.