Bug 1104667 - Add support for index-less queries using the EntryRetriever
Summary: Add support for index-less queries using the EntryRetriever
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: JBoss Data Grid 6
Classification: JBoss
Component: Infinispan
Version: 6.3.0
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: CR2
: 6.3.0
Assignee: Tristan Tarrant
QA Contact: Martin Gencur
URL:
Whiteboard:
Depends On:
Blocks: 1104639
TreeView+ depends on / blocked
 
Reported: 2014-06-04 13:20 UTC by Adrian Nistor
Modified: 2015-01-26 14:03 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2015-01-26 14:03:32 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker ISPN-3717 0 Major Resolved Add support for index-less queries using the EntryRetriever 2014-09-01 12:21:01 UTC

Description Adrian Nistor 2014-06-04 13:20:24 UTC
Backport ISPN-3717 "Add support for index-less queries using the EntryRetriever" to JDG.

Comment 2 Adrian Nistor 2014-06-04 17:57:19 UTC
Pull request here: https://github.com/infinispan/jdg/pull/113

Comment 3 Radim Vansa 2014-06-19 10:00:16 UTC
Anistor: is there any reason why you copy-pasted the DSL tests instead of making the original test abstract and differing the test only in configuration? For example, the NonIndexedQueryDslConditionsTest has 1300 lines that are just duplicit.

Comment 4 Adrian Nistor 2014-06-19 11:09:14 UTC
Yes, the copied test class has some of the tests disabled because the non-indexed query is missbehaving in some edge cases and most notably because it does not support order by, at least not until this one gets integrated: https://github.com/infinispan/infinispan/pull/2655. The pre-existing tests are also a bit wrong in assuming a certain order of results without specifying 'order by'; the order was implicitly insured by the lucene backend, but not by non-indexed query so it leads to several failures.

So they are temporarily split until we fix all of them and make them pass. Then we can start unifying the suites for both indexed/non-indexed, embedded/remote.

I was also dissapointed some time ago seeing duplications like ClusteredQueryDslConditionsTest, but I accepted it since there was no quick solution at the moment.

Comment 5 Radim Vansa 2014-06-19 12:10:56 UTC
OK, it seems that this needs some more work - I can't verify this as implemented and working when it's not.

Comment 6 Adrian Nistor 2014-06-30 08:08:17 UTC
Sorting and pagination is working now, https://bugzilla.redhat.com/show_bug.cgi?id=1112740 was resolved.

Comment 7 Martin Gencur 2014-07-08 13:28:17 UTC
Moving target to CR2 so that we don't miss that.


Note You need to log in before you can comment on or make changes to this bug.