Bug 1105028 - It's possible to create the same entity of Network QOS on the same DC
Summary: It's possible to create the same entity of Network QOS on the same DC
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Enterprise Virtualization Manager
Classification: Red Hat
Component: ovirt-engine
Version: 3.4.0
Hardware: x86_64
OS: Linux
low
medium
Target Milestone: ovirt-3.6.0-rc3
: 3.6.0
Assignee: Doron Fediuck
QA Contact: GenadiC
URL:
Whiteboard:
Depends On:
Blocks: 1167327
TreeView+ depends on / blocked
 
Reported: 2014-06-05 09:05 UTC by GenadiC
Modified: 2016-04-20 01:36 UTC (History)
12 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-04-20 01:36:44 UTC
oVirt Team: SLA
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
screen shot with several Network QOS entities with the same name (445.10 KB, image/png)
2014-06-05 09:05 UTC, GenadiC
no flags Details


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 34154 0 master MERGED core: QoS name uniquness Never

Description GenadiC 2014-06-05 09:05:07 UTC
Created attachment 902455 [details]
screen shot with several Network QOS entities with the same name

Description of problem:
By clicking quickly on ok button during creation of Network QOS entity we managed to create that entity twice under the specific DC.

Version-Release number of selected component (if applicable):


How reproducible:
Sometimes - it happens always on slow environment

Steps to Reproduce:
1. Create new Network QOS entity
2. Fill in parameters
3. Click several times quickly on ok button

Actual results:
Several entities of Network QOS with the same parameters will be created

Expected results:
It should be impossible to create more than one Network QOS entity with the same parameters

Additional info:
It looks like Network QOS is not a single entity that we can create the same instance more than once when it should be blocked

Comment 1 Lior Vernia 2014-07-03 11:52:35 UTC
Although this was opened on the GUI (and could be blocked specifically in the GUI), the same problem could probably be triggered via the API by sending two identical add commands at close proximity.

Therefore, this should probably be solved in the backend; one alternative would be to define a uniqueness constraint on the DB by a name/DC combination (which should cause one of the actions to fail since the other has already created the DB entry).

Comment 2 Lior Vernia 2014-07-10 11:40:33 UTC
Moving to SLA as starting from 3.5 QoS entities are their domain.

Comment 3 Eyal Edri 2015-02-25 08:45:34 UTC
3.5.1 is already full with bugs (over 80), and since none of these bugs were added as urgent for 3.5.1 release in the tracker bug, moving to 3.5.2

Comment 4 Michael Burman 2015-05-06 05:57:25 UTC
Verified on - 3.6.0-0.0.master.20150412172306.git55ba764.el6

Comment 6 Eyal Edri 2015-11-01 14:26:28 UTC
this bug has both 3.5.z & 3.6.0 flags, in bugzilla lang it means its a clone candidate from 3.6.0 to 3.5.z meaning it's pending a clone and wasn't fixed for 3.5.z.

if this isn't the case, please fix flags accordingly,
if it is the case, then please clone the bugs to 3.5.7 (3.5.6 was built already)


Note You need to log in before you can comment on or make changes to this bug.