Bug 1105050 - Review Request: python-distlib - Low-level components of distutils2/packaging, augmented with higher-level APIs
Summary: Review Request: python-distlib - Low-level components of distutils2/packaging...
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert Kuska
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-06-05 09:45 UTC by Matej Stuchlik
Modified: 2016-02-01 02:15 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-06-06 12:50:15 UTC
Type: ---
Embargoed:
rkuska: fedora-review+
gwync: fedora-cvs+


Attachments (Terms of Use)

Description Matej Stuchlik 2014-06-05 09:45:50 UTC
Spec URL: http://mstuchli.fedorapeople.org/python-distlib.spec
SRPM URL: http://mstuchli.fedorapeople.org/python-distlib-0.1.9-1.fc20.src.rpm
Description: Distlib contains the implementations of the packaging PEPs and other low-level
features which relate to packaging, distribution and deployment of Python
software. If Distlib can be made genuinely useful, then it is possible for
third-party packaging tools to transition to using it. Their developers and
users then benefit from standardised implementation of low-level functions,
time saved by not having to reinvent wheels, and improved interoperability
between tools.

Fedora Account System Username: mstuchli

koji scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=6926117

Comment 1 Robert Kuska 2014-06-05 13:25:00 UTC
BuildRequires:  python-setuptools
and
BuildRequires:  python3-setuptools

are actualy not needed.

Also distlib vendorize some python libs in distlib/_backport (tarfile.py, sysconfig.py, shutil.py).

cat distlib/_backport/__init__.py
"""Modules copied from Python 3 standard libraries, for internal use only.

Individual classes and functions are found in d2._backport.misc.  Intended
usage is to always import things missing from 3.1 from that module: the
built-in/stdlib objects will be used if found.
"""

There is SKIP_SLOW[1] env variable to skip some of those tests which fail, but it's only small bonus. :-)

[1] http://pythonhosted.org//distlib/tutorial.html#pypi-availability

Comment 2 Matej Stuchlik 2014-06-05 16:07:33 UTC
(In reply to Robert Kuska from comment #1)
> BuildRequires:  python-setuptools
> and
> BuildRequires:  python3-setuptools
> 
> are actualy not needed.

Good point.
 
> Also distlib vendorize some python libs in distlib/_backport (tarfile.py,
> sysconfig.py, shutil.py).
> 
> cat distlib/_backport/__init__.py
> """Modules copied from Python 3 standard libraries, for internal use only.
> 
> Individual classes and functions are found in d2._backport.misc.  Intended
> usage is to always import things missing from 3.1 from that module: the
> built-in/stdlib objects will be used if found.
> """

Well done noticing this, it did not occur to me to check, will fix.
 
> There is SKIP_SLOW[1] env variable to skip some of those tests which fail,
> but it's only small bonus. :-)
> 
> [1] http://pythonhosted.org//distlib/tutorial.html#pypi-availability

I did notice that, however since, as you note, it only skips some of the failing tests I chose not to use it.

Comment 3 Matej Stuchlik 2014-06-06 08:47:21 UTC
Updated the spec.

Comment 4 Robert Kuska 2014-06-06 12:23:27 UTC
Looks nice, approved.

Comment 5 Matej Stuchlik 2014-06-06 12:27:45 UTC
New Package SCM Request
=======================
Package Name: python-distlib
Short Description: Low-level components of distutils2/packaging, augmented with higher-level APIs
Upstream URL: https://bitbucket.org/vinay.sajip/distlib
Owners: mstuchli
Branches: 
InitialCC:

Comment 6 Gwyn Ciesla 2014-06-06 12:35:45 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.