Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1105147

Summary:	Setting either of user.cifs or user.smb to disable should disable smb shares when the smb share is already available
Product:	[Community] GlusterFS	Reporter:	Raghavendra Talur <rtalur>
Component:	gluster-smb	Assignee:	Raghavendra Talur <rtalur>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	mainline	CC:	bugs, lmohanty
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1107606 (view as bug list)		Environment:
Last Closed:	2015-05-15 17:08:54 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1107606

Description Raghavendra Talur 2014-06-05 13:36:21 UTC

Description of problem:
We have two volume options, user.cifs and user.smb which are considered
valid keys for enabling/disabling of smb shares.

user.smb was introduced later and user.cifs is maintained for backwards
compatibility.

The approach taken is disable has more weightage than enable.
If either of the two keys have value as disable then the combined effect is
that of disable.

Start and stop volume hookscripts work as per above approach.
Set option hookscript does not. This leads to a inconsistent behaviour.


Version:


How reproducible:
Always


Steps to Reproduce:
1. gluster volume set volname user.cifs disable
2. smbclient -L localhost
check that share related to volume is not available.
3. gluster volume set volname user.smb enable
4.smbclient -L localhost


Actual results:
smbclient output shows that share related to this volume is available.

Expected results:
smbclient output should not have share related to this volume.

Additional info:

Comment 1 Anand Avati 2014-11-04 12:54:01 UTC

REVIEW: http://review.gluster.org/9042 (extras/hookscripts: Fix set behaviour for user.cifs and user.smb) posted (#2) for review on master by Raghavendra Talur (rtalur)

Comment 2 Lalatendu Mohanty 2014-11-07 06:17:14 UTC

The issue comes when , the volume is already in started and then if you disable either user.cifs or user.smb and smb.conf was not getting updated to reflect this and the patch will fix it.

Comment 3 Anand Avati 2014-11-10 05:42:07 UTC

REVIEW: http://review.gluster.org/9042 (extras/hookscripts: Fix set behaviour for user.cifs and user.smb) posted (#4) for review on master by Raghavendra Talur (rtalur)

Comment 4 Anand Avati 2014-11-12 06:39:09 UTC

COMMIT: http://review.gluster.org/9042 committed in master by Krishnan Parthasarathi (kparthas) 
------
commit 1800fba11260b348d06bfc21244c4ebc72bd7b95
Author: Raghavendra Talur <rtalur>
Date:   Tue Nov 4 16:44:58 2014 +0530

    extras/hookscripts: Fix set behaviour for user.cifs and user.smb
    
    Setting either of user.cifs or user.smb to disable should disable smb
    shares when the smb share is already available.
    
    Change-Id: I213ffca9cedc14107daeb30271d1f41dd9d7fcf4
    BUG: 1105147
    Signed-off-by: Raghavendra Talur <rtalur>
    Reviewed-on: http://review.gluster.org/9042
    Reviewed-by: Lalatendu Mohanty <lmohanty>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Jose A. Rivera <jarrpa>
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Krishnan Parthasarathi <kparthas>

Comment 5 Niels de Vos 2015-05-15 17:08:54 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user