Description of problem: We have two volume options, user.cifs and user.smb which are considered valid keys for enabling/disabling of smb shares. user.smb was introduced later and user.cifs is maintained for backwards compatibility. The approach taken is disable has more weightage than enable. If either of the two keys have value as disable then the combined effect is that of disable. Start and stop volume hookscripts work as per above approach. Set option hookscript does not. This leads to a inconsistent behaviour. Version: How reproducible: Always Steps to Reproduce: 1. gluster volume set volname user.cifs disable 2. smbclient -L localhost check that share related to volume is not available. 3. gluster volume set volname user.smb enable 4.smbclient -L localhost Actual results: smbclient output shows that share related to this volume is available. Expected results: smbclient output should not have share related to this volume. Additional info:
REVIEW: http://review.gluster.org/9042 (extras/hookscripts: Fix set behaviour for user.cifs and user.smb) posted (#2) for review on master by Raghavendra Talur (rtalur)
The issue comes when , the volume is already in started and then if you disable either user.cifs or user.smb and smb.conf was not getting updated to reflect this and the patch will fix it.
REVIEW: http://review.gluster.org/9042 (extras/hookscripts: Fix set behaviour for user.cifs and user.smb) posted (#4) for review on master by Raghavendra Talur (rtalur)
COMMIT: http://review.gluster.org/9042 committed in master by Krishnan Parthasarathi (kparthas) ------ commit 1800fba11260b348d06bfc21244c4ebc72bd7b95 Author: Raghavendra Talur <rtalur> Date: Tue Nov 4 16:44:58 2014 +0530 extras/hookscripts: Fix set behaviour for user.cifs and user.smb Setting either of user.cifs or user.smb to disable should disable smb shares when the smb share is already available. Change-Id: I213ffca9cedc14107daeb30271d1f41dd9d7fcf4 BUG: 1105147 Signed-off-by: Raghavendra Talur <rtalur> Reviewed-on: http://review.gluster.org/9042 Reviewed-by: Lalatendu Mohanty <lmohanty> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Jose A. Rivera <jarrpa> Reviewed-by: Krishnan Parthasarathi <kparthas> Tested-by: Krishnan Parthasarathi <kparthas>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report. glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939 [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user