Bug 1105422 - KDE file dialogs not showing in libreoffice
Summary: KDE file dialogs not showing in libreoffice
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: qt
Version: 20
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kevin Kofler
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-06-06 05:46 UTC by Nicholas van Oudtshoorn
Modified: 2014-06-27 02:28 UTC (History)
14 users (show)

Fixed In Version: qt-4.8.6-9.fc20
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-06-15 01:50:04 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Qt Bug Tracker QTBUG-34614 0 None None None Never
Qt Bug Tracker QTBUG-37380 0 None None None Never
Qt Bug Tracker QTBUG-38585 0 None None None Never

Description Nicholas van Oudtshoorn 2014-06-06 05:46:43 UTC
Description of problem:
It used to be that libreoffice would show the kdialog for opening and saving files. Instead it now uses the libreoffice native file dialog. This regressed a few weeks ago.

Version-Release number of selected component (if applicable):
Libreoffice: 4.2.4.2-15.fc20

How reproducible:


Steps to Reproduce:
1. Run libreoffice in a KDE session, with libreoffice-kde pacakge installed.
2. File->Open

Actual results:
The libreoffice file dialog appears.

Expected results:
The KDE file dialog appears (kdialog)

Additional info:
This was working fine until a version or two back. (Even though it would sometimes go very slowly. A bug (and patch) has been filed upstream for the slowness of the file dialog.)

Comment 1 David Tardon 2014-06-06 08:37:48 UTC
It has been disabled in configure because it had caused frequent hangouts. If Qt fixes the following bugs, it will be enabled again:

https://bugreports.qt-project.org/browse/QTBUG-37380
https://bugreports.qt-project.org/browse/QTBUG-34614
https://bugreports.qt-project.org/browse/QTBUG-38585

Comment 2 Kevin Kofler 2014-06-06 21:19:38 UTC
Why haven't you talked to us BEFORE "fixing" LibreOffice by crippling its KDE integration?

All 3 upstream bugs have patches attached, we should be able to fix these issues quickly.

Comment 3 Rex Dieter 2014-06-06 21:57:09 UTC
For what its worth, I agree with comment #1, that fixing the Qt bugs are a prerequisite.

Comment 4 Kevin Kofler 2014-06-06 22:30:50 UTC
But we can't fix them if we aren't TOLD that they exist until the user complaints about the intentionally introduced LibreOffice regression come in.

Crippling or disabling libreoffice-kde is just NOT acceptable, especially without talking to us KDE SIG people first.

Comment 5 Kevin Kofler 2014-06-06 22:32:01 UTC
I'm going to do Qt builds with the patches from the upstream bug tracker.

Comment 6 Kevin Kofler 2014-06-06 22:53:31 UTC
Building for Rawhide now, will do F20 and F19 once it succeeds.

The latest of the 3 patches is dated April 25, so we could have done this fixed build 6 weeks (!) ago if only we had been TOLD about the issue. It's obvious that these bugs needed to be fixed in Qt, crippling LibreOffice's KDE integration was the entirely WRONG "solution" to the problem.

Comment 7 David Tardon 2014-06-06 23:07:36 UTC
(In reply to Kevin Kofler from comment #2)
> Why haven't you talked to us BEFORE "fixing" LibreOffice by crippling its
> KDE integration?

We have not "fixed" anything. The change in configure was done upstream; I did not even notice it. And if you think that disabling the feature silently instead of failing is wrong thing, go shout at Luboš.

Comment 8 David Tardon 2014-06-06 23:16:23 UTC
(In reply to Kevin Kofler from comment #4)
> But we can't fix them if we aren't TOLD that they exist until the user
> complaints about the intentionally introduced LibreOffice regression come in.

Again, please direct your yelling at Luboš, not myself.

> 
> Crippling or disabling libreoffice-kde is just NOT acceptable, especially
> without talking to us KDE SIG people first.

libreoffice-kde was only added after persistent nagging by Lukáš Tinkl and under the condition that he was going to take care of KDE-specific bugs. That was the last time we have heard from him. He is CC'd on all libreoffice bugs. We even assign everyting KDE-specific directly to him. If he does not care, why should I?

Comment 9 Kevin Kofler 2014-06-06 23:24:30 UTC
I'm going to bring the libreoffice-kde maintenance issue up with Lukáš at the next KDE SIG meeting. In this particular case, he might have also missed the unhelpful upstream "fix" from Luboš. (I hate it when upstream projects try working around library bugs, because they only make extra work for the distros who want to just fix the library.)

Comment 10 David Tardon 2014-06-06 23:25:03 UTC
(In reply to Kevin Kofler from comment #6)
> Building for Rawhide now, will do F20 and F19 once it succeeds.
> 
> The latest of the 3 patches is dated April 25, so we could have done this
> fixed build 6 weeks (!) ago if only we had been TOLD about the issue.

One of libreoffice's co-maintainers is a member of your SIG. GO YELL AT HIM.

> It's
> obvious that these bugs needed to be fixed in Qt, crippling LibreOffice's
> KDE integration was the entirely WRONG "solution" to the problem.

Frankly, given your attitude and Lukáš's continued ignoring of all KDE-related bugs, I think that the right solution is to throw libreoffice-kde out...

Comment 11 Nicholas van Oudtshoorn 2014-06-07 01:19:59 UTC
Wow... please don't remove it, from an end-user perspective. It sounds like there was a bit of an issue on the libreoffice upstream side.... they should at least have referenced the change in a changelog!

If necessary, I'd be happy to step in as another liason between KDE/libreoffice... If it would help. (I've already got a few fedora packages)

Comment 12 Kevin Kofler 2014-06-07 01:56:14 UTC
I expect to have a fixed Qt build for F20 ready tomorrow, then we just need to undo the upstream LibreOffice change.

Comment 13 Nicholas van Oudtshoorn 2014-06-07 03:49:29 UTC
(In reply to Kevin Kofler from comment #12)
> I expect to have a fixed Qt build for F20 ready tomorrow, then we just need
> to undo the upstream LibreOffice change.

According to the upstream bug ( https://bugs.freedesktop.org/show_bug.cgi?id=69002 ) it looks as if the patch that disabled the integration is reasonably clever: it should automatically detect that Qt has been fixed when libreoffice is rebuilt. (The "offending" patch: http://cgit.freedesktop.org/libreoffice/core/commit/?id=80f113efa6f60c6b3aad33128921792451f114ce&h=libreoffice-4-2 )

Comment 14 Kevin Kofler 2014-06-08 00:00:55 UTC
I'm building F20 and F19 builds of the fixed Qt now. We need to put the F20 build in a buildroot override and rebuild LibreOffice against it.

Comment 15 Kevin Kofler 2014-06-08 23:22:03 UTC
qt-4.8.6-9.fc20 and qt-4.8.6-9.fc19 should fix the Qt part of the issue.

qt-4.8.6-9.fc20 tagged as buildroot override (through the Bodhi self-service system), rebuilding LibreOffice against it now (libreoffice-4.2.4.2-19.fc20 now building).

Comment 16 Kevin Kofler 2014-06-09 00:17:39 UTC
Actually, the LibreOffice rebuild is probably not necessary (but I'll let it complete anyway now that I submitted it). The configure warning says:
> configure: WARNING: native KDE4 file pickers will be disabled at runtime - fix your Qt4 library!
and indeed, the test in the patch appears to be a runtime test. The configure check only prints a warning and does not actually disable anything at compile time.

So the Qt fix (qt-4.8.6-9.fc20) should be enough to fix this.

Comment 17 Fedora Update System 2014-06-11 12:35:10 UTC
qt-4.8.6-9.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/qt-4.8.6-9.fc20

Comment 18 Fedora Update System 2014-06-11 12:36:11 UTC
qt-4.8.6-9.fc19 has been submitted as an update for Fedora 19.
https://admin.fedoraproject.org/updates/qt-4.8.6-9.fc19

Comment 19 Fedora Update System 2014-06-12 06:25:33 UTC
Package qt-4.8.6-9.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing qt-4.8.6-9.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-7284/qt-4.8.6-9.fc20
then log in and leave karma (feedback).

Comment 20 Fedora Update System 2014-06-15 01:50:04 UTC
qt-4.8.6-9.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 21 Fedora Update System 2014-06-27 02:28:24 UTC
qt-4.8.6-9.fc19 has been pushed to the Fedora 19 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.