Bug 1105456 - delete --param ssp-buffer-size=4 in the build
Summary: delete --param ssp-buffer-size=4 in the build
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Virtualization Tools
Classification: Community
Component: libvirt
Version: unspecified
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Libvirt Maintainers
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-06-06 07:46 UTC by Agostino Sarubbo
Modified: 2014-06-12 06:38 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-06-12 06:38:07 UTC
Embargoed:


Attachments (Terms of Use)

Description Agostino Sarubbo 2014-06-06 07:46:17 UTC
Description of problem:
I noticed that on my build of libvirt, I have -fstack-protector-all --param ssp-buffer-size=4.
This make no sense because -fstack-protector-all is covering all, so you don't need to specify the minimum buffer size to cover.

--param ssp-buffer-size is used with -fstack-protector which theoretically covers the buffers of >=8


Version-Release number of selected component (if applicable):
1.2.3


How reproducible:
Just compile and check the output



Expected results:
Have only -fstack-protector-all

Comment 1 Ján Tomko 2014-06-12 06:38:07 UTC
Fixed upstream by
commit 5567baa973ae855fe849e0ef32fb6b7f3eaa0bf0
Author:     Ján Tomko <jtomko>
CommitDate: 2014-06-12 08:16:03 +0200

    build: remove ssp-buffer-size
git describe: v1.2.5-104-g5567baa


Note You need to log in before you can comment on or make changes to this bug.