Spec URL: https://www.dropbox.com/s/ycxcfrhrk1jxn75/otter-browser.spec SRPM URL: https://www.dropbox.com/s/4k3wxa85w3ynrdk/otter-browser-0.9.01-1.fc20.src.rpm Description: Browser aiming to recreate classic Opera (12.x) UI using Qt5. Fedora Account System Username: martinkg rpmlint otter-browser-0.9.01-1.fc20.src.rpm otter-browser.src: W: spelling-error Summary(en_US) versa -> avers, verse, verso otter-browser.src: W: invalid-url Source0: otter-0.9.01.tar.gz 1 packages and 0 specfiles checked; 0 errors, 2 warnings. rpmlint otter-browser-0.9.01-1.fc20.x86_64.rpm otter-browser.x86_64: W: spelling-error Summary(en_US) versa -> avers, verse, verso otter-browser.x86_64: W: no-manual-page-for-binary otter-browser 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
Spec URL: https://www.dropbox.com/s/ycxcfrhrk1jxn75/otter-browser.spec SRPM URL: https://www.dropbox.com/s/73omj9754uwqy6c/otter-browser-0.9.01-2.fc20.src.rpm %changelog * Fri Jun 06 2014 Martin Gansser <martinkg> - 0.9.01-2 - added BR desktop-file-utils
Spec URL: http://martinkg.fedorapeople.org/Review/SPECS/otter-browser.spec SRPM URL: http://martinkg.fedorapeople.org/Review/SRPMS/otter-browser-0.9.01-3.fc20.src.rpm %changelog * Sat Jun 07 2014 Martin Gansser <martinkg> - 0.9.01-3 - replaced qmake-qt5 by cmake - added manual page
Spec URL: http://martinkg.fedorapeople.org/Review/SPECS/otter-browser.spec SRPM URL: http://martinkg.fedorapeople.org/Review/SRPMS/otter-browser-0.9.01-4.beta1.fc20.src.rpm %changelog * Sun Jun 08 2014 Martin Gansser <martinkg> - 0.9.01-4.beta1 - changed release Tag
Note: this is an unofficial/preliminary review rpmlint: > otter-browser.src: W: invalid-url Source0: otter-0.9.01.tar.gz Should be a full url to the source Why are you not following http://fedoraproject.org/wiki/Packaging:Cmake ? More specifically, please use make %{?_smp_mflags} in %build.
@Benedikt thanks for your feedback. the download link for otter-0.9.01.tar.gz is: https://github.com/Emdek/otter/archive/v0.9.01.tar.gz but how can i use this as URL ?
Spec URL: http://martinkg.fedorapeople.org/Review/SPECS/otter-browser.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/otter-browser-0.9.02-1.beta2.fc20.src.rpm %changelog * Thu Aug 14 2014 Martin Gansser <martinkg> - 0.9.02-1.beta2 - rebuild for new release * Mon Jun 23 2014 Martin Gansser <martinkg> - 0.9.01-5.beta1 - changed %%cmake command following fedora packaging guide * Sun Jun 08 2014 Martin Gansser <martinkg> - 0.9.01-4.beta1 - changed release Tag
You can use this URL (https://github.com/Emdek/otter/archive/v0.9.02.tar.gz) directly. For Example: ... URL: http://otter-browser.org/ Source0: https://github.com/Emdek/otter/archive/v%{version}.tar.gz Source1: otter-browser.1 ...
And instead of make install DESTDIR=%{buildroot} use macros %make_install
when i download the tarball from thist URL (https://github.com/Emdek/otter/archive/v0.9.02.tar.gz) the downloaded file becomes the name otter-0.9.02.tar.gz and i get the message: error: File /home/martin/rpmbuild/SOURCES/v0.9.02.tar.gz: No such file or directory
How you download this file? If via wget then it must has v0.9.02.tar.gz name. What OS you use to download file?
ok, with wget it works.
Spec URL: https://www.dropbox.com/s/ycxcfrhrk1jxn75/otter-browser.spec Spec URL: https://www.dropbox.com/s/fsideaaxz8jdogs/otter-browser-0.9.02-1.fc20.src.rpm %changelog * Thu Aug 28 2014 Martin Gansser <martinkg> - 0.9.02-1 - Update to 0.9.02 - used macro make_install
Spec URL: https://www.dropbox.com/s/ycxcfrhrk1jxn75/otter-browser.spec?dl=0 pec URL: https://www.dropbox.com/s/kcuz2bcb3ivizb7/otter-browser-0.9.02-2.fc20.src.rpm?dl=0 %changelog * Thu Aug 28 2014 Martin Gansser <martinkg> - 0.9.02-2 - added own directory for otter-browser
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/otter-browser.spec SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/otter-browser-0.9.03-0.1.beta3gitc2c558a.fc20.src.rpm %changelog * Thu Oct 30 2014 Martin Gansser <martinkg> - 0.9.03-0.1.beta3gitc2c558a - use commit revision in source url - added macro %%find_lang
Looking well enough, taking it for a review: * Named correctly * Version correct * License good for Fedora * License text present - License tag might be incorrect (see below) * SPEC file clean and legible * RPMLint happy - Filelist contains an orphan (see below) - Requires might be missing a dependency (see below) * Provides fine * Builds fine in mock 0.) The "Url" tag seems wrong: Project's web site seems to be http://otter-browser.org/ 1.) "License" tag might be wrong: e.g. the header at ./src/core/SettingsManager.h suggest that it's GPLv3+? 2.) You install into %{_datadir}/icons/hicolor, but don't own it or depends on anything that would own it. Also, please consider adding AppData. While it's not strictly required yet, your application won't show up in the sotware center without it. See draft guidelines: https://fedoraproject.org/wiki/User:Rhughes/DraftAppDataGuidelines
(In reply to Lubomir Rintel from comment #15) > Looking well enough, taking it for a review: > > * Named correctly > * Version correct > * License good for Fedora > * License text present > - License tag might be incorrect (see below) > * SPEC file clean and legible > * RPMLint happy > - Filelist contains an orphan (see below) > - Requires might be missing a dependency (see below) > * Provides fine > * Builds fine in mock > > 0.) The "Url" tag seems wrong: > > Project's web site seems to be http://otter-browser.org/ done > > 1.) "License" tag might be wrong: > > e.g. the header at ./src/core/SettingsManager.h suggest that it's GPLv3+? > done > 2.) You install into %{_datadir}/icons/hicolor, but don't own it or depends > on anything that would own it. > removed, done. > Also, please consider adding AppData. While it's not strictly required yet, > your application won't show up in the sotware center without it. See draft > guidelines: > > https://fedoraproject.org/wiki/User:Rhughes/DraftAppDataGuidelines done Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/otter-browser.spec Spec URL: https://martinkg.fedorapeople.org/Review/SRPMS/otter-browser-0.9.04-0.1.beta4git0bbf467.fc20.src.rpm %changelog * Mon Dec 08 2014 Martin Gansser <martinkg> - 0.9.04-0.1.beta4git0bbf467 - Update to 0.9.04-0.1.beta4 - correct project's web site url - correct license tag - removed %%{_datadir}/icons/hicolor was not owned or used - added %%check section - added BR libappstream-glib - added appdata.xml file
Looks good to me now, thank you! APPROVED
@Lubomir many thanks for the review. New Package SCM Request ======================= Package Name: otter-browser Short Description: Browser aiming to recreate classic Opera (12.x) UI using Qt5. Owners: martinkg Branches: f20 f21 rawhide InitialCC:
Git done (by process-git-requests).
otter-browser-0.9.04-0.1.beta4git0bbf467.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/otter-browser-0.9.04-0.1.beta4git0bbf467.fc21
otter-browser-0.9.04-0.1.beta4git0bbf467.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/otter-browser-0.9.04-0.1.beta4git0bbf467.fc20
otter-browser has been built successfully on fc20, fc21 and rawhide.
otter-browser-0.9.04-0.2.beta4gitcdcf0c0.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/otter-browser-0.9.04-0.2.beta4gitcdcf0c0.fc20
otter-browser-0.9.04-0.2.beta4gitcdcf0c0.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/otter-browser-0.9.04-0.2.beta4gitcdcf0c0.fc21
otter-browser-0.9.04-0.2.beta4gitcdcf0c0.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.
otter-browser-0.9.04-0.2.beta4gitcdcf0c0.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.