Bug 1105720 - Live image Welcome screen uses an icon from gnome-icon-theme-legacy for "Try Fedora" but does not require it
Summary: Live image Welcome screen uses an icon from gnome-icon-theme-legacy for "Try ...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: anaconda
Version: rawhide
Hardware: All
OS: All
unspecified
medium
Target Milestone: ---
Assignee: Anaconda Maintenance Team
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-06-06 19:52 UTC by Adam Williamson
Modified: 2014-06-20 20:16 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-06-20 20:16:23 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
[PATCH] fedora-welcome: Correct an icon name after the switch to Adwaita (1.07 KB, text/plain)
2014-06-06 20:02 UTC, Kalev Lember
no flags Details

Description Adam Williamson 2014-06-06 19:52:23 UTC
The Workstation live image Welcome screen (data/liveinst/gnome/fedora-welcome , in the anaconda git tree) uses the 'media-cdrom' icon for the 'Try Fedora' button:

      tryContent.add(new Gtk.Image({ icon_name: 'media-cdrom',
                                     pixel_size: 256 }));
      tryContent.add(makeLabel(_("Try Fedora"), true));

that icon is part of gnome-icon-theme-legacy:

[adamw@adam spin-kickstarts (f20 %)]$ rpm -qf /usr/share/icons/gnome/256x256/devices/media-cdrom.png
gnome-icon-theme-legacy-3.12.0-1.fc21.noarch

In Fedora 20, gnome-icon-theme-legacy is on the live image, I believe because Rhythmbox required it. However, in current Rawhide, gnome-icon-theme-legacy is no longer pulled into the live images by anything, so the Welcome screen is entirely missing an icon for the "Try Fedora" button.

Either anaconda-core should Requires: gnome-icon-theme-legacy , or we should use an icon from one of the icon themes that is still installed - one from gnome-icon-theme would be safest, also installed at present are gnome-icon-theme-symbolic , gnome-icon-theme-extras , and adwaita-icon-theme .

Comment 1 Adam Williamson 2014-06-06 19:58:30 UTC
media-cdrom is actually simply a symlink to media-optical , which is part of gnome-icon-theme . so s/media-cdrom/media-optical/ would be the simplest fix. but I think gnome-icon-theme is supposed to go away in favour of adwaita-icon-theme at some point. adwaita-icon-theme has a symbolic version of media-optical (media-optical-symbolic), but not a 'regular' version at present.

Comment 2 Kalev Lember 2014-06-06 20:02:32 UTC
Created attachment 903023 [details]
[PATCH] fedora-welcome: Correct an icon name after the switch to Adwaita

Comment 3 Chris Lumens 2014-06-09 20:29:47 UTC
Thanks for the patch.  Pushed.

Comment 4 Adam Williamson 2014-06-20 20:16:23 UTC
I believe this is now resolved, last live image I built had the icon back.


Note You need to log in before you can comment on or make changes to this bug.