Bug 110596 - SiteBanner should be updated to use WebConfig, site-banner.xsl should likewise be fixed
Summary: SiteBanner should be updated to use WebConfig, site-banner.xsl should likewis...
Alias: None
Product: Red Hat Web Application Framework
Classification: Retired
Component: other (Show other bugs)
(Show other bugs)
Version: nightly
Hardware: All Linux
Target Milestone: ---
Assignee: ccm-bugs-list
QA Contact: Jon Orris
Depends On:
TreeView+ depends on / blocked
Reported: 2003-11-21 16:34 UTC by Vadim Nasardinov
Modified: 2007-04-18 16:59 UTC (History)
0 users

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2005-08-03 18:37:27 UTC
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

Description Vadim Nasardinov 2003-11-21 16:34:59 UTC
At the bottom of "/ccm/pvt/" there is the following note:

   If you encounter any problems using example.com:9000,
   please contact the site administrator. 

where "example.com:9000" is linked to "http://example.com"
with no port number.  The port number is lost because,
site-banner.xsl derives the URL from the "hostname" attribute
of the following element:
    <ui:siteBanner admin="" hostname="example.com" 
     metadata.tag="bottom" sitename="example.com:9000"/>

The attribute is produced by SiteBanner.java which relies
on the deprecated class KernelHelper.java.  SiteBanner.java
should be updated to make use of WebConfig.java, and site-banner.xsl
should generated the correct URL.

Comment 1 Daniel Berrange 2003-11-21 16:46:25 UTC
In p4 37829, Justin made KernelHelper delegates to WebConfig. It looks
like there is a small change in the semantics of
KernelHelper#getHostName. Previously we always configured
kernel.Initializaer#hostname to include the port number, by the
delegation from KernelHelper only has the hostname. 

As for 'sitename' attribute, this is controlled by waf.web.site_name
config param, which is setup to default to whatever
WebConfig#getServer().toString() returns. What is should contain is
the human friendly sitename, eg 'Red Hat CCM Demo' or whatever.

To be honest its probably time we removed KernelHelper altogether
since its been deprecated since 5.l core IIRC.

Comment 2 Vadim Nasardinov 2005-08-03 18:37:27 UTC

Note You need to log in before you can comment on or make changes to this bug.