Spec URL: http://mtasaka.fedorapeople.org/Review_request/gem-related/rubygem-minitest4.spec SRPM URL: http://mtasaka.fedorapeople.org/Review_request/gem-related/rubygem-minitest4-4.7.0-3.fc.src.rpm Description: minitest/unit is a small and fast replacement for ruby's huge and slow test/unit. This is meant to be clean and easy to use both as a regular test writer and for language implementors that need a minimal set of methods to bootstrap a working unit test suite. miniunit/spec is a functionally complete spec engine. miniunit/mock, by Steven Baker, is a beautifully tiny mock object framework. This is a compatibitity package for minitest version 4.x.y. Fedora Account System Username: mtasaka
Note that we currently have LOTS of ruby releated build failure, guessing many related with minitest... https://lists.fedoraproject.org/pipermail/devel/2014-June/199662.html
Taking. By the way, I have some experience porting gems' test suites to Minitest 5, so if anyone wants assistence in fixing his/her gem build failures due to Minitest 5, please contact me. I'm sure Mamoru would agree with me that this minitest4 package is just going to be a temporary solution to keep Fedora 21 stable.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - This package conflicts with rubygem-minitest-4.7.0-2.fc20, so we should add "Conflicts: rubygem-minitest = 4.7.0" to be on the safe side. - There is a rpmlint error about useless-provides for rubygem(minitest). Can we remove that line? I thought rubygems-devel contained an RPM macro to add that particular Provides automatically for %{gem_name}? - There is an rpmlint warning about mixed-use-of-spaces-and-tabs "(spaces: line 53, tab: line 1)" - There is an rpmlint warning about "bogus date in %changelog: Sun Jan 21 2012 Mamoru Tasaka <mtasaka> - 2.10.1-1" which we might as well fix here. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [!]: Package does not generate any conflict. See above about conflicting with rubygem-minitest-4.7.0-2.fc20 [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [-]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Ruby: [x]: Platform dependent files must all go under %{gem_extdir_mri}, platform independent under %{gem_dir}. [x]: Gem package must not define a non-gem subpackage [x]: Macro %{gem_extdir} is deprecated. [x]: Gem package is named rubygem-%{gem_name} [x]: Package contains BuildRequires: rubygems-devel. [x]: Gem package must define %{gem_name} macro. [x]: Pure Ruby package must be built as noarch [x]: Package does not contain Requires: ruby(abi). ===== SHOULD items ===== Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Avoid bundling fonts in non-fonts packages. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. Note: license is present in README.txt [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [-]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. Ruby: [x]: Specfile should use macros from rubygem-devel package. [x]: Gem package should exclude cached Gem. [x]: Gem should use %gem_install macro. [x]: Test suite should not be run by rake. [x]: Test suite of the library should be run. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rubygem-minitest4-4.7.0-3.fc21.noarch.rpm rubygem-minitest4-doc-4.7.0-3.fc21.noarch.rpm rubygem-minitest4-4.7.0-3.fc21.src.rpm rubygem-minitest4.noarch: W: spelling-error %description -l en_US implementors -> implements, implement, tormentors rubygem-minitest4.noarch: W: spelling-error %description -l en_US miniunit -> mini unit, mini-unit, Minuit rubygem-minitest4.noarch: W: spelling-error %description -l en_US compatibitity -> compatibility, compatibly, comparability rubygem-minitest4.noarch: E: useless-provides rubygem(minitest) rubygem-minitest4.src: W: spelling-error %description -l en_US minitest -> mintiest, minutest, mini test rubygem-minitest4.src: W: spelling-error %description -l en_US implementors -> implements, implement, tormentors rubygem-minitest4.src: W: spelling-error %description -l en_US miniunit -> mini unit, mini-unit, Minuit rubygem-minitest4.src: W: spelling-error %description -l en_US compatibitity -> compatibility, compatibly, comparability rubygem-minitest4.src:53: W: mixed-use-of-spaces-and-tabs (spaces: line 53, tab: line 1) rubygem-minitest4.src: E: specfile-error warning: bogus date in %changelog: Sun Jan 21 2012 Mamoru Tasaka <mtasaka> - 2.10.1-1 3 packages and 0 specfiles checked; 2 errors, 8 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint rubygem-minitest4 rubygem-minitest4-doc rubygem-minitest4.noarch: W: spelling-error %description -l en_US implementors -> implements, implement, tormentors rubygem-minitest4.noarch: W: spelling-error %description -l en_US miniunit -> mini unit, mini-unit, Minuit rubygem-minitest4.noarch: W: spelling-error %description -l en_US compatibitity -> compatibility, compatibly, comparability rubygem-minitest4.noarch: E: useless-provides rubygem(minitest) 2 packages and 0 specfiles checked; 1 errors, 3 warnings. Requires -------- rubygem-minitest4 (rpmlib, GLIBC filtered): ruby(rubygems) rubygem-minitest4-doc (rpmlib, GLIBC filtered): rubygem-minitest4 Provides -------- rubygem-minitest4: rubygem(minitest) rubygem(minitest4) rubygem-minitest4 rubygem-minitest4-doc: rubygem-minitest4-doc Source checksums ---------------- https://rubygems.org/gems/minitest-4.7.0.gem : CHECKSUM(SHA256) this package : b25ea9dceea6de921331ae7ca74158e9878ef5acce05ff3bc3ae1d293f02ccc0 CHECKSUM(SHA256) upstream package : b25ea9dceea6de921331ae7ca74158e9878ef5acce05ff3bc3ae1d293f02ccc0 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1106324 -m fedora-rawhide-x86_64 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Ruby, Shell-api Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
Thank you for initial comments! (In reply to Ken Dreyer from comment #3) > - This package conflicts with rubygem-minitest-4.7.0-2.fc20, so we should > add "Conflicts: rubygem-minitest = 4.7.0" to be on the safe side. > > - There is a rpmlint error about useless-provides for rubygem(minitest). Can > we remove that line? I thought rubygems-devel contained an RPM macro to add > that particular Provides automatically for %{gem_name}? > > - There is an rpmlint warning about mixed-use-of-spaces-and-tabs "(spaces: > line 53, tab: line 1)" > > - There is an rpmlint warning about "bogus date in %changelog: Sun Jan 21 > 2012 Mamoru Tasaka <mtasaka> - 2.10.1-1" which we might as > well fix here. > The below should fix these. http://mtasaka.fedorapeople.org/Review_request/gem-related/rubygem-minitest4-4.7.0-4.fc.src.rpm http://mtasaka.fedorapeople.org/Review_request/gem-related/rubygem-minitest4.spec * Mon Jun 9 2014 Mamoru TASAKA <mtasaka> - 4.7.0-4 - rpmlint fix - Filter out redundant Provides - Add Conflicts for older rubygem-minitest
LGTM. Approved.
Thank you New Package SCM Request ======================= Package Name: rubygem-minitest4 Short Description: Small and fast replacement for ruby's huge and slow test/unit Upstream URL: https://github.com/seattlerb/minitest Owners: mtasaka Branches: InitialCC:
Git done (by process-git-requests).
Oh, this is already imported, closing. Thank you for review.