Bug 1106381 - beah-srv fails to register dependency for beah-beaker-backend/beah-fwd-backend in systemd
Summary: beah-srv fails to register dependency for beah-beaker-backend/beah-fwd-backen...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Beaker
Classification: Retired
Component: beah
Version: 0.16
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: 0.17.1
Assignee: Dan Callaghan
QA Contact: tools-bugs
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-06-09 08:30 UTC by Jun'ichi NOMURA
Modified: 2018-02-06 00:41 UTC (History)
9 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-06-17 00:13:58 UTC
Embargoed:


Attachments (Terms of Use)

Description Jun'ichi NOMURA 2014-06-09 08:30:01 UTC
Description of the problem:
beah-srv requires beah-beaker-backend and beah-fwd-backend for backend processing. However, a typo in dependency description prevents the correct recognition of the dependency by systemd. As a result, error messages are logged to journal.

Version-Release number of selected component (if applicable):
systemd-208-11.el7.x86_64
beah-0.7.3-1.el7eng.noarch

How reproducible:
Always

Steps to Reproduce:
1. Run a recipe in beaker
2. Check the output of "journalctl -xb"

Actual behavior:
# journalctl -xb -p 0..5 | grep beah-srv
Jun 09 00:03:44 myhost systemd[1]: [/usr/lib/systemd/system/beah-srv.service:4] Failed to add dependency on beah-beaker-backend, ignoring: Invalid argument
Jun 09 00:03:44 myhost systemd[1]: [/usr/lib/systemd/system/beah-srv.service:4] Failed to add dependency on beah-fwd-backend, ignoring: Invalid argument
# systemctl show beah-srv | grep Requires
Requires=basic.target

Expected behavior:
# journalctl -xb -p 0..5 | grep beah-srv
# systemctl show beah-srv | grep Requires
Requires=beah-beaker-backend.service beah-fwd-backend.service basic.target


Additional Information:

With the following change, the problem goes away:

--- /usr/lib/systemd/system/beah-srv.service.orig	2014-06-08 23:21:01.209353821 -0400
+++ /usr/lib/systemd/system/beah-srv.service	2014-06-09 00:06:31.009702608 -0400
@@ -1,7 +1,7 @@
 [Unit]
 Description=The Beaker Harness server.
 After=network.target NetworkManager-wait-online.service time-sync.target
-Requires=beah-beaker-backend beah-fwd-backend
+Requires=beah-beaker-backend.service beah-fwd-backend.service
 
 [Service]
 Type=simple

Comment 2 Dan Callaghan 2014-06-10 06:27:05 UTC
Thanks for the report!

On Gerrit: http://gerrit.beaker-project.org/3133

Comment 5 Amit Saha 2014-06-17 00:13:58 UTC
Beah 0.7.5 has been released on beaker-project.org.

Comment 6 Marian Csontos 2014-08-01 15:59:05 UTC
I think `Wants=` would be more appropriate option allowing one to restart the backends.

Comment 7 Dan Callaghan 2014-08-08 01:33:17 UTC
(In reply to Marian Csontos from comment #6)

Thanks for the tip Marian. You're right, I think Wants= would be better.

http://gerrit.beaker-project.org/3237


Note You need to log in before you can comment on or make changes to this bug.