Bug 110655 - param.h should include <unistd.h>
Summary: param.h should include <unistd.h>
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: glibc-kernheaders
Version: 1
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Arjan van de Ven
QA Contact: Brian Brock
URL:
Whiteboard:
Keywords:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2003-11-22 10:31 UTC by Ling Li
Modified: 2007-11-30 22:10 UTC (History)
0 users

(edit)
Clone Of:
(edit)
Last Closed: 2004-04-27 21:18:05 UTC


Attachments (Terms of Use)

Description Ling Li 2003-11-22 10:31:21 UTC
Description of problem:
/usr/include/asm/param.h (included in glibc-kernheaders-2.4-8.36)
defines HZ as sysconf(_SC_CLK_TCK) but doesn't include unistd.h, where
the _SC_CLK_TCK is defined. This at least breaks the compilation of
graphviz 1.10.

To Fix: apply this patch

@@ -2,6 +2,7 @@
 #define _ASMi386_PARAM_H

 #ifndef HZ
+#include <unistd.h>
 #define HZ sysconf(_SC_CLK_TCK)
 #endif


Version-Release number of selected component (if applicable):
glibc-kernheaders-2.4-8.36

How reproducible:



Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Greg Schafer 2003-12-11 05:01:24 UTC
I'd like to make the observation that this change (now appearing in
glibc-kernheaders-2.4-8.41) breaks the compilation of inetutils-1.4.2
from ftp.gnu.org

revoke.c:15: error: conflicting types for `revoke'
/usr/include/unistd.h:810: error: previous declaration of `revoke'
make[2]: *** [revoke.o] Error 1

This would suggest that the change may be bogus. Or it may just mean
the inetutils package is broken.

Comment 2 Arjan van de Ven 2003-12-11 07:33:56 UTC
inetutils is broken I suspect; after all why include a private kernel
header if you can't deal with a posix namespace...

Comment 3 Greg Schafer 2003-12-11 12:01:09 UTC
Yep, I've looked into it a bit deeper. Your suspicions are correct.
This header change just exposed a latent bug in inetutils methinks.
Every other package I've compiled so far has been fine. Sorry for
wasting your time.

Comment 4 Ling Li 2004-04-27 21:18:05 UTC
This issue has been fixed in glibc-kernheaders from at least release
2.4-8.41.




Note You need to log in before you can comment on or make changes to this bug.