Bug 1106803 - iperf3: FTBFS in rawhide
Summary: iperf3: FTBFS in rawhide
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: iperf3
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Susant Sahani
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F21FTBFS
TreeView+ depends on / blocked
 
Reported: 2014-06-09 17:31 UTC by Dennis Gilmore
Modified: 2014-06-27 04:47 UTC (History)
5 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-06-27 04:47:35 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
build.log (26.75 KB, text/plain)
2014-06-09 17:31 UTC, Dennis Gilmore
no flags Details
root.log (73.55 KB, text/plain)
2014-06-09 17:31 UTC, Dennis Gilmore
no flags Details
state.log (1.06 KB, text/plain)
2014-06-09 17:31 UTC, Dennis Gilmore
no flags Details
fix compilation (625 bytes, patch)
2014-06-09 18:13 UTC, Susant Sahani
no flags Details | Diff

Description Dennis Gilmore 2014-06-09 17:31:46 UTC
Your package iperf3 failed to build from source in current rawhide.

http://koji.fedoraproject.org/koji/taskinfo?taskID=6987939

For details on mass rebuild see https://fedoraproject.org/wiki/Fedora_21_Mass_Rebuild

Comment 1 Dennis Gilmore 2014-06-09 17:31:48 UTC
Created attachment 905344 [details]
build.log

Comment 2 Dennis Gilmore 2014-06-09 17:31:50 UTC
Created attachment 905345 [details]
root.log

Comment 3 Dennis Gilmore 2014-06-09 17:31:52 UTC
Created attachment 905346 [details]
state.log

Comment 4 Susant Sahani 2014-06-09 18:12:08 UTC
In function 'open',
    inlined from 'iperf_new_stream' at iperf_api.c:2218:20:
/usr/include/bits/fcntl2.h:50:4: error: call to '__open_missing_mode' declared with attribute error: open with O_CREAT in second argument needs 3 arguments
    __open_missing_mode ();

 this is failing because of open function has 2 arguments and it is missing the third argument. open with O_CREAT must have 3 arguments rather than 2
http://www.opengroup.org/onlinepubs/009695399/functions/open.html


This patch should fix it.


diff -rupN iperf-3.0.3/src/iperf_api.c  iperf-3.0.3.patch/src/iperf_api.c
--- iperf-3.0.3/src/iperf_api.c	2014-03-26 23:36:38.000000000 +0530
+++ iperf-3.0.3.patch/src/iperf_api.c	2014-06-09 23:31:46.183346802 +0530
@@ -2215,7 +2215,7 @@ iperf_new_stream(struct iperf_test *test
     sp->rcv = test->protocol->recv;
 
     if (test->diskfile_name != (char*) 0) {
-	sp->diskfile_fd = open(test->diskfile_name, test->sender ? O_RDONLY : (O_WRONLY|O_CREAT|O_TRUNC));
+	sp->diskfile_fd = open(test->diskfile_name, test->sender ? O_RDONLY : (O_WRONLY|O_CREAT|O_TRUNC), S_IRUSR|S_IWUSR);
 	if (sp->diskfile_fd == -1) {
 	    i_errno = IEFILE;
             munmap(sp->buffer, sp->test->settings->blksize);

Comment 5 Susant Sahani 2014-06-09 18:13:32 UTC
Created attachment 905607 [details]
fix compilation

Comment 6 Susant Sahani 2014-06-10 03:00:43 UTC
The fix has been approved on upstream. I will back port it and push the changes.

https://github.com/esnet/iperf/commit/c5e1205e4906173d74574e30b4ea1c0e182883de

Comment 7 Susant Sahani 2014-06-11 05:09:26 UTC
I have committed the changes. please verify if the issue still persists.

http://pkgs.fedoraproject.org/cgit/iperf3.git/commit/?id=c0885cc1cba5c07f2006df17439fa04ee7f2ea49

Comment 8 Susant Sahani 2014-06-11 05:10:54 UTC
Build log can be found here http://koji.fedoraproject.org/koji/taskinfo?taskID=7034506

Comment 9 Susant Sahani 2014-06-27 04:47:35 UTC
Closing this bug as changes made to git.


Note You need to log in before you can comment on or make changes to this bug.