Bug 1107029 - ultimaker2-marlin-firmware: FTBFS in rawhide
Summary: ultimaker2-marlin-firmware: FTBFS in rawhide
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: ultimaker2-marlin-firmware
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Miro Hrončok
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: F21FTBFS
TreeView+ depends on / blocked
 
Reported: 2014-06-09 19:08 UTC by Dennis Gilmore
Modified: 2014-06-24 08:56 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-06-24 08:56:21 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
build.log (5.53 KB, text/plain)
2014-06-09 19:08 UTC, Dennis Gilmore
no flags Details
root.log (82.09 KB, text/plain)
2014-06-09 19:08 UTC, Dennis Gilmore
no flags Details
state.log (1.15 KB, text/plain)
2014-06-09 19:08 UTC, Dennis Gilmore
no flags Details

Description Dennis Gilmore 2014-06-09 19:08:28 UTC
Your package ultimaker2-marlin-firmware failed to build from source in current rawhide.

http://koji.fedoraproject.org/koji/taskinfo?taskID=6997543

For details on mass rebuild see https://fedoraproject.org/wiki/Fedora_21_Mass_Rebuild

Comment 1 Dennis Gilmore 2014-06-09 19:08:32 UTC
Created attachment 905882 [details]
build.log

Comment 2 Dennis Gilmore 2014-06-09 19:08:34 UTC
Created attachment 905883 [details]
root.log

Comment 3 Dennis Gilmore 2014-06-09 19:08:36 UTC
Created attachment 905884 [details]
state.log

Comment 4 Yaakov Selkowitz 2014-06-19 02:20:05 UTC
Missing #include <LiquidCrystal_I2C.h> triggered by LCD_I2C_TYPE_PCF8575 define.

Comment 5 Miro Hrončok 2014-06-24 08:13:51 UTC
Looking at https://github.com/kiyoshigawa/LiquidCrystal_I2C and I cannot see any license.

Also, I don't get it, why this was built fine before (it shouldn't).

Comment 6 Miro Hrončok 2014-06-24 08:20:33 UTC
And I cannot see, where LCD_I2C_TYPE_PCF8575 is defined:

$ grep -r LCD_I2C_TYPE_PCF8575
Configuration.h:  #define LCD_I2C_TYPE_PCF8575
ultralcd_implementation_hitachi_HD44780.h:#if defined(LCD_I2C_TYPE_PCF8575)
Marlin.pde:  #if defined(LCD_I2C_TYPE_PCF8575)

The part:

//#define LCD_I2C_SAINSMART_YWROBOT
#ifdef LCD_I2C_SAINSMART_YWROBOT
  // This uses the LiquidCrystal_I2C library ( https://bitbucket.org/fmalpartida/new-liquidcrystal/wiki/Home )
  // Make sure it is placed in the Arduino libraries directory.
  #define LCD_I2C_TYPE_PCF8575
  #define LCD_I2C_ADDRESS 0x27   // I2C Address of the port expander
  #define NEWPANEL
  #define ULTIPANEL
#endif

$ grep -r LCD_I2C_SAINSMART_YWROBOT
Configuration.h://#define LCD_I2C_SAINSMART_YWROBOT
Configuration.h:#ifdef LCD_I2C_SAINSMART_YWROBOT

From my perspective, this should never be included at all.

Comment 7 Miro Hrončok 2014-06-24 08:36:47 UTC
Oh, so this is taken from Marlin.pde and is evaluated even when the condition is not met. Will patch it away, but this is probably a problem in ino or arduino-core :(


Note You need to log in before you can comment on or make changes to this bug.