Spec URL: http://jjames.fedorapeople.org/python-zodbpickle/python-zodbpickle.spec SRPM URL: http://jjames.fedorapeople.org/python-zodbpickle/python-zodbpickle-0.5.2-1.fc21.src.rpm Fedora Account System Username: jjames Description: This package presents a uniform pickling interface for ZODB: - Under Python2, this package forks both Python 2.7's pickle and cPickle modules, adding support for the protocol 3 opcodes. It also provides a new subclass of bytes, zodbpickle.binary, which Python2 applications can use to pickle binary values such that they will be unpickled as bytes under Py3k. - Under Py3k, this package forks the pickle module (and the supporting C extension) from Python 3.2, Python 3.3, and Python 3.4. The fork adds support for the noload operations used by ZODB.
I will review this at the earliest tomorrow evening. If someone wants to take, feel free to assign the bug to yourself.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 48 files have unknown license. Detailed output of licensecheck in /home/mukundan/personal/pkgs/reviews/1107321-python- zodbpickle/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. Note: rm -rf %{buildroot} present but not required [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-zodbpickle [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-zodbpickle-0.5.2-1.fc22.x86_64.rpm python3-zodbpickle-0.5.2-1.fc22.x86_64.rpm python-zodbpickle-0.5.2-1.fc22.src.rpm python-zodbpickle.x86_64: W: spelling-error %description -l en_US cPickle -> c Pickle, pickle, prickle python-zodbpickle.x86_64: W: spelling-error %description -l en_US opcodes -> op codes, op-codes, codes python-zodbpickle.x86_64: W: spelling-error %description -l en_US unpickled -> unpicked, unpick led, unpick-led python-zodbpickle.x86_64: W: spelling-error %description -l en_US noload -> no load, no-load, load python3-zodbpickle.x86_64: W: spelling-error %description -l en_US cPickle -> c Pickle, pickle, prickle python3-zodbpickle.x86_64: W: spelling-error %description -l en_US opcodes -> op codes, op-codes, codes python3-zodbpickle.x86_64: W: spelling-error %description -l en_US unpickled -> unpicked, unpick led, unpick-led python3-zodbpickle.x86_64: W: spelling-error %description -l en_US noload -> no load, no-load, load python-zodbpickle.src: W: spelling-error %description -l en_US cPickle -> c Pickle, pickle, prickle python-zodbpickle.src: W: spelling-error %description -l en_US opcodes -> op codes, op-codes, codes python-zodbpickle.src: W: spelling-error %description -l en_US unpickled -> unpicked, unpick led, unpick-led python-zodbpickle.src: W: spelling-error %description -l en_US noload -> no load, no-load, load 3 packages and 0 specfiles checked; 0 errors, 12 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint python3-zodbpickle python-zodbpickle python3-zodbpickle.x86_64: W: spelling-error %description -l en_US cPickle -> c Pickle, pickle, prickle python3-zodbpickle.x86_64: W: spelling-error %description -l en_US opcodes -> op codes, op-codes, codes python3-zodbpickle.x86_64: W: spelling-error %description -l en_US unpickled -> unpicked, unpick led, unpick-led python3-zodbpickle.x86_64: W: spelling-error %description -l en_US noload -> no load, no-load, load python-zodbpickle.x86_64: W: spelling-error %description -l en_US cPickle -> c Pickle, pickle, prickle python-zodbpickle.x86_64: W: spelling-error %description -l en_US opcodes -> op codes, op-codes, codes python-zodbpickle.x86_64: W: spelling-error %description -l en_US unpickled -> unpicked, unpick led, unpick-led python-zodbpickle.x86_64: W: spelling-error %description -l en_US noload -> no load, no-load, load 2 packages and 0 specfiles checked; 0 errors, 8 warnings. # echo 'rpmlint-done:' Requires -------- python3-zodbpickle (rpmlib, GLIBC filtered): libc.so.6()(64bit) libpthread.so.0()(64bit) libpython3.4m.so.1.0()(64bit) python(abi) rtld(GNU_HASH) python-zodbpickle (rpmlib, GLIBC filtered): libc.so.6()(64bit) libpthread.so.0()(64bit) libpython2.7.so.1.0()(64bit) python(abi) rtld(GNU_HASH) Provides -------- python3-zodbpickle: python3-zodbpickle python3-zodbpickle(x86-64) python-zodbpickle: python-zodbpickle python-zodbpickle(x86-64) Unversioned so-files -------------------- python-zodbpickle: /usr/lib64/python2.7/site-packages/zodbpickle/_pickle.so python3-zodbpickle: /usr/lib64/python3.4/site-packages/zodbpickle/_pickle.cpython-34m.so Source checksums ---------------- https://pypi.python.org/packages/source/z/zodbpickle/zodbpickle-0.5.2.tar.gz : CHECKSUM(SHA256) this package : f65c00fbc13523fced63de6cc11747aa1a6343aeb2895c89838ed55a5ab12cca CHECKSUM(SHA256) upstream package : f65c00fbc13523fced63de6cc11747aa1a6343aeb2895c89838ed55a5ab12cca Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1107321 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api, C/C++ Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
scratch build here - http://koji.fedoraproject.org/koji/taskinfo?taskID=7234865 No issues here. Package approved.
New Package SCM Request ======================= Package Name: python-zodbpickle Short Description: Fork of Python 2 pickle module for ZODB Upstream URL: https://pypi.python.org/pypi/zodbpickle Owners: jjames Branches: f21 InitialCC:
Git done (by process-git-requests).
This package has been built for Rawhide and F21.