Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1107549

Summary: ovirt-node-upgrade:Using "--skip-existing-hooks" option to skip old image hooks scripts to run failed
Product: [Retired] oVirt Reporter: haiyang,dong <hadong>
Component: ovirt-nodeAssignee: Fabian Deutsch <fdeutsch>
Status: CLOSED CURRENTRELEASE QA Contact: bugs <bugs>
Severity: medium Docs Contact:
Priority: medium    
Version: unspecifiedCC: cshao, gklein, gouyang, hadong, huiwa, jboggs, leiwang, mgoldboi, ovirt-bugs, rbalakri, ycui, yeylon
Target Milestone: ---   
Target Release: 3.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: node
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-10-17 12:29:12 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Node RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description haiyang,dong 2014-06-10 07:43:11 UTC 
Description of problem:
Using "--skip-existing-hooks" option to skip old image hooks scripts to run failed 
for ovirt-node-upgrade tools.
This is due to the value of _options.skip_existing_hooks always "False" whether
add --skip-existing-hooks option or not when using ovirt-node-upgrade.

Version-Release number of selected component (if applicable):
In the master branch of ovirt-node upstream
Miss to unmount_config "/etc/profile" before edit it
Change-Id: I479be705f991f7d2542a944d0491e9ac252dc410

How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 1 haiyang,dong 2014-06-10 07:46:39 UTC 
Primary the value of _options.skip_existing_hooks always "False" whether
add --skip-existing-hooks option or not when using ovirt-node-upgrade.
Now fix it as the value of _options.skip_existing_hooks was "True" when
add --skip-existing-hooks option. If not add it, the default value was
"False"
http://gerrit.ovirt.org/#/c/28542/
Comment 2 Sandro Bonazzola 2014-10-17 12:29:12 UTC 
oVirt 3.5 has been released and should include the fix for this issue.