Bug 110760 - bad source code
Summary: bad source code
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: hdparm
Version: 1
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Karsten Hopp
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2003-11-24 14:57 UTC by d.binderman
Modified: 2007-11-30 22:10 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2003-11-24 16:26:02 UTC
Type: ---
Embargoed:

Attachments (Terms of Use)

Description d.binderman 2003-11-24 14:57:59 UTC 
From Bugzilla Helper:
User-Agent: Mozilla/4.0 (compatible; MSIE 6.0; Windows 98)

Description of problem:

I just tried to compile package hdparm-5_4-3 from Fedora.

The compiler said

hdparm.c(1241): warning #187: use of "=" where "==" may have been 
intended

The source code is

                 && (args[0] = WIN_CHECKPOWERMODE2) /* try again with 
0x98 */

Might be better with

                 && (args[0] == WIN_CHECKPOWERMODE2) /* try again 
with 0x98 */


Version-Release number of selected component (if applicable):
hdparm-5_4-3 

How reproducible:
Always

Steps to Reproduce:
1. by inspection
2.
3.
    

Additional info:
Comment 1 Karsten Hopp 2003-11-24 16:26:02 UTC 
Thats's ugly code, but one single '=' is intended here to try 
the ioctl again with different parameters.
Comment 2 d.binderman 2003-11-26 10:00:25 UTC 
>Thats's ugly code

Agreed. Not good software engineering either.

Any interest in tidying it up ?

&& ((args[0] = WIN_CHECKPOWERMODE2) != 0)
Note You need to log in before you can comment on or make changes to this bug.