1107612 – 'resource delete' behaviour confusing for clone of group with more than one resource

RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.

Bug 1107612 - 'resource delete' behaviour confusing for clone of group with more than one resource

Summary: 'resource delete' behaviour confusing for clone of group with more than one r...

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	Red Hat Enterprise Linux 6
Classification:	Red Hat
Component:	pcs
Sub Component:
Version:	6.6
Hardware:	Unspecified
OS:	Unspecified
Priority:	medium
Severity:	medium
Target Milestone:	pre-dev-freeze
Target Release:	6.6
Assignee:	Tomas Jelinek
QA Contact:	Cluster QE
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+	depends on / blocked

Reported:	2014-06-10 11:03 UTC by michal novacek
Modified:	2014-10-14 07:22 UTC (History)
CC List:	5 users (show)
Fixed In Version:	pcs-0.9.123-4.el6
Doc Type:	Bug Fix
Doc Text:	Previously, the pcs utility did not properly handle clones of a group when removing resources from the cloned group. As a consequence, the "pcs resource unclone" and "pcs resource delete" commands removed only the first resource in a group when they were supposed to remove the entire resource group. With this update, pcs handles resources in cloned groups correctly and removing cloned resource groups works as expected.
Clone Of:
Environment:
Last Closed:	2014-10-14 07:22:11 UTC
Target Upstream Version:
Embargoed:

Attachments	(Terms of Use)
proposed fix 1/2 (12.91 KB, patch) 2014-06-17 14:10 UTC, Tomas Jelinek	no flags	Details \| Diff
proposed fix 2/2 (2.79 KB, patch) 2014-06-17 14:10 UTC, Tomas Jelinek	no flags	Details \| Diff
View All

Links
System	ID	Private	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHBA-2014:1526	0	normal	SHIPPED_LIVE	pcs bug fix and enhancement update	2014-10-14 01:22:04 UTC

Description michal novacek 2014-06-10 11:03:02 UTC

Description of problem: 
The behaviour of the 'pcs resource delete' is confusing for cloned group of several resources. Only first resource of the group is removed which is not correct. It should either remove all or none (and suggest other ways on how it should be done).

Version-Release number of selected component (if applicable):
resource-agents-3.9.5-26.el7.x86_64
pcs-0.9.115-32.el7.x86_64

How reproducible: always


Steps to Reproduce:
1. for a in 1 2 3; do pcs resource create dummy-$a Dummy --group dummies; done
2. pcs resource clone dummies
3. pcs resource delete dummies-clone

Actual results: only first resource in a cloned group removed

Expected results: clone, group and all of its resources removed

Additional info:
[root@virt-066 ~]# for a in 1 2 3; do pcs resource create dummy-$a Dummy --group dummies; done
[root@virt-066 ~]# pcs resource clone dummies
[root@virt-066 ~]# pcs resource show dummies-clone
 Clone: dummies-clone
  Group: dummies
   Resource: dummy-1 (class=ocf provider=heartbeat type=Dummy)
    Operations: start interval=0s timeout=20 (dummy-1-start-timeout-20)
                stop interval=0s timeout=20 (dummy-1-stop-timeout-20)
                monitor interval=10 timeout=20 (dummy-1-monitor-interval-10)
   Resource: dummy-2 (class=ocf provider=heartbeat type=Dummy)
    Operations: start interval=0s timeout=20 (dummy-2-start-timeout-20)
                stop interval=0s timeout=20 (dummy-2-stop-timeout-20)
                monitor interval=10 timeout=20 (dummy-2-monitor-interval-10)
   Resource: dummy-3 (class=ocf provider=heartbeat type=Dummy)
    Operations: start interval=0s timeout=20 (dummy-3-start-timeout-20)
                stop interval=0s timeout=20 (dummy-3-stop-timeout-20)
                monitor interval=10 timeout=20 (dummy-3-monitor-interval-10)
[root@virt-066 ~]# pcs resource delete dummies-clone
Attempting to stop: dummy-1...Stopped
Deleting Resource - dummy-1
[root@virt-066 ~]# pcs resource show dummies-clone
 Clone: dummies-clone
  Group: dummies
   Resource: dummy-2 (class=ocf provider=heartbeat type=Dummy)
    Operations: start interval=0s timeout=20 (dummy-2-start-timeout-20)
                stop interval=0s timeout=20 (dummy-2-stop-timeout-20)
                monitor interval=10 timeout=20 (dummy-2-monitor-interval-10)
   Resource: dummy-3 (class=ocf provider=heartbeat type=Dummy)
    Operations: start interval=0s timeout=20 (dummy-3-start-timeout-20)
                stop interval=0s timeout=20 (dummy-3-stop-timeout-20)
                monitor interval=10 timeout=20 (dummy-3-monitor-interval-10)
[root@virt-066 ~]# pcs resource delete dummies-clone
Attempting to stop: dummy-2...Stopped
Deleting Resource - dummy-2
[root@virt-066 ~]# pcs resource show dummies-clone
 Clone: dummies-clone
  Group: dummies
   Resource: dummy-3 (class=ocf provider=heartbeat type=Dummy)
    Operations: start interval=0s timeout=20 (dummy-3-start-timeout-20)
                stop interval=0s timeout=20 (dummy-3-stop-timeout-20)
                monitor interval=10 timeout=20 (dummy-3-monitor-interval-10)
[root@virt-066 ~]# pcs resource delete dummies-clone
Attempting to stop: dummy-3...Stopped
Deleting Resource (and group and clone) - dummy-3

Comment 2 Radek Steiger 2014-06-12 14:44:38 UTC

Same with Master/Slave resources:


[root@virt-021 sts6]# for a in 1 2 3; do pcs resource create dummy-$a Stateful --group dummies; done
[root@virt-021 sts6]# pcs resource master dummies
[root@virt-021 sts6]# pcs resource --full
 Master: dummies-master
  Group: dummies
   Resource: dummy-1 (class=ocf provider=pacemaker type=Stateful)
    Operations: start interval=0s timeout=20 (dummy-1-start-timeout-20)
                stop interval=0s timeout=20 (dummy-1-stop-timeout-20)
                monitor interval=10 role=Master timeout=20 (dummy-1-monitor-interval-10-role-Master)
                monitor interval=10 role=Slave timeout=20 (dummy-1-monitor-interval-10-role-Slave)
   Resource: dummy-2 (class=ocf provider=pacemaker type=Stateful)
    Operations: start interval=0s timeout=20 (dummy-2-start-timeout-20)
                stop interval=0s timeout=20 (dummy-2-stop-timeout-20)
                monitor interval=10 role=Master timeout=20 (dummy-2-monitor-interval-10-role-Master)
                monitor interval=10 role=Slave timeout=20 (dummy-2-monitor-interval-10-role-Slave)
   Resource: dummy-3 (class=ocf provider=pacemaker type=Stateful)
    Operations: start interval=0s timeout=20 (dummy-3-start-timeout-20)
                stop interval=0s timeout=20 (dummy-3-stop-timeout-20)
                monitor interval=10 role=Master timeout=20 (dummy-3-monitor-interval-10-role-Master)
                monitor interval=10 role=Slave timeout=20 (dummy-3-monitor-interval-10-role-Slave)
[root@virt-021 sts6]# 
[root@virt-021 sts6]# pcs resource delete dummies-master
Attempting to stop: dummy-1...Stopped
Deleting Resource - dummy-1
[root@virt-021 sts6]# pcs resource --full
 Master: dummies-master
  Group: dummies
   Resource: dummy-2 (class=ocf provider=pacemaker type=Stateful)
    Operations: start interval=0s timeout=20 (dummy-2-start-timeout-20)
                stop interval=0s timeout=20 (dummy-2-stop-timeout-20)
                monitor interval=10 role=Master timeout=20 (dummy-2-monitor-interval-10-role-Master)
                monitor interval=10 role=Slave timeout=20 (dummy-2-monitor-interval-10-role-Slave)
   Resource: dummy-3 (class=ocf provider=pacemaker type=Stateful)
    Operations: start interval=0s timeout=20 (dummy-3-start-timeout-20)
                stop interval=0s timeout=20 (dummy-3-stop-timeout-20)
                monitor interval=10 role=Master timeout=20 (dummy-3-monitor-interval-10-role-Master)
                monitor interval=10 role=Slave timeout=20 (dummy-3-monitor-interval-10-role-Slave)

Comment 4 Tomas Jelinek 2014-06-17 14:10:13 UTC

Created attachment 909604 [details]
proposed fix 1/2

Comment 5 Tomas Jelinek 2014-06-17 14:10:35 UTC

Created attachment 909605 [details]
proposed fix 2/2

Comment 7 Chris Feist 2014-07-03 22:30:59 UTC

Before Fix:

[root@bid-06 ~]# rpm -q pcs
pcs-0.9.123-3.el6.x86_64
[root@bid-06 ~]# pcs resource create D1 Dummy --group dg
[root@bid-06 ~]# pcs resource create D2 Dummy --group dg
[root@bid-06 ~]# pcs resource create D3 Dummy --group dg
[root@bid-06 ~]# pcs resource clone dg
[root@bid-06 ~]# pcs resource
 Clone Set: dg-clone [dg]
     Started: [ bid-05 bid-06 ]
[root@bid-06 ~]# pcs resource --full
 Clone: dg-clone
  Group: dg
   Resource: D1 (class=ocf provider=heartbeat type=Dummy)
    Operations: start interval=0s timeout=20 (D1-start-timeout-20)
                stop interval=0s timeout=20 (D1-stop-timeout-20)
                monitor interval=10 timeout=20 (D1-monitor-interval-10)
   Resource: D2 (class=ocf provider=heartbeat type=Dummy)
    Operations: start interval=0s timeout=20 (D2-start-timeout-20)
                stop interval=0s timeout=20 (D2-stop-timeout-20)
                monitor interval=10 timeout=20 (D2-monitor-interval-10)
   Resource: D3 (class=ocf provider=heartbeat type=Dummy)
    Operations: start interval=0s timeout=20 (D3-start-timeout-20)
                stop interval=0s timeout=20 (D3-stop-timeout-20)
                monitor interval=10 timeout=20 (D3-monitor-interval-10)
[root@bid-06 ~]# pcs resource delete dg-clone
Attempting to stop: D1...Stopped
Deleting Resource - D1
[root@bid-06 ~]# pcs resource --full
 Clone: dg-clone
  Group: dg
   Resource: D2 (class=ocf provider=heartbeat type=Dummy)
    Operations: start interval=0s timeout=20 (D2-start-timeout-20)
                stop interval=0s timeout=20 (D2-stop-timeout-20)
                monitor interval=10 timeout=20 (D2-monitor-interval-10)
   Resource: D3 (class=ocf provider=heartbeat type=Dummy)
    Operations: start interval=0s timeout=20 (D3-start-timeout-20)
                stop interval=0s timeout=20 (D3-stop-timeout-20)
                monitor interval=10 timeout=20 (D3-monitor-interval-10)


D2, D3 and dg should all have been deleted.

After Fix:
[root@bid-06 pcs]# rpm -q pcs
pcs-0.9.123-4.el6.x86_64
[root@bid-06 pcs]# pcs resource create D1 Dummy --group dg
[root@bid-06 pcs]# pcs resource create D2 Dummy --group dg
[root@bid-06 pcs]# pcs resource create D3 Dummy --group dg
[root@bid-06 pcs]# pcs resource clone dg
[root@bid-06 pcs]# pcs resource --full
 Clone: dg-clone
  Group: dg
   Resource: D1 (class=ocf provider=heartbeat type=Dummy)
    Operations: start interval=0s timeout=20 (D1-start-timeout-20)
                stop interval=0s timeout=20 (D1-stop-timeout-20)
                monitor interval=10 timeout=20 (D1-monitor-interval-10)
   Resource: D2 (class=ocf provider=heartbeat type=Dummy)
    Operations: start interval=0s timeout=20 (D2-start-timeout-20)
                stop interval=0s timeout=20 (D2-stop-timeout-20)
                monitor interval=10 timeout=20 (D2-monitor-interval-10)
   Resource: D3 (class=ocf provider=heartbeat type=Dummy)
    Operations: start interval=0s timeout=20 (D3-start-timeout-20)
                stop interval=0s timeout=20 (D3-stop-timeout-20)
                monitor interval=10 timeout=20 (D3-monitor-interval-10)
[root@bid-06 pcs]# pcs resource delete dg-clone
Removing group: dg (and all resources within group)
Stopping all resources in group: dg...
Deleting Resource - D1
Deleting Resource - D2
Deleting Resource (and group and clone) - D3
[root@bid-06 pcs]# pcs resource --full
[root@bid-06 pcs]#

Comment 10 errata-xmlrpc 2014-10-14 07:22:11 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2014-1526.html

Note You need to log in before you can comment on or make changes to this bug.