Bug 1108159 - [RFE][CodeChange] Refactor of Import VM/Template
Summary: [RFE][CodeChange] Refactor of Import VM/Template
Keywords:
Status: CLOSED WONTFIX
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: RFEs
Version: ---
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: ---
: ---
Assignee: Liron Aravot
QA Contact: Aharon Canan
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-06-11 13:25 UTC by Maor
Modified: 2022-06-30 13:01 UTC (History)
9 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2016-11-03 10:54:35 UTC
oVirt Team: Storage
Embargoed:
sbonazzo: ovirt-4.1-


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Issue Tracker RHV-46845 0 None None None 2022-06-30 13:01:34 UTC

Description Maor 2014-06-11 13:25:34 UTC
Description of problem:
Import VM should be refactored to be used more properly, so the maintenance of it should be much more easier.

Today the import process is being used for the following processes:
1) Import VM/Template
2) Import Vm/Template from configuration
3) Register VM/Tempalte from OVF

All those processes has common logic which is being shared through MoveOrCopyTemplateCommand, which is a command which is deprecated.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:
Tests for every operation mentioned above should be written, following a re-factor of small methods to be shared through all the processes.


Additional info:

Comment 1 Itamar Heim 2015-03-29 09:05:27 UTC
Closing old bugs. If this issue is still relevant/important in current version, please re-open the bug.

Comment 2 Allon Mureinik 2015-03-29 10:53:06 UTC
It's a CodeChange bug we'd probably want to handle sooner or later. Reopening so it can be tracked.

Comment 5 Allon Mureinik 2016-01-20 17:32:13 UTC
Daniel, let's kick this one out of the park while 4.0 is still fresh and new?

Comment 6 Allon Mureinik 2016-01-28 09:26:24 UTC
Actually, let's see if we can just remove most of these?

Comment 7 Allon Mureinik 2016-02-16 14:52:48 UTC
Liron, worth taking note of this RFE during your work on SDM.

Comment 9 Allon Mureinik 2016-11-03 10:54:35 UTC
4.0 and 4.1 already cleaned up the code considerably.
Removing the leftovers isn't a goal on it's own right - if we ever need to do something in that area, we can perform this refactoring as part of it.


Note You need to log in before you can comment on or make changes to this bug.