RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1108522 - Various small fixes for RHEL 7.1 (corosync rebase)
Summary: Various small fixes for RHEL 7.1 (corosync rebase)
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 7
Classification: Red Hat
Component: corosync
Version: 7.1
Hardware: Unspecified
OS: Unspecified
low
low
Target Milestone: rc
: ---
Assignee: Jan Friesse
QA Contact: Cluster QE
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-06-12 07:55 UTC by Jan Friesse
Modified: 2015-03-05 08:27 UTC (History)
4 users (show)

Fixed In Version: corosync-2.3.4-1.el7
Doc Type: Bug Fix
Doc Text:
This BZ doesn't need Doc Text.
Clone Of:
Environment:
Last Closed: 2015-03-05 08:27:05 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
upstart: Make job conf file configurable (1.21 KB, patch)
2014-06-12 07:56 UTC, Jan Friesse 		no flags Details | Diff
Indent: Remove space in negation of expression (685 bytes, patch)
2014-06-12 07:56 UTC, Jan Friesse 		no flags Details | Diff
Indent: Remove newline before else branch start (888 bytes, patch)
2014-06-12 07:56 UTC, Jan Friesse 		no flags Details | Diff
totemiba: Add multicast recovery (4.52 KB, patch)
2014-06-12 07:57 UTC, Jan Friesse 		no flags Details | Diff
totemiba: Fix incorrect failed log message (1.35 KB, patch)
2014-06-12 07:57 UTC, Jan Friesse 		no flags Details | Diff
Install doc: Correct a typo (930 bytes, patch)
2014-06-12 08:03 UTC, Jan Friesse 		no flags Details | Diff
Doc: Enhance INSTALL file a bit (6.00 KB, patch)
2014-06-12 13:05 UTC, Jan Friesse 		no flags Details | Diff
systemd: Config example for corosync wd service (1.24 KB, patch)
2014-08-25 14:35 UTC, Jan Friesse 		no flags Details | Diff
fix memory leak produced by 'corosync -v' (1.06 KB, patch)
2014-08-25 14:35 UTC, Jan Friesse 		no flags Details | Diff
Handle SIGSEGV and SIGABRT signals (1.13 KB, patch)
2014-08-25 14:35 UTC, Jan Friesse 		no flags Details | Diff
Fix compiler warning introduced by previous patch (1.79 KB, patch)
2014-08-25 14:36 UTC, Jan Friesse 		no flags Details | Diff
corosync-cmapctl: Allow -p option to delete keys (2.91 KB, patch)
2014-08-25 14:36 UTC, Jan Friesse 		no flags Details | Diff
Implement config file testing mode (3.09 KB, patch)
2014-08-25 14:36 UTC, Jan Friesse 		no flags Details | Diff
cleanup after test-driver (1.09 KB, patch)
2014-08-25 14:36 UTC, Jan Friesse 		no flags Details | Diff
be consistent in using CPPFLAGS vs CFLAGS (1.82 KB, patch)
2014-08-25 14:36 UTC, Jan Friesse 		no flags Details | Diff
Slightly rework corosync-keygen. (6.55 KB, patch)
2014-08-25 14:36 UTC, Jan Friesse 		no flags Details | Diff
totemconfig: Free ifaddrs list (723 bytes, patch)
2014-08-25 14:36 UTC, Jan Friesse 		no flags Details | Diff
totemconfig: totem_config_get_ip_version (1.65 KB, patch)
2014-08-25 14:36 UTC, Jan Friesse 		no flags Details | Diff
totemconfig: refactor nodelist_to_interface func (5.40 KB, patch)
2014-08-25 14:36 UTC, Jan Friesse 		no flags Details | Diff
corosync-keygen: Replace printf/exit call with err (2.33 KB, patch)
2014-08-25 14:36 UTC, Jan Friesse 		no flags Details | Diff
config: Fix typos (6.87 KB, patch)
2014-08-25 14:36 UTC, Jan Friesse 		no flags Details | Diff
Cancel token holding while in retransmition (1.64 KB, patch)
2014-08-25 14:40 UTC, Jan Friesse 		no flags Details | Diff
quorumtool: Sort output by nodeid (2.42 KB, patch)
2014-08-25 14:40 UTC, Jan Friesse 		no flags Details | Diff
YKD: Fix loading of YKD quorum module (2.13 KB, patch)
2014-08-25 14:40 UTC, Jan Friesse 		no flags Details | Diff
corosync-quorumtool: add sort options (11.74 KB, patch)
2014-08-25 14:40 UTC, Jan Friesse 		no flags Details | Diff
TODO: Remove TODO file (5.25 KB, patch)
2014-08-25 14:40 UTC, Jan Friesse 		no flags Details | Diff
votequorum: Return current ring id in callback (6.46 KB, patch)
2014-08-25 14:43 UTC, Jan Friesse 		no flags Details | Diff
votequorum: Add ring id to poll call (8.34 KB, patch)
2014-08-25 14:43 UTC, Jan Friesse 		no flags Details | Diff
ipc: Process votequorum messages during sync (2.24 KB, patch)
2014-08-25 14:43 UTC, Jan Friesse 		no flags Details | Diff
votequorum: Block sync until qdevice poll (3.99 KB, patch)
2014-08-25 14:43 UTC, Jan Friesse 		no flags Details | Diff
testvotequorum2: Opt for polling with old ringid (3.03 KB, patch)
2014-08-25 14:43 UTC, Jan Friesse 		no flags Details | Diff
votequorum: Make qdev timeout in sync configurable (4.34 KB, patch)
2014-08-25 14:43 UTC, Jan Friesse 		no flags Details | Diff
Makefile: Do not install TODO file (876 bytes, patch)
2014-08-26 15:00 UTC, Jan Friesse 		no flags Details | Diff
Show Obsolete (3) View All


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2015:0365 0 normal SHIPPED_LIVE corosync bug fix and enhancement update 2015-03-05 12:51:37 UTC

Description Jan Friesse 2014-06-12 07:55:41 UTC 
Description of problem:
BZ is only for keep RHEL 7.1 package in sync with upstream.

Version-Release number of selected component (if applicable):
2.3.3

For QA: SanityOnly.
Comment 1 Jan Friesse 2014-06-12 07:56:42 UTC 
Created attachment 907995 [details]
upstart: Make job conf file configurable

upstart: Make job conf file configurable

Signed-off-by: Kazunori INOUE <kazunori.inoue3>
Reviewed-by: Jan Friesse <jfriesse>
Comment 2 Jan Friesse 2014-06-12 07:56:47 UTC 
Created attachment 907996 [details]
Indent: Remove space in negation of expression

Indent: Remove space in negation of expression

Signed-off-by: hfu <askfuhu>
Reviewed-by: Jan Friesse <jfriesse>
Comment 3 Jan Friesse 2014-06-12 07:56:52 UTC 
Created attachment 907997 [details]
Indent: Remove newline before else branch start

Indent: Remove newline before else branch start

Signed-off-by: hfu <askfuhu>
Reviewed-by: Jan Friesse <jfriesse>
Comment 4 Jan Friesse 2014-06-12 07:57:01 UTC 
Created attachment 907998 [details]
totemiba: Add multicast recovery

totemiba: Add multicast recovery

Totemiba wasn't able to survive SubnetManager handover or
restart. If SM was migrated to another node, corosync logged
"multicast error" and losses connectivity.

Commit should solve this situation.

Signed-off-by: Yevheniy Demchenko <zheka>
Reviewed-by: Jan Friesse <jfriesse>
Comment 5 Jan Friesse 2014-06-12 07:57:28 UTC 
Created attachment 907999 [details]
totemiba: Fix incorrect failed log message

totemiba: Fix incorrect failed log message

rdma_join_multicast failed ... message parameters was swapped.

Also information about multicast join is now logged as notice.

Signed-off-by: Jan Friesse <jfriesse>
Comment 6 Jan Friesse 2014-06-12 08:03:44 UTC 
Created attachment 908004 [details]
Install doc: Correct a typo

Install doc: Correct a typo

Signed-off-by: Konstantin <konstantin.ponomarenko>
Reviewed-by: Jan Friesse <jfriesse>
Comment 7 Jan Friesse 2014-06-12 13:05:30 UTC 
Created attachment 908111 [details]
Doc: Enhance INSTALL file a bit

Doc: Enhance INSTALL file a bit

Some information in INSTALL file were pretty outdated. This patch moves
them closer to current release.

Signed-off-by: Jan Friesse <jfriesse>
Reviewed-by: Christine Caulfield <ccaulfie>
Comment 9 Jan Friesse 2014-08-25 14:35:21 UTC 
Created attachment 930505 [details]
systemd: Config example for corosync wd service

systemd: Config example for corosync wd service

Signed-off-by: Kazunori INOUE <kazunori.inoue3>
Reviewed-by: Jan Friesse <jfriesse>
Comment 10 Jan Friesse 2014-08-25 14:35:47 UTC 
Created attachment 930506 [details]
fix memory leak produced by 'corosync -v'

fix memory leak produced by 'corosync -v'

Signed-off-by: zouyu <hopkings2005>
Reviewed-by: Jan Friesse <jfriesse>
Comment 11 Jan Friesse 2014-08-25 14:35:54 UTC 
Created attachment 930507 [details]
Handle SIGSEGV and SIGABRT signals

Handle SIGSEGV and SIGABRT signals

SIGSEGV and SIGABRT signals are now correctly handled (blackbox is
dumped and logsys is finalized).

Signed-off-by: zouyu <hopkings2005>
Reviewed-by: Jan Friesse <jfriesse>
Comment 12 Jan Friesse 2014-08-25 14:36:00 UTC 
Created attachment 930509 [details]
Fix compiler warning introduced by previous patch

Fix compiler warning introduced by previous patch

QB loop signal handler prototype differs from signal(2) prototype.
Solution is to create wrapper functions.

Signed-off-by: Jan Friesse <jfriesse>
Comment 13 Jan Friesse 2014-08-25 14:36:05 UTC 
Created attachment 930510 [details]
corosync-cmapctl: Allow -p option to delete keys

corosync-cmapctl: Allow -p option to delete keys

Signed-off-by: Vladislav Bogdanov <bubble>
Reviewed-by: Jan Friesse <jfriesse>
Comment 14 Jan Friesse 2014-08-25 14:36:10 UTC 
Created attachment 930511 [details]
Implement config file testing mode

Implement config file testing mode

Signed-off-by: Vladislav Bogdanov <bubble>
Reviewed-by: Jan Friesse <jfriesse>
Comment 15 Jan Friesse 2014-08-25 14:36:15 UTC 
Created attachment 930512 [details]
cleanup after test-driver

cleanup after test-driver

update .gitignore and make maintainer-clean target

Signed-off-by: Fabio M. Di Nitto <fdinitto>
Reviewed-by: Jan Friesse <jfriesse>
Comment 16 Jan Friesse 2014-08-25 14:36:20 UTC 
Created attachment 930513 [details]
be consistent in using CPPFLAGS vs CFLAGS

be consistent in using CPPFLAGS vs CFLAGS

Signed-off-by: Fabio M. Di Nitto <fdinitto>
Reviewed-by: Jan Friesse <jfriesse>
Comment 17 Jan Friesse 2014-08-25 14:36:24 UTC 
Created attachment 930514 [details]
Slightly rework corosync-keygen.

Slightly rework corosync-keygen.

Allow it to create keyfile not in the hardcoded location.
Drop root checks.
Minor cosmetic fixes to the man-page.

Signed-off-by: Vladislav Bogdanov <bubble>
Reviewed-by: Jan Friesse <jfriesse>
Comment 18 Jan Friesse 2014-08-25 14:36:29 UTC 
Created attachment 930515 [details]
totemconfig: Free ifaddrs list

totemconfig: Free ifaddrs list

Signed-off-by: Jan Friesse <jfriesse>
Reviewed-by: Fabio M. Di Nitto <fdinitto>
Comment 19 Jan Friesse 2014-08-25 14:36:34 UTC 
Created attachment 930516 [details]
totemconfig: totem_config_get_ip_version

totemconfig: totem_config_get_ip_version

Add totem_config_get_ip_version to get user configured ip version.
Make totem_config_read use this newly introduced function.

Signed-off-by: Jan Friesse <jfriesse>
Reviewed-by: Fabio M. Di Nitto <fdinitto>
Comment 20 Jan Friesse 2014-08-25 14:36:39 UTC 
Created attachment 930517 [details]
totemconfig: refactor nodelist_to_interface func

totemconfig: refactor nodelist_to_interface func

Move finding of bindaddr in nodelist to generally usable function
totem_config_find_local_addr_in_nodelist and refactor
config_convert_nodelist_to_interface function to use it.

Signed-off-by: Jan Friesse <jfriesse>
Reviewed-by: Fabio M. Di Nitto <fdinitto>
Comment 21 Jan Friesse 2014-08-25 14:36:44 UTC 
Created attachment 930518 [details]
corosync-keygen: Replace printf/exit call with err

corosync-keygen: Replace printf/exit call with err

Calling of err makes code shorter, easier to read and eliminates
problems with forgotten newline characters.

Signed-off-by: Jan Friesse <jfriesse>
Reviewed-by: Christine Caulfield <ccaulfie>
Comment 22 Jan Friesse 2014-08-25 14:36:50 UTC 
Created attachment 930519 [details]
config: Fix typos

config: Fix typos

Fix several places where 'then' is used instead of 'than' in error
messages and a comment.

Signed-off-by: Christine Caulfield <ccaulfie>
Reviewed-by: Jan Friesse <jfriesse>
Comment 23 Jan Friesse 2014-08-25 14:40:03 UTC 
Created attachment 930527 [details]
Cancel token holding while in retransmition

Cancel token holding while in retransmition

When there is no other activty on ring but only retransmition, and
token is in hold mode, the retransmition will become slow. More over,
if the retransmition is always fail but token rotation works well, then
it takes quite a lone time
(fail_to_recv_const * token_hold = 2500 * 180ms = 450sec) for the
retransmit requester to meet the "FAILED TO RECEIVE" condition to
re-construct a new ring.

This problem can be solved by checking if retransmits are present
before going into hold. If a node is the retransmit requester or
the resender, it set my_token_held to 0 to speed up retransmition
and omit further unnecessary sending of token_hold_cancel signal.

Signed-off-by: Jason HU <huzhijiang>
Reviewed-by: Christine Caulfield <ccaulfie>
Comment 24 Jan Friesse 2014-08-25 14:40:12 UTC 
Created attachment 930528 [details]
quorumtool: Sort output by nodeid

quorumtool: Sort output by nodeid

corosync-quorumtool prints the node listing by IP address
(as passed back to it from corosync) but this can be
counter-intuitive if the node IDs aren't in the same
order as the IP addresses. This patch sorts the nodes
by node ID so that the output is easier for humans to
parse.

Signed-off-by: Christine Caulfield <ccaulfie>
Reviewed-By: Jan Friesse <jfriesse>
Comment 25 Jan Friesse 2014-08-25 14:40:18 UTC 
Created attachment 930529 [details]
YKD: Fix loading of YKD quorum module

YKD: Fix loading of YKD quorum module

Although YKD is currently unsupported, untested and decprecated it's
handy for testing things in the quorum module.

This patch allows YKD to actually load without an error. It does not fix
anything else in the service!

Also remove vsftype and its reference to YKD being the preferred and
default provider from the corosync.conf man page,
as that hasn't been true for a considerable time.

Signed-off-by: Christine Caulfield <ccaulfie>
Reviewed-by: Jan Friesse <jfriesse>
Comment 26 Jan Friesse 2014-08-25 14:40:22 UTC 
Created attachment 930530 [details]
corosync-quorumtool: add sort options

corosync-quorumtool: add sort options

Adds a -o<a|i|n> option to corosync-votequorum so that the nodes list
can be sorted by Address, node Id or Name. The default remains IP
address.

Signed-Off-By: Christine Caulfield <ccaulfie>
Reviewed-by: Jan Friesse <jfriesse>
Comment 27 Jan Friesse 2014-08-25 14:40:26 UTC 
Created attachment 930531 [details]
TODO: Remove TODO file

TODO: Remove TODO file

TODO file has many problems like it's not updated regularly, it's not
updated at all in already distributed tarballs, ...

All relevant RFEs were filled at github as issues with flag "TODO file
convert" so file can finally be removed from git.

Signed-off-by: Jan Friesse <jfriesse>
Reviewed-by: Christine Caulfield <ccaulfie>
Comment 28 Jan Friesse 2014-08-25 14:43:31 UTC 
Created attachment 930535 [details]
votequorum: Return current ring id in callback

votequorum: Return current ring id in callback

Returning ring id will be used in poll function.

Signed-off-by: Jan Friesse <jfriesse>
Reviewed-by: Christine Caulfield <ccaulfie>
Comment 29 Jan Friesse 2014-08-25 14:43:35 UTC 
Created attachment 930536 [details]
votequorum: Add ring id to poll call

votequorum: Add ring id to poll call

If votequorum service receives incorrect (not current) ringid, call is
ignored and CS_ERR_MESSAGE_ERROR is returned.

This and previous commits makes incompatible changes in votequorum
API/ABI, so library version is increased.

Signed-off-by: Jan Friesse <jfriesse>
Reviewed-by: Christine Caulfield <ccaulfie>
Comment 30 Jan Friesse 2014-08-25 14:43:38 UTC 
Created attachment 930537 [details]
ipc: Process votequorum messages during sync

ipc: Process votequorum messages during sync

This is needed for qdevice to be able to process messages during
synchronization phase.

Signed-off-by: Jan Friesse <jfriesse>
Reviewed-by: Christine Caulfield <ccaulfie>
Comment 31 Jan Friesse 2014-08-25 14:43:42 UTC 
Created attachment 930538 [details]
votequorum: Block sync until qdevice poll

votequorum: Block sync until qdevice poll

If qdevice is registered a alive, corosync waits in sync phase until
timeout expires or qdevice votes with correct nodeid parameter.

This gives qdevice time to decide to vote or not undisturbed and without
time hazard.

Signed-off-by: Jan Friesse <jfriesse>
Reviewed-by: Christine Caulfield <ccaulfie>
Comment 32 Jan Friesse 2014-08-25 14:43:46 UTC 
Created attachment 930539 [details]
testvotequorum2: Opt for polling with old ringid

testvotequorum2: Opt for polling with old ringid

Option -F is added to force sending old ringid for given number of
times. Option is useful for testing failure scenario during corosync
synchronization phase.

Signed-off-by: Jan Friesse <jfriesse>
Reviewed-by: Christine Caulfield <ccaulfie>
Comment 33 Jan Friesse 2014-08-25 14:43:49 UTC 
Created attachment 930540 [details]
votequorum: Make qdev timeout in sync configurable

votequorum: Make qdev timeout in sync configurable

Configuration option quorum.device.sync_timeout is available for setting
qdevice poll timeout for synchronization phase. Default value is 30
sec.

Signed-off-by: Jan Friesse <jfriesse>
Reviewed-by: Christine Caulfield <ccaulfie>
Comment 34 Jan Friesse 2014-08-26 15:00:48 UTC 
Created attachment 931024 [details]
Makefile: Do not install TODO file

Makefile: Do not install TODO file

Signed-off-by: Jan Friesse <jfriesse>
Comment 38 errata-xmlrpc 2015-03-05 08:27:05 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-0365.html
Note You need to log in before you can comment on or make changes to this bug.