Spec URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kcmutils.spec SRPM URL: http://dvratil.fedorapeople.org/kf5/review/kf5-kcmutils-4.100.0-1.fc20.src.rpm Description: KDE Frameworks 5 Tier 3 addon with extra API to write KConfigModules Fedora Account dvratil
Package looks OK to me, full report below: ------------------------------------------- Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= [x] Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. ===== MUST items ===== C/C++: [-]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "LGPL (v2)", "LGPL (v2 or later)", "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/ltinkl/tmp/1108828-kf5-kcmutils/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/locale/hne, /usr/share/locale/hne/LC_MESSAGES [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/qt5/mkspecs, /usr/share/kservicetypes5, /usr/share/locale/hne, /usr/include/KF5, /usr/lib/qt5/mkspecs/modules, /usr/share/locale/hne/LC_MESSAGES, /usr/lib/cmake [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [s]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Scriptlets must be sane, if used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define framework kcmutils [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [-]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1187840 bytes in /usr/share [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: kf5-kcmutils-4.100.0-1.fc21.i686.rpm kf5-kcmutils-devel-4.100.0-1.fc21.i686.rpm kf5-kcmutils-4.100.0-1.fc21.src.rpm kf5-kcmutils.i686: W: spelling-error Summary(en_US) addon -> ad don, ad-don, add on kf5-kcmutils-devel.i686: W: no-documentation kf5-kcmutils.src: W: spelling-error Summary(en_US) addon -> ad don, ad-don, add on kf5-kcmutils.src: W: strange-permission kcmutils-4.100.0.tar.xz 0666L kf5-kcmutils.src:10: W: macro-in-comment %{framework} kf5-kcmutils.src:10: W: macro-in-comment %{version} kf5-kcmutils.src:11: W: macro-in-comment %{framework} kf5-kcmutils.src:12: W: macro-in-comment %{name} kf5-kcmutils.src:12: W: macro-in-comment %{version} kf5-kcmutils.src:12: W: macro-in-comment %{snapshot} kf5-kcmutils.src:13: W: macro-in-comment %{name} kf5-kcmutils.src:13: W: macro-in-comment %{version} kf5-kcmutils.src:13: W: macro-in-comment %{snapshot} 3 packages and 0 specfiles checked; 0 errors, 13 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint kf5-kcmutils-devel kf5-kcmutils kf5-kcmutils-devel.i686: W: no-documentation kf5-kcmutils.i686: W: spelling-error Summary(en_US) addon -> ad don, ad-don, add on kf5-kcmutils.i686: W: unused-direct-shlib-dependency /usr/lib/libKF5KCMUtils.so.4.100.0 /lib/libKF5Codecs.so.5 kf5-kcmutils.i686: W: unused-direct-shlib-dependency /usr/lib/libKF5KCMUtils.so.4.100.0 /lib/libKF5ConfigGui.so.5 kf5-kcmutils.i686: W: unused-direct-shlib-dependency /usr/lib/libKF5KCMUtils.so.4.100.0 /lib/libQt5Xml.so.5 kf5-kcmutils.i686: W: unused-direct-shlib-dependency /usr/lib/libKF5KCMUtils.so.4.100.0 /lib/libm.so.6 kf5-kcmutils.i686: W: unused-direct-shlib-dependency /usr/lib/libKF5KCMUtils.so.4.100.0 /lib/libgcc_s.so.1 2 packages and 0 specfiles checked; 0 errors, 7 warnings. # echo 'rpmlint-done:' Requires -------- kf5-kcmutils-devel (rpmlib, GLIBC filtered): kf5-kcmutils(x86-32) kf5-kconfigwidgets-devel kf5-kcoreaddons-devel kf5-ki18n-devel kf5-kiconthemes-devel kf5-kitemviews-devel kf5-kservice-devel kf5-kxmlgui-devel libKF5KCMUtils.so.5 kf5-kcmutils (rpmlib, GLIBC filtered): /sbin/ldconfig kf5-filesystem libKF5Auth.so.5 libKF5Codecs.so.5 libKF5ConfigCore.so.5 libKF5ConfigGui.so.5 libKF5ConfigWidgets.so.5 libKF5CoreAddons.so.5 libKF5I18n.so.5 libKF5IconThemes.so.5 libKF5ItemViews.so.5 libKF5Service.so.5 libKF5WidgetsAddons.so.5 libKF5XmlGui.so.5 libQt5Core.so.5 libQt5DBus.so.5 libQt5Gui.so.5 libQt5Widgets.so.5 libQt5Xml.so.5 libc.so.6 libgcc_s.so.1 libm.so.6 libstdc++.so.6 libstdc++.so.6(CXXABI_1.3) rtld(GNU_HASH) Provides -------- kf5-kcmutils-devel: kf5-kcmutils-devel kf5-kcmutils-devel(x86-32) kf5-kcmutils: kf5-kcmutils kf5-kcmutils(x86-32) libKF5KCMUtils.so.5 Source checksums ---------------- http://download.kde.org/unstable/frameworks/4.100.0/kcmutils-4.100.0.tar.xz : CHECKSUM(SHA256) this package : a5f6bdbab8d3372406bd46e524d6d93cf7bee5189516599536410d4e7e0d9681 CHECKSUM(SHA256) upstream package : a5f6bdbab8d3372406bd46e524d6d93cf7bee5189516599536410d4e7e0d9681 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1108828 -m fedora-rawhide-i386 --local-repo /home/ltinkl/kf5-packages/ Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG Built with local dependencies: /home/ltinkl/kf5-packages/kf5-knotifications-devel-4.100.0-1.fc21.i686.rpm /home/ltinkl/kf5-packages/kf5-kxmlgui-devel-4.100.0-1.fc21.i686.rpm /home/ltinkl/kf5-packages/kf5-kservice-4.100.0-1.fc21.i686.rpm /home/ltinkl/kf5-packages/kf5-kbookmarks-4.100.0-1.fc21.i686.rpm /home/ltinkl/kf5-packages/kf5-knotifications-4.100.0-1.fc21.i686.rpm /home/ltinkl/kf5-packages/kf5-ktextwidgets-devel-4.100.0-1.fc21.i686.rpm /home/ltinkl/kf5-packages/kf5-kiconthemes-devel-4.100.0-1.fc21.i686.rpm /home/ltinkl/kf5-packages/kf5-ktextwidgets-4.100.0-1.fc21.i686.rpm /home/ltinkl/kf5-packages/kf5-kxmlgui-4.100.0-1.fc21.i686.rpm /home/ltinkl/kf5-packages/kf5-kservice-devel-4.100.0-1.fc21.i686.rpm /home/ltinkl/kf5-packages/kf5-kbookmarks-devel-4.100.0-1.fc21.i686.rpm /home/ltinkl/kf5-packages/kf5-kiconthemes-4.100.0-1.fc21.i686.rpm
New Package SCM Request ======================= Package Name: kf5-kcmutils Short Description: KDE Frameworks 5 Tier 3 addon with extra API to write KConfigModules Upstream URL: http://www.kde.org Owners: dvratil ltinkl jgrulich rdieter kkofler than Branches: InitialCC:
Git done (by process-git-requests).
Package Change Request ======================= Package Name: kf5-kcmutils New Branches: f20 Owners: dvratil ltinkl jgrulich kkofler rdieter than