Bug 1108958 - run-tests.sh should warn on missing yajl
Summary: run-tests.sh should warn on missing yajl
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: GlusterFS
Classification: Community
Component: tests
Version: pre-release
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: krishnan parthasarathi
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-06-13 01:42 UTC by Justin Clift
Modified: 2015-11-03 23:06 UTC (History)
4 users (show)

Fixed In Version: glusterfs-3.6.0beta1
Clone Of:
Environment:
Last Closed: 2014-11-11 08:35:00 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Justin Clift 2014-06-13 01:42:06 UTC
Description of problem:

  We should add a check for yajl (/usr/bin/json_verify) to run-tests.sh,
  in order to pro-actively warn people it's needed.

  Otherwise some tests (meta.t at least) will fail:

    ./tests/basic/../include.rc: line 166: /usr/bin/json_verify: No such file or directory
    ./tests/basic/../include.rc: line 166: /usr/bin/json_verify: No such file or directory
    ./tests/basic/../include.rc: line 166: /usr/bin/json_verify: No such file or directory
    [01:26:55] ./tests/basic/meta.t .............................. 
    not ok 10 
    not ok 11 
    not ok 12 


Version-Release number of selected component (if applicable):

  Upstream GlusterFS git repo, master branch, as of Fri 13th June 2014.


How reproducible:

  Every time.


Steps to Reproduce:
1. Run run-tests.sh without yajl (/usr/bin/json_verify) installed.
2. The basic/meta.t test will fail

Comment 1 Anand Avati 2014-06-13 01:46:15 UTC
REVIEW: http://review.gluster.org/8054 (tests: add missing check for yajl to run-tests.sh) posted (#1) for review on master by Justin Clift (justin)

Comment 2 Anand Avati 2014-06-13 02:34:38 UTC
REVIEW: http://review.gluster.org/8054 (tests: add missing check for yajl to run-tests.sh) posted (#2) for review on master by Justin Clift (justin)

Comment 3 Anand Avati 2014-06-13 16:59:43 UTC
COMMIT: http://review.gluster.org/8054 committed in master by Vijay Bellur (vbellur) 
------
commit 053389c89eb1c1937e795dd52f7c10a4a295b707
Author: Justin Clift <justin>
Date:   Fri Jun 13 03:33:51 2014 +0100

    tests: add missing check for yajl to run-tests.sh
    
    Also add it to the regression test Requires line, along with other
    missing dependencies.
    
    Change-Id: I2a83eb6797bafe8883d90565bb4c1ab93c074644
    BUG: 1108958
    Reviewed-on: http://review.gluster.org/8054
    Reviewed-by: Harshavardhana <harsha>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 4 Niels de Vos 2014-09-22 12:42:49 UTC
A beta release for GlusterFS 3.6.0 has been released. Please verify if the release solves this bug report for you. In case the glusterfs-3.6.0beta1 release does not have a resolution for this issue, leave a comment in this bug and move the status to ASSIGNED. If this release fixes the problem for you, leave a note and change the status to VERIFIED.

Packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update (possibly an "updates-testing" repository) infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-September/018836.html
[2] http://supercolony.gluster.org/pipermail/gluster-users/

Comment 5 Niels de Vos 2014-11-11 08:35:00 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report.

glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html
[2] http://supercolony.gluster.org/mailman/listinfo/gluster-users


Note You need to log in before you can comment on or make changes to this bug.