Spec URL: http://oirase.annexia.org/reviews/python-evtx/python-evtx.spec SRPM URL: http://oirase.annexia.org/reviews/python-evtx/python-evtx-0-0.1.git8838756b.src.rpm Description: Windows Event Log parsing library and tools Fedora Account System Username: rjones
Upstream URLs: http://www.williballenthin.com/evtx/ https://github.com/williballenthin/python-evtx
rpmlint output: python-evtx.src: W: invalid-url Source0: python-evtx-master.zip python-evtx.noarch: W: no-manual-page-for-binary evtxdump.py python-evtx.noarch: W: no-manual-page-for-binary evtxinfo.py 3 packages and 0 specfiles checked; 0 errors, 3 warnings.
Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7047161
Please follow http://fedoraproject.org/wiki/Packaging:SourceURL#Github Upstream even does releases so its either Source0: https://github.com/williballenthin/%{name}/archive/v%{version}.tar.gz for the last 0.3.1 release or for master %global commit 8838756be2736695311440073d9f0b498df1fc24 %global shortcommit %(c=%{commit}; echo ${c:0:7}) Source0: https://github.com/williballenthin/%{name}/archive/%{commit}/%{name}-%{commit}.tar.gz
Ah I didn't see those tarballs. Try this updated package: http://oirase.annexia.org/reviews/python-evtx/ http://oirase.annexia.org/reviews/python-evtx/python-evtx.spec http://oirase.annexia.org/reviews/python-evtx/python-evtx-0.3.2-0.1.20140326git8838756.src.rpm
I think there are some changes to do according to the Packaging Guidelines for Python. https://fedoraproject.org/wiki/Packaging:Python
Hi! 1. BuildRequires: python should be BuildRequires: python2-devel 2. find Evtx -name '*.py' | xargs sed -i '/\/usr\/bin\/python/d' I think it would be better to check for shebang only, something like: | xargs sed -i ''/^#!.*\/python/d' 3. Why not use summary and description from package's setup.py? https://github.com/williballenthin/python-evtx/blob/master/setup.py Also I think in "Programming documentation for %{name}" using full summary of the base package would be more helpful for a user. Newer build for reference: http://koji.fedoraproject.org/koji/taskinfo?taskID=7811652
http://oirase.annexia.org/reviews/python-evtx/ http://oirase.annexia.org/reviews/python-evtx/python-evtx.spec http://oirase.annexia.org/reviews/python-evtx/python-evtx-0.3.2-0.1.20140326git8838756.src.rpm Updated with the suggestions from comment 7.
Looks like 0.5.3 is out now. Update to that and current guidelines and I'll review.
[itamar@lenovo fedora]$ python -c "from distutils.sysconfig import get_python_lib; print (get_python_lib())" /usr/lib/python2.7/site-packages [itamar@lenovo fedora]$ rpm -E '%{python2_sitelib}' /usr/lib/python2.7/site-packages [itamar@lenovo fedora]$ rpm -E '%{python3_sitelib}' /usr/lib/python3.6/site-packages I think you probably should use %{python2_sitelib} / %{python3_sitelib} macros, they are already defined. I saw a guy defining a macro for description and using it instead of repeating it, an small example here -> https://itamarjp.fedorapeople.org/review/python-flask-sphinx-themes.spec, if you do that your spec file will become smaller.
some people are talking about retiring python2 in rawhide, do you have a new version compatible with python3 ?
I'm going to close this as I don't have time or interest to fix the request for Python 3 etc.