Bug 1109717 - Review Request: python-evtx - Windows Event Log parsing library and tools
Review Request: python-evtx - Windows Event Log parsing library and tools
Status: NEW
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Nobody's working on this, feel free to take it
Fedora Extras Quality Assurance
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2014-06-16 04:27 EDT by Richard W.M. Jones
Modified: 2017-03-11 12:47 EST (History)
5 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed:
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Richard W.M. Jones 2014-06-16 04:27:58 EDT
Spec URL: http://oirase.annexia.org/reviews/python-evtx/python-evtx.spec
SRPM URL: http://oirase.annexia.org/reviews/python-evtx/python-evtx-0-0.1.git8838756b.src.rpm
Description: Windows Event Log parsing library and tools
Fedora Account System Username: rjones
Comment 1 Richard W.M. Jones 2014-06-16 04:29:58 EDT
Upstream URLs:
http://www.williballenthin.com/evtx/
https://github.com/williballenthin/python-evtx
Comment 2 Richard W.M. Jones 2014-06-16 04:30:14 EDT
rpmlint output:

python-evtx.src: W: invalid-url Source0: python-evtx-master.zip
python-evtx.noarch: W: no-manual-page-for-binary evtxdump.py
python-evtx.noarch: W: no-manual-page-for-binary evtxinfo.py
3 packages and 0 specfiles checked; 0 errors, 3 warnings.
Comment 3 Richard W.M. Jones 2014-06-16 05:08:03 EDT
Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=7047161
Comment 4 Yanko Kaneti 2014-06-18 04:05:47 EDT
Please follow http://fedoraproject.org/wiki/Packaging:SourceURL#Github
Upstream even does releases so its either
Source0: https://github.com/williballenthin/%{name}/archive/v%{version}.tar.gz
for the last 0.3.1 release
or for master
%global commit 8838756be2736695311440073d9f0b498df1fc24
%global shortcommit %(c=%{commit}; echo ${c:0:7})
Source0: https://github.com/williballenthin/%{name}/archive/%{commit}/%{name}-%{commit}.tar.gz
Comment 6 Antonio Trande 2014-08-13 15:03:25 EDT
I think there are some changes to do according to the Packaging Guidelines for Python.
https://fedoraproject.org/wiki/Packaging:Python
Comment 7 Dmitry Tantsur 2014-10-09 09:35:56 EDT
Hi!

1. BuildRequires:  python
should be 
BuildRequires:  python2-devel

2. find Evtx -name '*.py' | xargs sed -i '/\/usr\/bin\/python/d'
I think it would be better to check for shebang only, something like:
| xargs sed -i ''/^#!.*\/python/d'

3. Why not use summary and description from package's setup.py?
https://github.com/williballenthin/python-evtx/blob/master/setup.py
Also I think in "Programming documentation for %{name}" using full summary of the base package would be more helpful for a user.


Newer build for reference: http://koji.fedoraproject.org/koji/taskinfo?taskID=7811652
Comment 9 Orion Poplawski 2017-03-11 12:47:24 EST
Looks like 0.5.3 is out now.  Update to that and current guidelines and I'll review.

Note You need to log in before you can comment on or make changes to this bug.