Description of problem: During glusterd handshake if one of the glusterd has a lower operating version we move the entire cluster operating version to the lower value irrespective whether the new glusterd is a valid friend or not. Version-Release number of selected component (if applicable): How reproducible: Always Steps to Reproduce: 1. Create a cluster of two or more node. (The op-version of the cluster should be 4 or less) 2. Clean everything (including peer details) from one node and re-install latest glusterd on this node having op-version 30600. 3. Start glusterd on this node. Actual results: Logs and glusterd.info file will show that the cluster op-version is 4. And peer status will not show other nodes on the new node. Expected results: op-version should only be changed if we are accepting the node in the cluster. Additional info: During glusterd start I am seeing this log: [2014-06-16 09:36:57.718526] I [glusterd-store.c:1936:glusterd_restore_op_version] 0-glusterd: retrieved op-version: 30600 ... [2014-06-16 09:36:58.029183] I [glusterd-handshake.c:985:__glusterd_mgmt_hndsk_versions_ack] 0-management: using the op-version 4
REVIEW: http://review.gluster.org/8126 (glusterd: Authenticate management handshake requests) posted (#1) for review on master by Kaushal M (kaushal)
REVIEW: http://review.gluster.org/8126 (glusterd: Authenticate management handshake requests) posted (#2) for review on master by Kaushal M (kaushal)
REVIEW: http://review.gluster.org/8126 (glusterd: Authenticate management handshake requests) posted (#3) for review on master by Kaushal M (kaushal)
REVIEW: http://review.gluster.org/8126 (glusterd: Authenticate management handshake requests) posted (#4) for review on master by Kaushal M (kaushal)
REVIEW: http://review.gluster.org/8126 (glusterd: Authenticate management handshake requests) posted (#5) for review on master by Kaushal M (kaushal)
REVIEW: http://review.gluster.org/8126 (glusterd: Authenticate management handshake requests) posted (#6) for review on master by Kaushal M (kaushal)
COMMIT: http://review.gluster.org/8126 committed in master by Krishnan Parthasarathi (kparthas) ------ commit 371bb42410ca5bbcf1f13ad1c8d015fcbe6ec5ce Author: Kaushal M <kaushal> Date: Thu Jun 19 15:31:46 2014 +0530 glusterd: Authenticate management handshake requests Management handshake requests, which are used to validate op-version supported by the peers, are now only allowed if, - the glusterd doesn't have any other peer, or - the request was sent by another peer. This prevents the op-version of a peer being changed because of a connection attempt by an invalid peer. Change-Id: I248c386ed5ec4f8360e7b5e7f9ab74b7e8a7fc65 BUG: 1109741 Signed-off-by: Kaushal M <kaushal> Reviewed-on: http://review.gluster.org/8126 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Atin Mukherjee <amukherj> Reviewed-by: Krishnan Parthasarathi <kparthas> Tested-by: Krishnan Parthasarathi <kparthas>
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report. glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939 [2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user