Spec URL: http://pmackinn.fedorapeople.org/datanucleus/datanucleus-maven-parent.spec SRPM URL: http://pmackinn.fedorapeople.org/datanucleus/datanucleus-maven-parent-3.3-1.fc21.src.rpm Description: DataNucleus Maven parent project Fedora Account System Username: pmackinn
build fails: [ERROR] The project org.datanucleus:datanucleus-maven-parent:3.3 (/builddir/build/BUILD/datanucleus-maven-parent-datanucleus-maven-parent-3.3/pom.xml) has 1 error [ERROR] Unresolveable build extension: Plugin org.apache.maven.wagon:wagon-ssh-external:2.2 or one of its dependencies could not be resolved: Cannot access central (http://repo.maven.apache.org/maven2) in offline mode and the artifact org.apache.maven.wagon:wagon-ssh-external:jar:2.2 has not been downloaded from it before. -> [Help 2] please, use %pom_xpath_remove "pom:build/pom:extensions" or add the missing BR
please, consider also http://fedoraproject.org/wiki/Packaging:SourceURL#Github https://github.com/datanucleus/datanucleus-maven-parent/archive/8e55762cef51784b0308ed4cdcfeceaadb03e1d6/datanucleus-maven-parent-8e55762cef51784b0308ed4cdcfeceaadb03e1d6.tar.gz %global commit 62cef51784b0308ed4cdcfeceaadb03e1d6 %global shortcommit %(c=%{commit}; echo ${c:0:7}) ... URL: https://github.com/datanucleus/datanucleus-maven-paren Source: https://github.com/datanucleus/%{name}/archive/%{name}-%{commit}.tar.gz ... %prep %setup -qn %{name}-%{commit} ...
Spec URL: http://pmackinn.fedorapeople.org/datanucleus/datanucleus-maven-parent.spec SRPM URL: http://pmackinn.fedorapeople.org/datanucleus/datanucleus-maven-parent-3.3-1.fc21.src.rpm Issues addressed: - switched to git ref - logged DN jira for missing license - removed wagon-ssh-external dep However, I don't want to go to the "latest" 4 series since this will be the parent POM for datanucleus{-core,-rdbms,-api-jdo}, all of which should remain at the 3 series for now to support the Fedora Hive package.
ops, build fails: [ERROR] Unable to resolve artifact org.apache.maven.plugins:maven-clean-plugin:jar:SYSTEM please, add or remove maven-clean-plugin as BuildRequires
Sorry about that gil, I'm a lazy mock man... Finish: build phase for datanucleus-maven-parent-3.3-1.fc20.src.rpm INFO: Done(/home/pmackinn/rpmbuild/SRPMS/datanucleus-maven-parent-3.3-1.fc20.src.rpm) Config(fedora-rawhide-x86_64) 9 minutes 7 seconds Spec URL: http://pmackinn.fedorapeople.org/datanucleus/datanucleus-maven-parent.spec SRPM URL: http://pmackinn.fedorapeople.org/datanucleus/datanucleus-maven-parent-3.3-1.fc20.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - This seems like a Java package, please install fedora-review-plugin-java to get additional checks ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. No licenses found. Please check the source files for licenses manually. [-]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/maven-poms/datanucleus-maven-parent, /usr/share/maven-metadata [?]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/maven-poms /datanucleus-maven-parent, /usr/share/maven-metadata [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [!]: Latest version is packaged. [!]: Package does not include license text files separate from upstream. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: datanucleus-maven-parent-3.3-1.fc21.noarch.rpm datanucleus-maven-parent-3.3-1.fc21.src.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint datanucleus-maven-parent 1 packages and 0 specfiles checked; 0 errors, 0 warnings. # echo 'rpmlint-done:' Requires -------- datanucleus-maven-parent (rpmlib, GLIBC filtered): java-headless jpackage-utils mvn(org.apache.felix:maven-bundle-plugin) mvn(org.apache.maven.plugins:maven-clean-plugin) mvn(org.apache.maven.plugins:maven-compiler-plugin) mvn(org.apache.maven.plugins:maven-jar-plugin) mvn(org.apache.maven.plugins:maven-javadoc-plugin) mvn(org.apache.maven.plugins:maven-surefire-plugin) mvn(org.sonatype.oss:oss-parent:pom:) Provides -------- datanucleus-maven-parent: datanucleus-maven-parent mvn(org.datanucleus:datanucleus-maven-parent:pom:) Source checksums ---------------- https://github.com/datanucleus/datanucleus-maven-parent/archive/8e55762cef51784b0308ed4cdcfeceaadb03e1d6/datanucleus-maven-parent-8e55762cef51784b0308ed4cdcfeceaadb03e1d6.tar.gz : CHECKSUM(SHA256) this package : f0c7438e31dcd1e34ad09956de5717a12ce2e42b337e9c162840815026e62174 CHECKSUM(SHA256) upstream package : f0c7438e31dcd1e34ad09956de5717a12ce2e42b337e9c162840815026e62174 http://www.apache.org/licenses/LICENSE-2.0.txt : CHECKSUM(SHA256) this package : cfc7749b96f63bd31c3c42b5c471bf756814053e847c10f3eb003417bc523d30 CHECKSUM(SHA256) upstream package : cfc7749b96f63bd31c3c42b5c471bf756814053e847c10f3eb003417bc523d30 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -b 1109884 -m fedora-rawhide-i386 Buildroot used: fedora-rawhide-i386 Active plugins: Generic, Shell-api, Java Disabled plugins: C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
NOTE: this is a bug or are newer setting for maven metadata? [?]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/maven-poms/datanucleus-maven-parent
gil, checked with mizdebsk and that's a known issue to be fixed in a future update to xmvn.
New Package SCM Request ======================= Package Name: datanucleus-maven-parent Short Description: DataNucleus Maven parent project Owners: pmackinn Branches: InitialCC: java-sig
(In reply to Pete MacKinnon from comment #8) > gil, checked with mizdebsk and that's a known issue to be fixed in a future > update to xmvn. mizdebsk says: "this is a known bug in xmvn. ... it should be resolved within a month. you can add %dir if you really want, but i probably wouldn't do that."
Git done (by process-git-requests).