Bug 1110415 - `oo-admin-broker-cache --clear --console` does not warn that --console flag does nothing
Summary: `oo-admin-broker-cache --clear --console` does not warn that --console flag d...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Node
Version: 2.0.0
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: ---
: ---
Assignee: Miciah Dashiel Butler Masters
QA Contact: libra bugs
URL:
Whiteboard:
Depends On:
Blocks: 1110547 1280532
TreeView+ depends on / blocked
 
Reported: 2014-06-17 15:18 UTC by Frederic Hornain
Modified: 2015-12-17 17:09 UTC (History)
8 users (show)

Fixed In Version: openshift-origin-broker-util-1.37.4.1-1.el6op
Doc Type: Bug Fix
Doc Text:
Prior to OpenShift Enterprise 2.1, the command to clear both the broker's and the console's cache was `oo-admin-broker-cache --clear --console`. As of OSE 2.1, `oo-admin-broker-cache` only clears the broker's cache, and it is necessary to use `oo-admin-console-cache` to clear the console's cache. However, running `oo-admin-broker-cache --clear --console` did not warn that the `--console` flag did nothing; instead, `oo-admin-broker-cache` would silently ignore the `--console` flag. This bug fix updates the `oo-admin-broker-cache` command to no longer ignore the `--console` flag; instead, specifying the flag now causes the command to print an error with usage information.
Clone Of:
: 1110547 1280532 (view as bug list)
Environment:
Last Closed: 2015-12-17 17:09:08 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHSA-2015:2666 0 normal SHIPPED_LIVE Important: Red Hat OpenShift Enterprise 2.2.8 security, bug fix, and enhancement update 2015-12-17 22:07:54 UTC

Description Frederic Hornain 2014-06-17 15:18:25 UTC
Description of problem:

Could you please remplace the following line 

# oo-admin-broker-cache --clear
# oo-admin-console-cache --clear

by that one 

oo-admin-broker-cache --clear --console

on the 5.4. Managing Custom and Community Cartridges chapter, point 3 in the 
Procedure 5.2. To Install Custom or Community Cartridges section.

in the Openshift Administration Guide - https://access.redhat.com/site/documentation/en-US/OpenShift_Enterprise/2/html-single/Administration_Guide/index.html#Importing_Cartridge_Manifests_on_Broker_Hosts

Thanks

Comment 1 Miciah Dashiel Butler Masters 2014-06-17 15:23:20 UTC
Prior to OSE 2.1, `oo-admin-broker-cache --clear --console` was the correct command.  As of OSE 2.1, oo-admin-broker-cache only clears the broker's cache, and it is necessary to use oo-admin-console-cache to clear the console's cache.

Unfortunately, the output of `oo-admin-broker-cache --clear --console` does not warn that its --console flag no longer does anything.  Clearly, this absence of a warning is confusing.

Comment 3 Luke Meyer 2014-06-17 18:20:19 UTC
There's probably an option to have it complain about any unrecognized options. Or just have that option specifically let the user know it's not doing anything.

Comment 5 openshift-github-bot 2015-09-23 00:13:47 UTC
Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/2e599fd30b0d933601ecd2ff76ed70e1bfa12ff3
oo-admin-broker-cache: Delete --console flag

Delete the --console flag, which has been deprecated for over a year now
(since commit a09f8c3187a51807930065ea7df0798a6d831946 on 2014-03-28), from
the oo-admin-broker-cache command.  After this commit, giving the --console
flag will result in an error with usage information instead of silently
ignoring the flag, which could give the administrator the false impression
that the --console flag did in fact do something.

This commit fixes bug 1110415.

Comment 10 Ma xiaoqiang 2015-11-12 01:51:07 UTC
Check on puddle [2.2.8/2015-11-11.1]
# oo-admin-broker-cache --clear --console
/usr/sbin/oo-admin-broker-cache: unrecognized option `--console'
== Synopsis

oo-admin-broker-cache: Manage the broker Rails application's cache

== Usage

oo-admin-broker-cache OPTIONS

Options:
-c|--clear
    Remove all entries from the broker Rails application's cache
-q|--quiet
    Show as little output as possible
-h|--help
    Show Usage info

work fine, move it to VERIFIED.

Comment 12 errata-xmlrpc 2015-12-17 17:09:08 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-2666.html


Note You need to log in before you can comment on or make changes to this bug.