Bug 1110669 - Review Request: rubygem-multi_test - Wafter-thin gem to help control rogue test/unit/autorun requires
Summary: Review Request: rubygem-multi_test - Wafter-thin gem to help control rogue te...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Vít Ondruch
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-06-18 08:42 UTC by Josef Stribny
Modified: 2016-01-04 05:52 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2014-06-19 07:28:41 UTC
Type: ---
Embargoed:
vondruch: fedora-review+
kevin: fedora-cvs+


Attachments (Terms of Use)

Description Josef Stribny 2014-06-18 08:42:00 UTC
Spec URL: http://data-strzibny.rhcloud.com/rubygem-multi_test.spec
SRPM URL: http://data-strzibny.rhcloud.com/rubygem-multi_test-0.1.1-1.fc21.src.rpm
Description: multi_test provides a uniform interface onto whatever testing
library has been loaded into a running Ruby process.
Fedora Account System Username: jstribny

This package is needed for the future versions of cucumber.

Comment 1 Vít Ondruch 2014-06-18 09:42:16 UTC
I'll take this for a review.

Comment 2 Vít Ondruch 2014-06-18 10:03:46 UTC
* Useless provide
  - The "Provides: rubygem(%{gem_name})" is now autogenerated.
  - rpmlint complains as well.

* Summary/description
  - The summary and description, which are coming from gem, are trying to be
    cool, but are not very helpful. Please consider to use the summary and
    description from upstream sources:

    https://github.com/cucumber/multi_test

  - May be you should try to pursuade upstream to change them in the gem as well.

These are just minor nits and the package looks sane => APPROVED

Comment 3 Josef Stribny 2014-06-18 10:32:33 UTC
New Package SCM Request
=======================
Package Name: rubygem-multi_test
Short Description:  Wafter-thin gem to disable autorun of various testing libraries
Upstream URL: https://github.com/cucumber/multi_test
Owners: jstribny
Branches:
InitialCC:

Comment 4 Kevin Fenzi 2014-06-18 16:35:31 UTC
Git done (by process-git-requests).


Note You need to log in before you can comment on or make changes to this bug.