Bug 1111020 - Unused code changelog_entry_length
Summary: Unused code changelog_entry_length
Keywords:
Status: CLOSED EOL
Alias: None
Product: GlusterFS
Classification: Community
Component: core
Version: 3.5.0
Hardware: All
OS: All
unspecified
low
Target Milestone: ---
Assignee: Keith Schincke
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-06-19 04:53 UTC by Keith Schincke
Modified: 2016-06-17 16:24 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2016-06-17 16:24:39 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Keith Schincke 2014-06-19 04:53:24 UTC
Description of problem:
The function changelog_helpers.c:changelog_entry_length() is defined but unused. 

This function is defined here:
https://github.com/gluster/glusterfs/blame/d2db585ce7e26851178104433fa9422482d8719e/xlators/features/changelog/src/changelog-helpers.h#L388

and implemented here
https://github.com/gluster/glusterfs/blame/d2db585ce7e26851178104433fa9422482d8719e/xlators/features/changelog/src/changelog-helpers.c#L382

The changelog_log_data_t structure contains a pointer to an iobuf structure. 

This function is not used and returns incomplete data

Version-Release number of selected component (if applicable):
3.5

How reproducible:
Code review

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2014-06-19 05:09:34 UTC
REVIEW: http://review.gluster.org/8107 (Removal of unused code changelog_entry_length BUG 1111020) posted (#1) for review on master by Keith Schincke (kschinck)

Comment 2 Mike McCune 2016-03-28 22:53:35 UTC
This bug was accidentally moved from POST to MODIFIED via an error in automation, please see mmccune with any questions

Comment 3 Niels de Vos 2016-06-17 16:24:39 UTC
This bug is getting closed because the 3.5 is marked End-Of-Life. There will be no further updates to this version. Please open a new bug against a version that still receives bugfixes if you are still facing this issue in a more current release.


Note You need to log in before you can comment on or make changes to this bug.