Bug 1111136 - Tabs panel backgorund is completely transparent when transparency is turned on.
Summary: Tabs panel backgorund is completely transparent when transparency is turned on.
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: gnome-terminal
Version: 20
Hardware: x86_64
OS: Linux
unspecified
low
Target Milestone: ---
Assignee: Debarshi Ray
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-06-19 10:35 UTC by jowil
Modified: 2015-04-07 17:06 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2015-04-07 17:06:34 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
A screenshot illustrating the described problem. (12.52 KB, image/png)
2014-06-19 10:35 UTC, jowil
no flags Details
Transparency for gnome-terminal 3.13 (18.85 KB, patch)
2014-09-02 10:34 UTC, Egmont Koblinger
no flags Details | Diff

Description jowil 2014-06-19 10:35:44 UTC
Created attachment 910342 [details]
A screenshot illustrating the described problem.

Description of problem:
Tabs panel backgorund becomes 100% transparent when transparency is turned on regardless of the transparency level.

Version-Release number of selected component (if applicable):
GNOME Terminal 3.10.2

How reproducible:
Always

Steps to Reproduce:
1. Open GNOME Terminal profile preferences.
2. Go to the "Colors" tab.
3. Check "Use transparent background".
4. Go back to the terminal and open a new tab.

Actual results:
Background of the tabs panel is completely transparent.

Expected results:
Background of the tabs panel stays opaque.

Additional info:
A screenshot attached.

Comment 1 Egmont Koblinger 2014-06-19 15:24:31 UTC
Debarshi, could you please take care of this one?

This is just a friendly reminder, since we've already talked about this and you're aware of the issue.

The bug caused by the bits that are unfortunately missing from your transparency patch (the gtk_render_{background,frame} calls), and were added by Ubuntu developer Lars. Could you please review and apply his patch? Thanks!

Note: even if the Adwaita theme is "fixed" in rawhide, g-t without Lars's fixes will be broken with other themes. It's better to fix it in g-t so that it works with any theme.

Comment 2 Rodd Clarkson 2014-09-02 03:26:14 UTC
I'm seeing this too.  I could attach another screenshot, but it looks like the screen shot that's already in the bug.

I'm using gnome-terminal 3.10.2

Comment 3 Egmont Koblinger 2014-09-02 10:33:28 UTC
For reference, the detailed full story is:

1. Debarshi from Fedora created the initial transparency patch and released it as an update to Fedora 20. He did a great work, but unfortunately he did not address one issue which leads to this bug.

2. Lars from Ubuntu took Debarshi's patch and fixed this particular issue. See his patch at https://bazaar.launchpad.net/~larsu/gnome-terminal/update-restore-transparency-patch/revision/126?start_revid=126

3. I took Lars's patch and updated it to gnome-terminal 3.13 which is shipped by Rawhide (future Fedora 21) and does not have any transparency at this moment. I sent this patch to Debarshi. Now I attach it here so everyone can see.

Unfortunately it seems that Debarshi didn't have time to review Lars's/my work, but let's hope he gets to this at some point. Ideally, F20 should be updated to use the patch from [2], and Rawhide/F21 should receive the patch from [3].

Comment 4 Egmont Koblinger 2014-09-02 10:34:30 UTC
Created attachment 933688 [details]
Transparency for gnome-terminal 3.13

Comment 5 João Carlos Mendes Luís 2015-03-27 15:21:17 UTC
This bug affects also the menu bar.

To make things more strange, this bug does not always happen.  I usually can run gnome-terminal for days without problem, and suddenly the menu bar becomes 100% transparent.

As a work-around, sometimes I just need to start a new gnome-terminal window, and all existing windows are fixed!

If this is already fixed in FC21, please back-port it to FC20.

Comment 6 João Carlos Mendes Luís 2015-03-27 21:09:51 UTC
(In reply to João Carlos Mendes Luís from comment #5)
> As a work-around, sometimes I just need to start a new gnome-terminal
> window, and all existing windows are fixed!

My mistake, the workaround does not work!  Not even killing the main process, gnome-terminal-server works.

Comment 7 Debarshi Ray 2015-04-07 09:39:50 UTC
Are you using a theme other than Adwaita?

Comment 8 João Carlos Mendes Luís 2015-04-07 14:13:15 UTC
I was using ClearLooks.

Changing it to Adwaita made the menu bar opaque again, at least for now.

I did try some other themes, like ContrastHigh, Crux, Glider, Glossy, Industrial, Murrina*, Raleigh, SImple, and all these made the menu bar transparent.

Some other kept the menu bar opaque: Albatroz, BlackMATE, Bluebird, BlueMenta, GreeLaguna, GreyBird, Traditional*, xfce* (except xfce-basic)...

Is this a known "feature"?

Comment 9 Debarshi Ray 2015-04-07 17:06:34 UTC
(In reply to João Carlos Mendes Luís from comment #8)
> I was using ClearLooks.
> 
> Changing it to Adwaita made the menu bar opaque again, at least for now.

Then this is, indeed, the same issue that Egmont mentioned in comment 1

> I did try some other themes, like ContrastHigh, Crux, Glider, Glossy,
> Industrial, Murrina*, Raleigh, SImple, and all these made the menu bar
> transparent.
> 
> Some other kept the menu bar opaque: Albatroz, BlackMATE, Bluebird,
> BlueMenta, GreeLaguna, GreyBird, Traditional*, xfce* (except xfce-basic)...
> 
> Is this a known "feature"?

No, it is a "bug" in the interaction between the theme and the transparency patch in gnome-terminal. This has since been worked around in gnome-terminal in Fedora 21.

I am hesitant to issue a new gnome-terminal update just to fix this issue in Fedora 20. I don't want to bother users with an update to fix a bug with a theme that is not adwaita [*] (who knows how many bugs are there in other applications), in a release that is as old as Fedora 20, for a feature that wasn't even part of the original release and was backported as a courtesy, and is so fringe as transparent terminals.

[*] GNOME doesn't let you change the theme unless you lift the hood and start tweaking things.


Note You need to log in before you can comment on or make changes to this bug.