Bug 1111143 - dnssec-trigger-script: offer a seamless upgrade from pre-0.12 (without unbound restart)
Summary: dnssec-trigger-script: offer a seamless upgrade from pre-0.12 (without unboun...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: dnssec-trigger
Version: 20
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Pavel Šimerda (pavlix)
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-06-19 10:59 UTC by Pavel Šimerda (pavlix)
Modified: 2014-09-19 10:07 UTC (History)
4 users (show)

Fixed In Version: dnssec-trigger-0.12-13.fc20
Clone Of:
Environment:
Last Closed: 2014-09-19 10:07:00 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)
fix (1.43 KB, patch)
2014-06-19 14:32 UTC, Pavel Šimerda (pavlix)
no flags Details | Diff
additional fix to handle the legacy format in cleanup, not prepare (2.41 KB, patch)
2014-06-23 12:44 UTC, Pavel Šimerda (pavlix)
no flags Details | Diff

Description Pavel Šimerda (pavlix) 2014-06-19 10:59:52 UTC
The original script used a different /var/run/dnssec-trigger directory layout. The upgrade should translate the old layout to the new layout without the need to restart unbound. This is the last thing that needs to be done before an update for Fedora 20.

Comment 1 Pavel Šimerda (pavlix) 2014-06-19 14:32:37 UTC
Created attachment 910419 [details]
fix

Comment 2 Pavel Šimerda (pavlix) 2014-06-23 10:42:27 UTC
Fix doesn't work because it relies on dnssec-triggerd restart cleaning up correctly and then setting up the configuration again, which doesn't happen.

With dnssec-trigger-0.12-6.fc20, the following happens...

systemctl stop dnssec-triggerd:

 * remove all connection configuration from unbound
 * perform /etc/resolv.conf cleanup actions

systemctl start dnssec-triggerd:

 * convert format of the zones store
 * perform /etc/resolv.conf prepare actions

I identified the following problems:

1) when upgrading, the cleanup code run at 'stop' still works with the old format

2) the newly started instance doesn't run dnssec-trigger-script --update which is necessary to set up initial configuration

Comment 3 Pavel Šimerda (pavlix) 2014-06-23 10:46:51 UTC
(In reply to Pavel Šimerda (pavlix) from comment #2)
> 1) when upgrading, the cleanup code run at 'stop' still works with the old
> format

This could be fixed by moving the conversion to the cleanup phase instead of the prepare phase. Thus the new package would provide a proper cleanup for the old data as well.

> 2) the newly started instance doesn't run dnssec-trigger-script --update
> which is necessary to set up initial configuration

This is a separate issue that needs to be solved regardless.

Comment 4 Pavel Šimerda (pavlix) 2014-06-23 12:44:58 UTC
Created attachment 911414 [details]
additional fix to handle the legacy format in cleanup, not prepare

Comment 5 Pavel Šimerda (pavlix) 2014-06-23 14:21:14 UTC
(In reply to Pavel Šimerda (pavlix) from comment #3)
> (In reply to Pavel Šimerda (pavlix) from comment #2)
> > 1) when upgrading, the cleanup code run at 'stop' still works with the old
> > format
> 
> This could be fixed by moving the conversion to the cleanup phase instead of
> the prepare phase. Thus the new package would provide a proper cleanup for
> the old data as well.

Fixed.

> > 2) the newly started instance doesn't run dnssec-trigger-script --update
> > which is necessary to set up initial configuration
> 
> This is a separate issue that needs to be solved regardless.

In fact it did run it, but it failed. Filed as bug #1112248.

Comment 6 Fedora Update System 2014-06-30 15:30:02 UTC
dnssec-trigger-0.12-12.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/dnssec-trigger-0.12-12.fc20

Comment 7 Fedora Update System 2014-07-01 07:21:42 UTC
Package dnssec-trigger-0.12-12.fc20:
* should fix your issue,
* was pushed to the Fedora 20 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing dnssec-trigger-0.12-12.fc20'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-7942/dnssec-trigger-0.12-12.fc20
then log in and leave karma (feedback).

Comment 8 Fedora Update System 2014-08-11 11:40:40 UTC
dnssec-trigger-0.12-13.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/dnssec-trigger-0.12-13.fc20

Comment 9 Fedora Update System 2014-09-19 10:07:00 UTC
dnssec-trigger-0.12-13.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.