Spec URL: https://mega.co.nz/#!bcYkXJCb!Md4QSRvSyqmeJXsBViVDPDNxgignI4_XbynXNb2pw6I SRPM URL: https://mega.co.nz/#!6ZwVgBbT!tnRLGrAKrRTFMOz7YE24f0FEpyCowzWbAzShCi0G8Mc Description: mimetic is an Email library (MIME) written in C++ designed to be easy to use and integrate but yet fast and efficient. It has been built around the standard lib. This means that you'll not find yet another string class or list implementation and that you'll feel comfortable in using this library from the very first time. Most classes functionalities and behavior will be clear if you ever studied MIME and its components; if you don't know anything about Internet messages you'll probably want to read some RFCs to understand the topic and, therefore, easily use the library whose names, whenever possible, overlap terms adopted in the standard RFC documents. At the very least: RFC 822, RFC 2045 and RFC 2046. Fedora Account System Username: cicku
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 2488320 bytes in 265 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated". 134 files have unknown license. Detailed output of licensecheck in /home/yarda/git-fedora/mimetic/review- mimetic/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file Note: Found : Packager: Jaroslav Škarvada <jskarvad> See: http://fedoraproject.org/wiki/Packaging:Guidelines#Tags False positive. [x]: Uses parallel make %{?_smp_mflags} macro. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. Not tested. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Scriptlets must be sane, if used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 2641920 bytes in /usr/share See notes bellow. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: mimetic-0.9.8-1.fc20.x86_64.rpm mimetic-devel-0.9.8-1.fc20.x86_64.rpm mimetic-0.9.8-1.fc20.src.rpm mimetic.x86_64: W: spelling-error %description -l en_US functionalities -> functionalists, functionality, functionalist mimetic.src: W: spelling-error %description -l en_US functionalities -> functionalists, functionality, functionalist 3 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint mimetic mimetic-devel mimetic.x86_64: W: spelling-error %description -l en_US functionalities -> functionalists, functionality, functionalist 2 packages and 0 specfiles checked; 0 errors, 1 warnings. # echo 'rpmlint-done:' Requires -------- mimetic (rpmlib, GLIBC filtered): /sbin/ldconfig libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libm.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) mimetic-devel (rpmlib, GLIBC filtered): libmimetic.so.0()(64bit) mimetic(x86-64) Provides -------- mimetic: libmimetic.so.0()(64bit) mimetic mimetic(x86-64) mimetic-devel: mimetic-devel mimetic-devel(x86-64) Source checksums ---------------- http://www.codesink.org/download/mimetic-0.9.8.tar.gz : CHECKSUM(SHA256) this package : 3a07d68d125f5e132949b078c7275d5eb0078dd649079bd510dd12b969096700 CHECKSUM(SHA256) upstream package : 3a07d68d125f5e132949b078c7275d5eb0078dd649079bd510dd12b969096700 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -n mimetic Buildroot used: fedora-20-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG Review ------ - Consider splitting the devel subpackage into noarch doc subpackage, the docs itself are about 2.8 MB, I think it's worth splitting.
Sure, will do that before SCM. Thanks! New Package SCM Request ======================= Package Name: mimetic Short Description: A full featured C++ MIME library Owners: cicku Branches: f19 f20
No upstream URL.
Just realized that this package used to be a part of Fedora, and I need to file ticket at rel-eng, too. New Package SCM Request ======================= Package Name: mimetic Short Description: A full featured C++ MIME library Upstream URL: http://www.codesink.org/mimetic_mime_library.html Owners: cicku Branches: f19 f20
Git done (by process-git-requests).
(In reply to Jon Ciesla from comment #5) > Git done (by process-git-requests). This did not create a f20 branch in pkgdb/git. Also the permissions in pkgdb seemed to be odd (no approveacls acl was set for cicku on master, also no watchbugzilla/watchcommits). I hope I fixed everything now.
mimetic-0.9.8-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/mimetic-0.9.8-1.fc20
mimetic-0.9.8-1.fc20 has been pushed to the Fedora 20 testing repository.
mimetic-0.9.8-1.fc20 has been pushed to the Fedora 20 stable repository.