Spec URL: http://jplesnik.fedorapeople.org/perl-App-a2p/perl-App-a2p.spec SRPM URL: http://jplesnik.fedorapeople.org/perl-App-a2p/perl-App-a2p-1.007-1.fc21.src.rpm Description: This package delivers a2p tool which takes an awk script specified on the command line and produces a comparable Perl script. Fedora Account System Username: jplesnik The package will replace a2p script provided by perl.
I would change the package group to Development/Tools. The package should conflict with perl < 4:5.18.2-300. The files were sub-packaged from perl.spec in perl-5.18.2-300.fc21.
Updated. Links are the same.
URL and Source0 are usable. Ok. Source archive is original (SHA-256: a3a67a82148f48402fef6372711dbea68b87ee902288c5d77d7393002953574a). Ok Summary verified from lib/App/a2p.pm. Ok. Description verified from lib/App/a2p.pm. Ok. License verified from README, a2p.c, hash.c, LICENSE, str.c, util.c, and other header files. Ok. TODO: Use %{_bindir} in `/usr/bin/awk' build-require. You never know when Fedora changes the directory layout. TODO: Constrain `perl(ExtUtils::MakeMaker)' build-require with `>= 6.30' (Makefile.PL:11). TODO: Remove the alarm call from t/10-basics.t. Current code will fail test tests if the code will run for more than 5 seconds. This is not much portable test. TODO: Do not build-require /usr/bin/awk. I cannot see where the awk is called. pelling-error %description -l en_US awk -> awl, aw, wk perl-App-a2p.src: W: invalid-url URL: http://search.cpan.org/dist/App-a2p/ timed out perl-App-a2p.x86_64: W: spelling-error Summary(en_US) Awk -> Wk, Ark, A wk perl-App-a2p.x86_64: W: spelling-error %description -l en_US awk -> awl, aw, wk perl-App-a2p.x86_64: W: incoherent-version-in-changelog 0:1.007-1 ['1.007-1.fc21', '1.007-1'] perl-App-a2p.x86_64: W: invalid-url URL: http://search.cpan.org/dist/App-a2p/ HTTP Error 503: Service Unavailable perl-App-a2p-debuginfo.x86_64: W: invalid-url URL: http://search.cpan.org/dist/App-a2p/ timed out 3 packages and 1 specfiles checked; 0 errors, 8 warnings. TODO: Remove the epoch prefix from the changelog entry. $ rpm -qlvp ../RPMS/x86_64/perl-App-a2p-1.007-1.fc21.x86_64.rpm -rwxr-xr-x 1 root root 108144 Jun 23 16:03 /usr/bin/a2p drwxr-xr-x 2 root root 0 Jun 23 16:03 /usr/share/doc/perl-App-a2p -rw-r--r-- 1 root root 1053 May 29 16:36 /usr/share/doc/perl-App-a2p/Changes -rw-r--r-- 1 root root 18355 May 29 16:36 /usr/share/doc/perl-App-a2p/LICENSE -rw-r--r-- 1 root root 356 May 29 16:36 /usr/share/doc/perl-App-a2p/README -rw-r--r-- 1 root root 4699 Jun 23 16:03 /usr/share/man/man1/a2p.1.gz drwxr-xr-x 2 root root 0 Jun 23 16:03 /usr/share/perl5/vendor_perl/App -rw-r--r-- 1 root root 6149 May 29 16:36 /usr/share/perl5/vendor_perl/App/a2p.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-App-a2p-1.007-1.fc21.x86_64.rpm | sort -f | uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.14)(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.3.4)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 perl(:MODULE_COMPAT_5.18.2) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -q --provides -p ../RPMS/x86_64/perl-App-a2p-1.007-1.fc21.x86_64.rpm | sort -f | uniq -c 1 perl(App::a2p) = 1.007 1 perl-App-a2p = 1.007-1.fc21 1 perl-App-a2p(x86-64) = 1.007-1.fc21 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/perl-App-a2p-1.007-1.fc21.x86_64.rpm Binary dependencies resolvable. Ok. Package builds in F21 (http://koji.fedoraproject.org/koji/taskinfo?taskID=7068224). Ok. Package is in line with Fedora and Perl packaging guidelines. Please consider the `TODO' items before building this package. Resolution: APPROVED.
New Package SCM Request ======================= Package Name: perl-App-a2p Short Description: Awk to Perl translator Upstream URL: http://search.cpan.org/dist/App-a2p/ Owners: jplesnik ppisar psabata Branches: InitialCC: perl-sig
Git done (by process-git-requests).
Thank you for the review and the repository.