Red Hat Satellite engineering is moving the tracking of its product development work on Satellite to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "Satellite project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs will be migrated starting at the end of May. If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "Satellite project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/SAT-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1111355 - Confusing label "Enabled by Default" in Activation key - Product Content tab
Summary: Confusing label "Enabled by Default" in Activation key - Product Content tab
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat Satellite
Classification: Red Hat
Component: Subscription Management
Version: 6.0.3
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: Unspecified
Assignee: Tom McKay
QA Contact: sthirugn@redhat.com
URL: http://projects.theforeman.org/issues...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2014-06-19 20:12 UTC by sthirugn@redhat.com
Modified: 2019-09-26 18:12 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Clone Of:
Environment:
Last Closed: 2014-09-11 12:24:05 UTC
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Foreman Issue Tracker 6740 0 Normal Closed Confusing label "Enabled by Default" in Activation key - Product Content tab 2021-02-03 13:14:55 UTC

Description sthirugn@redhat.com 2014-06-19 20:12:47 UTC 
Description of problem:
Confusing label "Enabled by Default" in Activation key - Product Content tab

Version-Release number of selected component (if applicable):
* apr-util-ldap-1.3.9-3.el6_0.1.x86_64
* candlepin-0.9.19-1.el6_5.noarch
* candlepin-scl-1-5.el6_4.noarch
* candlepin-scl-quartz-2.1.5-5.el6_4.noarch
* candlepin-scl-rhino-1.7R3-1.el6_4.noarch
* candlepin-scl-runtime-1-5.el6_4.noarch
* candlepin-selinux-0.9.19-1.el6_5.noarch
* candlepin-tomcat6-0.9.19-1.el6_5.noarch
* elasticsearch-0.90.10-4.el6sat.noarch
* foreman-1.6.0.18-1.el6sat.noarch
* foreman-compute-1.6.0.18-1.el6sat.noarch
* foreman-gce-1.6.0.18-1.el6sat.noarch
* foreman-libvirt-1.6.0.18-1.el6sat.noarch
* foreman-ovirt-1.6.0.18-1.el6sat.noarch
* foreman-postgresql-1.6.0.18-1.el6sat.noarch
* foreman-proxy-1.6.0.8-1.el6sat.noarch
* foreman-selinux-1.6.0-4.el6sat.noarch
* foreman-vmware-1.6.0.18-1.el6sat.noarch
* katello-1.5.0-26.el6sat.noarch
* katello-ca-1.0-1.noarch
* katello-certs-tools-1.5.5-1.el6sat.noarch
* katello-installer-0.0.49-1.el6sat.noarch
* openldap-2.4.23-32.el6_4.1.x86_64
* openldap-devel-2.4.23-32.el6_4.1.x86_64
* pulp-katello-0.3-3.el6sat.noarch
* pulp-nodes-common-2.4.0-0.21.beta.el6sat.noarch
* pulp-nodes-parent-2.4.0-0.21.beta.el6sat.noarch
* pulp-puppet-plugins-2.4.0-0.21.beta.el6sat.noarch
* pulp-puppet-tools-2.4.0-0.21.beta.el6sat.noarch
* pulp-rpm-plugins-2.4.0-0.21.beta.el6sat.noarch
* pulp-selinux-2.4.0-0.21.beta.el6sat.noarch
* pulp-server-2.4.0-0.21.beta.el6sat.noarch
* python-ldap-2.3.10-1.el6.x86_64
* ruby193-rubygem-net-ldap-0.3.1-3.el6sat.noarch
* ruby193-rubygem-runcible-1.1.0-2.el6sat.noarch

How reproducible:
Always

Steps to Reproduce:
1. Upload a manifest
2. Create an activation key and add subscriptions
3. Navigate to activation key -> Product Content tab

Actual results:
The label "Enabled by Default" is confusing in this context.

Example:
Red Hat Enterprise Linux 6 Server (Kickstart) - Enabled by Default - Defaults to No

Expected results:
The label can be changed to "Enabled?" to make more sense in this context.

Example:
Red Hat Enterprise Linux 6 Server (Kickstart) - Enabled? - Defaults to No

Additional info:
Comment 2 Erik M Jacobs 2014-07-22 14:30:45 UTC 
Some thoughts/suggestions:

1) It's not clear that the bold items are products. I'm not sure how to improve that.

2) The label itself should be right-justified to be closer to the setting/value. The edit icon is also really far away from the field. Some CSS-fixing could be used here.

3) For the label:
Enabled by Default -> Enabled/Disabled?

4) For the picker/dropdown:
XXXX (Default)
Enable
Disable

In other words, have an option for the default that indicates which value (Enable/Disable) is the default, and then let people manually select one or the other.
Comment 3 Erik M Jacobs 2014-07-22 14:33:31 UTC 
Also, I noticed that we are using invalid HTML, or, at least, not semantically-correct HTML.

As an example:

<div class="col-md-11 col-md-offset-1 ng-scope" ng-repeat="content in product.available_content">
<h4>
<div class="detail row">
<span class="col-sm-4 ng-scope">Enabled by Default</span>
<form class="col-sm-3 ng-isolate-scope ng-pristine ng-valid" role="form" on-save="saveContentOverride(content)" options="overrideEnableChoices(content)" selector="content.overrideEnabled" readonly="readonly" alch-edit-select="content.enabledText">
<div class="form-group ng-hide" ng-show="editMode">
<div class="alch-edit" alch-edit="">
</form>
</div>
</div>

Note that the "label", "Enabled by Default", is a span element, and not an HTML <label>.

Further, the span is currently outside of the form.

We should probably be using <labels> with the correct "for" attribute and be placing them inside the form, to be semantically HTML valid.
Comment 4 Tom McKay 2014-07-23 00:05:03 UTC 
Created redmine issue http://projects.theforeman.org/issues/6740 from this bug
Comment 5 Bryan Kearney 2014-07-24 14:03:14 UTC 
Moving to POST since upstream bug http://projects.theforeman.org/issues/6740 has been closed
-------------
Thomas McKay
Applied in changeset commit:katello|c9f6b20556bd294cc1363f1462e55f7cbc616867.
Comment 7 sthirugn@redhat.com 2014-07-30 19:39:57 UTC 
Verified.

Now I see:
Enabled? Override to Yes

Version Tested:
Satellite-6.0.4-RHEL-6-20140730.0

* apr-util-ldap-1.3.9-3.el6_0.1.x86_64
* candlepin-0.9.19-1.el6_5.noarch
* candlepin-scl-1-5.el6_4.noarch
* candlepin-scl-quartz-2.1.5-5.el6_4.noarch
* candlepin-scl-rhino-1.7R3-1.el6_4.noarch
* candlepin-scl-runtime-1-5.el6_4.noarch
* candlepin-selinux-0.9.19-1.el6_5.noarch
* candlepin-tomcat6-0.9.19-1.el6_5.noarch
* elasticsearch-0.90.10-4.el6sat.noarch
* foreman-1.6.0.34-1.el6sat.noarch
* foreman-compute-1.6.0.34-1.el6sat.noarch
* foreman-gce-1.6.0.34-1.el6sat.noarch
* foreman-libvirt-1.6.0.34-1.el6sat.noarch
* foreman-ovirt-1.6.0.34-1.el6sat.noarch
* foreman-postgresql-1.6.0.34-1.el6sat.noarch
* foreman-proxy-1.6.0.23-1.el6sat.noarch
* foreman-selinux-1.6.0.4-1.el6sat.noarch
* foreman-vmware-1.6.0.34-1.el6sat.noarch
* katello-1.5.0-27.el6sat.noarch
* katello-ca-1.0-1.noarch
* katello-certs-tools-1.5.6-1.el6sat.noarch
* katello-installer-0.0.56-1.el6sat.noarch
* openldap-2.4.23-34.el6_5.1.x86_64
* pulp-katello-0.3-3.el6sat.noarch
* pulp-nodes-common-2.4.0-0.23.beta.el6sat.noarch
* pulp-nodes-parent-2.4.0-0.23.beta.el6sat.noarch
* pulp-puppet-plugins-2.4.0-0.23.beta.el6sat.noarch
* pulp-puppet-tools-2.4.0-0.23.beta.el6sat.noarch
* pulp-rpm-plugins-2.4.0-0.23.beta.el6sat.noarch
* pulp-selinux-2.4.0-0.23.beta.el6sat.noarch
* pulp-server-2.4.0-0.23.beta.el6sat.noarch
* python-ldap-2.3.10-1.el6.x86_64
* ruby193-rubygem-net-ldap-0.3.1-3.el6sat.noarch
* ruby193-rubygem-runcible-1.1.0-2.el6sat.noarch
* sssd-ldap-1.11.5.1-3.el6.x86_64
Comment 8 sthirugn@redhat.com 2014-07-30 19:41:26 UTC 
Erik Jacobs:
The original issue mentioned in this bug is now fixed in Satellite-6.0.4-RHEL-6-20140730.0.  Can you please create a new bug for your Comment 2 and Comment 3 above?
Comment 10 Bryan Kearney 2014-09-11 12:24:05 UTC 
This was delivered with Satellite 6.0 which was released on 10 September 2014.
Note You need to log in before you can comment on or make changes to this bug.