Spec URL: http://mcepl.fedorapeople.org/tmp//python-parse_type.spec SRPM URL: http://mcepl.fedorapeople.org/tmp//python-parse_type-0.3.4-1.el7.src.rpm Description: `parse_type`_ extends the `parse`_ module (opposite of `string.format()`_) with the following features: * build type converters for common use cases (enum/mapping, choice) * build a type converter with a cardinality constraint (0..1, 0..*, 1..*) from the type converter with cardinality=1. * compose a type converter from other type converters * an extended parser that supports the CardinalityField naming schema and creates missing type variants (0..1, 0..*, 1..*) from the primary type converter
Scratch build is http://koji.fedoraproject.org/koji/taskinfo?taskID=7059925
Package Review ============== Legend: [x] = Pass [!] = Fail [-] = Not applicable [?] = Not evaluated ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT/X11 (BSD like)", "Unknown or generated". 44 files have unknown license. Detailed output of licensecheck in /home/besser82/shared/fedora/review/1111360-python- parse_type/licensecheck.txt ---> LICENSE in tarball says "BSD 3-clause", the only hint of a license in the source-files says "MIT". This is case of need for license-clarification. https://fedoraproject.org/wiki/Packaging:LicensingGuidelines?rd=Packaging/LicensingGuidelines#License_Clarification [-]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib/python3.4/site-packages, /usr/lib/python3.4 ---> properly owned by python3 on fc21. [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.4/site-packages, /usr/lib/python3.4 ---> properly owned by python3 on fc21. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 40960 bytes in 4 files. [!]: Package complies to the Packaging Guidelines ---> unclarified licensing… [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in python3-parse_type ---> false positive. python3-pkg is meant to be used standalone with Python3. [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Patches link to upstream bugs/comments/lists or are otherwise justified. ---> one patch present, but only needed to remove obsolete dependencies when running the testsuite. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. ---> pkg is noarch and built fine on koji. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python-parse_type-0.3.4-1.fc21.noarch.rpm python3-parse_type-0.3.4-1.fc21.noarch.rpm python-parse_type-0.3.4-1.fc21.src.rpm python-parse_type.noarch: W: spelling-error %description -l en_US enum -> menu, en um, en-um python-parse_type.noarch: W: spelling-error %description -l en_US cardinality -> carnality, cardinal python3-parse_type.noarch: W: spelling-error %description -l en_US enum -> menu, en um, en-um python3-parse_type.noarch: W: spelling-error %description -l en_US cardinality -> carnality, cardinal python3-parse_type.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/parse_type/__pycache__/cfparse.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python3-parse_type.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/parse_type/__pycache__/builder.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python3-parse_type.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/parse_type/__pycache__/builder.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python3-parse_type.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/parse_type/__pycache__/cardinality_field.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python3-parse_type.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/parse_type/__pycache__/cardinality_field.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python3-parse_type.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/_paver_ext/__pycache__/paver_consume_args.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python3-parse_type.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/_paver_ext/__pycache__/paver_consume_args.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python3-parse_type.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/_paver_ext/__pycache__/paver_require.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python3-parse_type.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/_paver_ext/__pycache__/paver_require.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python3-parse_type.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/_paver_ext/__pycache__/pip_download.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python3-parse_type.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/_paver_ext/__pycache__/python_checker.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python3-parse_type.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/parse_type/__pycache__/parse_util.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python3-parse_type.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/_paver_ext/__pycache__/python_checker.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python3-parse_type.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/parse_type/__pycache__/parse_util.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python3-parse_type.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/_paver_ext/__pycache__/pip_download.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python3-parse_type.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/_paver_ext/__pycache__/paver_patch.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python3-parse_type.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/_paver_ext/__pycache__/__init__.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python3-parse_type.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/_paver_ext/__pycache__/paver_patch.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python3-parse_type.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/_paver_ext/__pycache__/__init__.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python3-parse_type.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/parse_type/__pycache__/parse.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python3-parse_type.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/parse_type/__pycache__/cfparse.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python3-parse_type.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/parse_type/__pycache__/cardinality.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python3-parse_type.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/parse_type/__pycache__/cardinality.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python3-parse_type.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/_paver_ext/__pycache__/python_bundle.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python3-parse_type.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/_paver_ext/__pycache__/python_requirements.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python3-parse_type.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/parse_type/__pycache__/__init__.cpython-34.pyo expected 3260 (3.4), found 3310 (unknown) python3-parse_type.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/parse_type/__pycache__/__init__.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python3-parse_type.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/_paver_ext/__pycache__/python_bundle.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python3-parse_type.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/_paver_ext/__pycache__/python_requirements.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python3-parse_type.noarch: E: python-bytecode-wrong-magic-value /usr/lib/python3.4/site-packages/parse_type/__pycache__/parse.cpython-34.pyc expected 3260 (3.4), found 3310 (unknown) python-parse_type.src: W: spelling-error %description -l en_US enum -> menu, en um, en-um python-parse_type.src: W: spelling-error %description -l en_US cardinality -> carnality, cardinal 3 packages and 0 specfiles checked; 30 errors, 6 warnings. ---> bug in rpmlint. Rpmlint (installed packages) ---------------------------- # rpmlint python3-parse_type python-parse_type python3-parse_type.noarch: W: spelling-error %description -l en_US enum -> menu, en um, en-um python3-parse_type.noarch: W: spelling-error %description -l en_US cardinality -> carnality, cardinal python-parse_type.noarch: W: spelling-error %description -l en_US enum -> menu, en um, en-um python-parse_type.noarch: W: spelling-error %description -l en_US cardinality -> carnality, cardinal 2 packages and 0 specfiles checked; 0 errors, 4 warnings. # echo 'rpmlint-done:' ---> spelling errors ignored. Requires -------- python3-parse_type (rpmlib, GLIBC filtered): python(abi) python3-enum34 python3-parse python3-six python-parse_type (rpmlib, GLIBC filtered): python(abi) python-enum34 python-parse python-six Provides -------- python3-parse_type: python3-parse_type python-parse_type: python-parse_type Source checksums ---------------- http://pypi.python.org/packages/source/p/parse_type/parse_type-0.3.4.tar.gz : CHECKSUM(SHA256) this package : 3dd0b323bafcb8c25e000ce5589042a1c99cba9c3bec77b9f591e46bc9606147 CHECKSUM(SHA256) upstream package : 3dd0b323bafcb8c25e000ce5589042a1c99cba9c3bec77b9f591e46bc9606147 Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1111360 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Java, C/C++, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG ===== Solution ===== NOT approved. Please clarify the correct license with the authors / maintainers of the software and I'll give it another run.
Created attachment 910723 [details] licensecheck.txt from fedora-review I attached the licensecheck for your convinience.
License issue filed upstream as https://github.com/jenisys/parse_type/issues/1
Bedides the unclarified license, there are no other issues. I watch the licensing issue filed with upstream on github. --------------------- Package approved !!!
New Package SCM Request ======================= Package Name: python-parse_type Short Description: Simplifies to build parse types based on the parse module Upstream URL: http://pypi.python.org/pypi/parse_type Owners: mcepl Branches: f19 f20 f21 el6 epel7
Git done (by process-git-requests).
Rawhide build http://koji.fedoraproject.org/koji/buildinfo?buildID=546202 License bug filed as bug 1121695 FTBFS on EPEL-{6,7} filed as bug 1121709 and bug 1121710