Spec URL: http://smani.fedorapeople.org/review/gmsh.spec SRPM URL: http://smani.fedorapeople.org/review/gmsh-2.8.4-2.fc21.src.rpm Description: A three-dimensional finite element mesh generator Fedora Account System Username: smani
Taken.
*** Bug 753577 has been marked as a duplicate of this bug. ***
Just a note: all dependencies for this are now built.
Oh yes. I did forget about this. Will review tonight.
The package mostly looks good. I have a few questions (below). Also, some of the rpmlint warnings are easy fixes, unused-shlib warnings, may be ... Please do take a look. I think it should be done next round. cheers! Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in gmsh-common See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1392640 bytes in 64 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL", "LGPL", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated", "MIT/X11 (BSD like)", "LGPL (with incorrect FSF address)", "LGPL (v2.1 or later)", "*No copyright* LGPL (v2.1 or later)", "GPL (v2)", "BSD (3 clause) LGPL (v2.1 or later)". 1480 files have unknown license. Detailed output of licensecheck in /home/mukundan/personal/pkgs/reviews/1111388-gmsh/licensecheck.txt ---> This looks fine to me. The files I checked refer to license.txt which is GPL2. [x]: License file installed when any subpackage combination is installed. [?]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/doc/gmsh ---> Please verify - just to be sure. [?]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/doc/gmsh [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gmsh-common , gmsh-libs , gmsh-devel , gmsh-openmpi , gmsh-openmpi-libs , gmsh- openmpi-devel , gmsh-mpich , gmsh-mpich-libs , gmsh-mpich-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [?]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments ---> Generation of tarball is documented. Is it a legal issue to even download the tarball and then get rid of mpeg in %prep instead of manual creation of the tarball? [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. ---> http://koji.fedoraproject.org/koji/taskinfo?taskID=7154865 [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gmsh-2.8.4-2.fc22.x86_64.rpm gmsh-common-2.8.4-2.fc22.noarch.rpm gmsh-libs-2.8.4-2.fc22.x86_64.rpm gmsh-demos-2.8.4-2.fc22.noarch.rpm gmsh-devel-2.8.4-2.fc22.x86_64.rpm gmsh-openmpi-2.8.4-2.fc22.x86_64.rpm gmsh-openmpi-libs-2.8.4-2.fc22.x86_64.rpm gmsh-openmpi-devel-2.8.4-2.fc22.x86_64.rpm gmsh-mpich-2.8.4-2.fc22.x86_64.rpm gmsh-mpich-libs-2.8.4-2.fc22.x86_64.rpm gmsh-mpich-devel-2.8.4-2.fc22.x86_64.rpm gmsh-2.8.4-2.fc22.src.rpm gmsh.x86_64: W: incoherent-version-in-changelog 2.8.3-2 ['2.8.4-2.fc22', '2.8.4-2'] gmsh.x86_64: W: no-documentation gmsh.x86_64: W: non-executable-in-bin /usr/bin/onelab.py 0644L gmsh.x86_64: E: script-without-shebang /usr/bin/onelab.py gmsh.x86_64: E: non-executable-script /usr/bin/onelab.py 0644L None gmsh.x86_64: W: no-manual-page-for-binary gmsh gmsh-common.noarch: W: desktopfile-without-binary /usr/share/applications/gmsh.desktop gmsh gmsh-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libGmsh.so.2.8.4 exit.5 gmsh-libs.x86_64: W: no-documentation gmsh-demos.noarch: W: file-not-utf8 /usr/share/doc/gmsh/tutorial/t12.geo gmsh-demos.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/gmsh/demos/component8.step gmsh-devel.x86_64: W: only-non-binary-in-usr-lib gmsh-devel.x86_64: W: no-documentation gmsh-openmpi.x86_64: W: summary-not-capitalized C gmsh compiled against openmpi gmsh-openmpi.x86_64: W: no-documentation gmsh-openmpi-libs.x86_64: W: summary-not-capitalized C gmsh libraries compiled against openmpi gmsh-openmpi-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/openmpi/lib/libGmsh.so.2.8.4 exit.5 gmsh-openmpi-libs.x86_64: W: no-documentation gmsh-openmpi-devel.x86_64: W: only-non-binary-in-usr-lib gmsh-openmpi-devel.x86_64: W: no-documentation gmsh-mpich.x86_64: W: summary-not-capitalized C gmsh compiled against mpich gmsh-mpich.x86_64: W: no-documentation gmsh-mpich-libs.x86_64: W: summary-not-capitalized C gmsh libraries compiled against mpich gmsh-mpich-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/mpich/lib/libGmsh.so.2.8.4 exit.5 gmsh-mpich-libs.x86_64: W: no-documentation gmsh-mpich-devel.x86_64: W: only-non-binary-in-usr-lib gmsh-mpich-devel.x86_64: W: no-documentation gmsh.src:162: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 162) gmsh.src: W: patch-not-applied Patch0: gmsh_unbundle.patch gmsh.src: W: patch-not-applied Patch1: gmsh_alglib.patch gmsh.src: W: patch-not-applied Patch2: gmsh_sign.patch gmsh.src: W: patch-not-applied Patch3: gmsh_tetgen.patch gmsh.src: W: patch-not-applied Patch4: gmsh_install-dirs.patch gmsh.src: W: invalid-url Source0: gmsh-2.8.4-source-fedora.tar.gz 12 packages and 0 specfiles checked; 2 errors, 32 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint gmsh-devel gmsh-mpich-libs gmsh-libs gmsh-demos gmsh-openmpi-devel gmsh-common gmsh-openmpi-libs gmsh-mpich gmsh-openmpi gmsh gmsh-mpich-devel gmsh-devel.x86_64: W: only-non-binary-in-usr-lib gmsh-devel.x86_64: W: no-documentation gmsh-mpich-libs.x86_64: W: summary-not-capitalized C gmsh libraries compiled against mpich gmsh-mpich-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libGmsh.so.2.8.4 /lib64/liblbfgs.so.1 gmsh-mpich-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libGmsh.so.2.8.4 /usr/lib64/mpich/lib/libmpichcxx.so.12 gmsh-mpich-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libGmsh.so.2.8.4 /usr/lib64/mpich/lib/libopa.so.1 gmsh-mpich-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libGmsh.so.2.8.4 /usr/lib64/mpich/lib/libmpl.so.1 gmsh-mpich-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libGmsh.so.2.8.4 /lib64/librt.so.1 gmsh-mpich-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libGmsh.so.2.8.4 /lib64/libnglib.so.5 gmsh-mpich-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libGmsh.so.2.8.4 /lib64/libTKSTEP209.so.8 gmsh-mpich-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libGmsh.so.2.8.4 /lib64/libTKSTEPAttr.so.8 gmsh-mpich-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libGmsh.so.2.8.4 /lib64/libTKSTEPBase.so.8 gmsh-mpich-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libGmsh.so.2.8.4 /lib64/libTKHLR.so.8 gmsh-mpich-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libGmsh.so.2.8.4 /lib64/libTKAdvTools.so.8 gmsh-mpich-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libGmsh.so.2.8.4 /lib64/libdl.so.2 gmsh-mpich-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libGmsh.so.2.8.4 /lib64/libSM.so.6 gmsh-mpich-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libGmsh.so.2.8.4 /lib64/libICE.so.6 gmsh-mpich-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libGmsh.so.2.8.4 /lib64/libXext.so.6 gmsh-mpich-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/mpich/lib/libGmsh.so.2.8.4 exit.5 gmsh-mpich-libs.x86_64: W: no-documentation gmsh-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libGmsh.so.2.8.4 /lib64/liblbfgs.so.1 gmsh-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libGmsh.so.2.8.4 /lib64/libnglib.so.5 gmsh-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libGmsh.so.2.8.4 /lib64/libTKSTEP209.so.8 gmsh-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libGmsh.so.2.8.4 /lib64/libTKSTEPAttr.so.8 gmsh-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libGmsh.so.2.8.4 /lib64/libTKSTEPBase.so.8 gmsh-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libGmsh.so.2.8.4 /lib64/libTKHLR.so.8 gmsh-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libGmsh.so.2.8.4 /lib64/libTKAdvTools.so.8 gmsh-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libGmsh.so.2.8.4 /lib64/libdl.so.2 gmsh-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libGmsh.so.2.8.4 /lib64/libSM.so.6 gmsh-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libGmsh.so.2.8.4 /lib64/libICE.so.6 gmsh-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libGmsh.so.2.8.4 /lib64/libXext.so.6 gmsh-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libGmsh.so.2.8.4 exit.5 gmsh-libs.x86_64: W: no-documentation gmsh-demos.noarch: W: file-not-utf8 /usr/share/doc/gmsh/tutorial/t12.geo gmsh-demos.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/gmsh/demos/component8.step gmsh-openmpi-devel.x86_64: W: only-non-binary-in-usr-lib gmsh-openmpi-devel.x86_64: W: no-documentation gmsh-openmpi-libs.x86_64: W: summary-not-capitalized C gmsh libraries compiled against openmpi gmsh-openmpi-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/openmpi/lib/libGmsh.so.2.8.4 /lib64/liblbfgs.so.1 gmsh-openmpi-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/openmpi/lib/libGmsh.so.2.8.4 /lib64/libnglib.so.5 gmsh-openmpi-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/openmpi/lib/libGmsh.so.2.8.4 /lib64/libTKSTEP209.so.8 gmsh-openmpi-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/openmpi/lib/libGmsh.so.2.8.4 /lib64/libTKSTEPAttr.so.8 gmsh-openmpi-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/openmpi/lib/libGmsh.so.2.8.4 /lib64/libTKSTEPBase.so.8 gmsh-openmpi-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/openmpi/lib/libGmsh.so.2.8.4 /lib64/libTKHLR.so.8 gmsh-openmpi-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/openmpi/lib/libGmsh.so.2.8.4 /lib64/libTKAdvTools.so.8 gmsh-openmpi-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/openmpi/lib/libGmsh.so.2.8.4 /lib64/libdl.so.2 gmsh-openmpi-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/openmpi/lib/libGmsh.so.2.8.4 /lib64/libSM.so.6 gmsh-openmpi-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/openmpi/lib/libGmsh.so.2.8.4 /lib64/libICE.so.6 gmsh-openmpi-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/openmpi/lib/libGmsh.so.2.8.4 /lib64/libXext.so.6 gmsh-openmpi-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/openmpi/lib/libGmsh.so.2.8.4 exit.5 gmsh-openmpi-libs.x86_64: W: no-documentation gmsh-mpich.x86_64: W: summary-not-capitalized C gmsh compiled against mpich gmsh-mpich.x86_64: W: no-documentation gmsh-openmpi.x86_64: W: summary-not-capitalized C gmsh compiled against openmpi gmsh-openmpi.x86_64: W: no-documentation gmsh.x86_64: W: incoherent-version-in-changelog 2.8.3-2 ['2.8.4-2.fc22', '2.8.4-2'] gmsh.x86_64: W: no-documentation gmsh.x86_64: W: non-executable-in-bin /usr/bin/onelab.py 0644L gmsh.x86_64: E: script-without-shebang /usr/bin/onelab.py gmsh.x86_64: E: non-executable-script /usr/bin/onelab.py 0644L None gmsh.x86_64: W: no-manual-page-for-binary gmsh gmsh-mpich-devel.x86_64: W: only-non-binary-in-usr-lib gmsh-mpich-devel.x86_64: W: no-documentation 11 packages and 0 specfiles checked; 2 errors, 61 warnings. # echo 'rpmlint-done:' Requires -------- gmsh-devel (rpmlib, GLIBC filtered): gmsh-libs(x86-64) libGmsh.so.2.8()(64bit) gmsh-mpich-libs (rpmlib, GLIBC filtered): /sbin/ldconfig libANN.so.1()(64bit) libGL.so.1()(64bit) libGLU.so.1()(64bit) libICE.so.6()(64bit) libSM.so.6()(64bit) libTKAdvTools.so.8()(64bit) libTKBO.so.8()(64bit) libTKBRep.so.8()(64bit) libTKBool.so.8()(64bit) libTKFeat.so.8()(64bit) libTKFillet.so.8()(64bit) libTKG2d.so.8()(64bit) libTKG3d.so.8()(64bit) libTKGeomAlgo.so.8()(64bit) libTKGeomBase.so.8()(64bit) libTKHLR.so.8()(64bit) libTKIGES.so.8()(64bit) libTKMath.so.8()(64bit) libTKMesh.so.8()(64bit) libTKOffset.so.8()(64bit) libTKPrim.so.8()(64bit) libTKSTEP.so.8()(64bit) libTKSTEP209.so.8()(64bit) libTKSTEPAttr.so.8()(64bit) libTKSTEPBase.so.8()(64bit) libTKShHealing.so.8()(64bit) libTKTopAlgo.so.8()(64bit) libTKXSBase.so.8()(64bit) libTKernel.so.8()(64bit) libX11.so.6()(64bit) libXext.so.6()(64bit) libalglib.so.3()(64bit) libblas.so.3()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libfltk.so.1.3()(64bit) libfltk_gl.so.1.3()(64bit) libfltk_images.so.1.3()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libgmp.so.10()(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) liblapack.so.3()(64bit) liblbfgs.so.1()(64bit) libm.so.6()(64bit) libmathex.so.0()(64bit) libmmg3d4.so.4()(64bit) libmpich.so.12()(64bit) libmpichcxx.so.12()(64bit) libmpl.so.1()(64bit) libnglib.so.5()(64bit) libngmesh.so.0()(64bit) libngocc.so.0()(64bit) libopa.so.1()(64bit) libpng16.so.16()(64bit) libpng16.so.16(PNG16_0)(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libvoro++.so.0()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) gmsh-libs (rpmlib, GLIBC filtered): /sbin/ldconfig libANN.so.1()(64bit) libGL.so.1()(64bit) libGLU.so.1()(64bit) libICE.so.6()(64bit) libSM.so.6()(64bit) libTKAdvTools.so.8()(64bit) libTKBO.so.8()(64bit) libTKBRep.so.8()(64bit) libTKBool.so.8()(64bit) libTKFeat.so.8()(64bit) libTKFillet.so.8()(64bit) libTKG2d.so.8()(64bit) libTKG3d.so.8()(64bit) libTKGeomAlgo.so.8()(64bit) libTKGeomBase.so.8()(64bit) libTKHLR.so.8()(64bit) libTKIGES.so.8()(64bit) libTKMath.so.8()(64bit) libTKMesh.so.8()(64bit) libTKOffset.so.8()(64bit) libTKPrim.so.8()(64bit) libTKSTEP.so.8()(64bit) libTKSTEP209.so.8()(64bit) libTKSTEPAttr.so.8()(64bit) libTKSTEPBase.so.8()(64bit) libTKShHealing.so.8()(64bit) libTKTopAlgo.so.8()(64bit) libTKXSBase.so.8()(64bit) libTKernel.so.8()(64bit) libX11.so.6()(64bit) libXext.so.6()(64bit) libalglib.so.3()(64bit) libblas.so.3()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libfltk.so.1.3()(64bit) libfltk_gl.so.1.3()(64bit) libfltk_images.so.1.3()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libgmp.so.10()(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) liblapack.so.3()(64bit) liblbfgs.so.1()(64bit) libm.so.6()(64bit) libmathex.so.0()(64bit) libmmg3d4.so.4()(64bit) libnglib.so.5()(64bit) libngmesh.so.0()(64bit) libngocc.so.0()(64bit) libpng16.so.16()(64bit) libpng16.so.16(PNG16_0)(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libvoro++.so.0()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) gmsh-demos (rpmlib, GLIBC filtered): gmsh(x86-64) gmsh-devel(x86-64) gmsh-openmpi-devel (rpmlib, GLIBC filtered): gmsh-openmpi(x86-64) libGmsh.so.2.8()(64bit) openmpi-devel gmsh-common (rpmlib, GLIBC filtered): hicolor-icon-theme gmsh-openmpi-libs (rpmlib, GLIBC filtered): /sbin/ldconfig libANN.so.1()(64bit) libGL.so.1()(64bit) libGLU.so.1()(64bit) libICE.so.6()(64bit) libSM.so.6()(64bit) libTKAdvTools.so.8()(64bit) libTKBO.so.8()(64bit) libTKBRep.so.8()(64bit) libTKBool.so.8()(64bit) libTKFeat.so.8()(64bit) libTKFillet.so.8()(64bit) libTKG2d.so.8()(64bit) libTKG3d.so.8()(64bit) libTKGeomAlgo.so.8()(64bit) libTKGeomBase.so.8()(64bit) libTKHLR.so.8()(64bit) libTKIGES.so.8()(64bit) libTKMath.so.8()(64bit) libTKMesh.so.8()(64bit) libTKOffset.so.8()(64bit) libTKPrim.so.8()(64bit) libTKSTEP.so.8()(64bit) libTKSTEP209.so.8()(64bit) libTKSTEPAttr.so.8()(64bit) libTKSTEPBase.so.8()(64bit) libTKShHealing.so.8()(64bit) libTKTopAlgo.so.8()(64bit) libTKXSBase.so.8()(64bit) libTKernel.so.8()(64bit) libX11.so.6()(64bit) libXext.so.6()(64bit) libalglib.so.3()(64bit) libblas.so.3()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libfltk.so.1.3()(64bit) libfltk_gl.so.1.3()(64bit) libfltk_images.so.1.3()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libgmp.so.10()(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) liblapack.so.3()(64bit) liblbfgs.so.1()(64bit) libm.so.6()(64bit) libmathex.so.0()(64bit) libmmg3d4.so.4()(64bit) libmpi.so.1()(64bit) libmpi_cxx.so.1()(64bit) libnglib.so.5()(64bit) libngmesh.so.0()(64bit) libngocc.so.0()(64bit) libpng16.so.16()(64bit) libpng16.so.16(PNG16_0)(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libvoro++.so.0()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) gmsh-mpich (rpmlib, GLIBC filtered): gmsh-common gmsh-mpich-libs(x86-64) libANN.so.1()(64bit) libGL.so.1()(64bit) libGLU.so.1()(64bit) libGmsh.so.2.8()(64bit) libICE.so.6()(64bit) libSM.so.6()(64bit) libTKAdvTools.so.8()(64bit) libTKBO.so.8()(64bit) libTKBRep.so.8()(64bit) libTKBool.so.8()(64bit) libTKFeat.so.8()(64bit) libTKFillet.so.8()(64bit) libTKG2d.so.8()(64bit) libTKG3d.so.8()(64bit) libTKGeomAlgo.so.8()(64bit) libTKGeomBase.so.8()(64bit) libTKHLR.so.8()(64bit) libTKIGES.so.8()(64bit) libTKMath.so.8()(64bit) libTKMesh.so.8()(64bit) libTKOffset.so.8()(64bit) libTKPrim.so.8()(64bit) libTKSTEP.so.8()(64bit) libTKSTEP209.so.8()(64bit) libTKSTEPAttr.so.8()(64bit) libTKSTEPBase.so.8()(64bit) libTKShHealing.so.8()(64bit) libTKTopAlgo.so.8()(64bit) libTKXSBase.so.8()(64bit) libTKernel.so.8()(64bit) libX11.so.6()(64bit) libXext.so.6()(64bit) libalglib.so.3()(64bit) libblas.so.3()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libfltk.so.1.3()(64bit) libfltk_gl.so.1.3()(64bit) libfltk_images.so.1.3()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgmp.so.10()(64bit) libjpeg.so.62()(64bit) liblapack.so.3()(64bit) liblbfgs.so.1()(64bit) libm.so.6()(64bit) libmathex.so.0()(64bit) libmmg3d4.so.4()(64bit) libmpich.so.12()(64bit) libmpichcxx.so.12()(64bit) libmpl.so.1()(64bit) libnglib.so.5()(64bit) libngmesh.so.0()(64bit) libngocc.so.0()(64bit) libopa.so.1()(64bit) libpng16.so.16()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libvoro++.so.0()(64bit) libz.so.1()(64bit) mpich rtld(GNU_HASH) gmsh-openmpi (rpmlib, GLIBC filtered): gmsh-common gmsh-openmpi-libs(x86-64) libANN.so.1()(64bit) libGL.so.1()(64bit) libGLU.so.1()(64bit) libGmsh.so.2.8()(64bit) libICE.so.6()(64bit) libSM.so.6()(64bit) libTKAdvTools.so.8()(64bit) libTKBO.so.8()(64bit) libTKBRep.so.8()(64bit) libTKBool.so.8()(64bit) libTKFeat.so.8()(64bit) libTKFillet.so.8()(64bit) libTKG2d.so.8()(64bit) libTKG3d.so.8()(64bit) libTKGeomAlgo.so.8()(64bit) libTKGeomBase.so.8()(64bit) libTKHLR.so.8()(64bit) libTKIGES.so.8()(64bit) libTKMath.so.8()(64bit) libTKMesh.so.8()(64bit) libTKOffset.so.8()(64bit) libTKPrim.so.8()(64bit) libTKSTEP.so.8()(64bit) libTKSTEP209.so.8()(64bit) libTKSTEPAttr.so.8()(64bit) libTKSTEPBase.so.8()(64bit) libTKShHealing.so.8()(64bit) libTKTopAlgo.so.8()(64bit) libTKXSBase.so.8()(64bit) libTKernel.so.8()(64bit) libX11.so.6()(64bit) libXext.so.6()(64bit) libalglib.so.3()(64bit) libblas.so.3()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libfltk.so.1.3()(64bit) libfltk_gl.so.1.3()(64bit) libfltk_images.so.1.3()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgmp.so.10()(64bit) libjpeg.so.62()(64bit) liblapack.so.3()(64bit) liblbfgs.so.1()(64bit) libm.so.6()(64bit) libmathex.so.0()(64bit) libmmg3d4.so.4()(64bit) libmpi.so.1()(64bit) libmpi_cxx.so.1()(64bit) libnglib.so.5()(64bit) libngmesh.so.0()(64bit) libngocc.so.0()(64bit) libpng16.so.16()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libvoro++.so.0()(64bit) libz.so.1()(64bit) openmpi rtld(GNU_HASH) gmsh (rpmlib, GLIBC filtered): /bin/sh libANN.so.1()(64bit) libGL.so.1()(64bit) libGLU.so.1()(64bit) libGmsh.so.2.8()(64bit) libICE.so.6()(64bit) libSM.so.6()(64bit) libTKAdvTools.so.8()(64bit) libTKBO.so.8()(64bit) libTKBRep.so.8()(64bit) libTKBool.so.8()(64bit) libTKFeat.so.8()(64bit) libTKFillet.so.8()(64bit) libTKG2d.so.8()(64bit) libTKG3d.so.8()(64bit) libTKGeomAlgo.so.8()(64bit) libTKGeomBase.so.8()(64bit) libTKHLR.so.8()(64bit) libTKIGES.so.8()(64bit) libTKMath.so.8()(64bit) libTKMesh.so.8()(64bit) libTKOffset.so.8()(64bit) libTKPrim.so.8()(64bit) libTKSTEP.so.8()(64bit) libTKSTEP209.so.8()(64bit) libTKSTEPAttr.so.8()(64bit) libTKSTEPBase.so.8()(64bit) libTKShHealing.so.8()(64bit) libTKTopAlgo.so.8()(64bit) libTKXSBase.so.8()(64bit) libTKernel.so.8()(64bit) libX11.so.6()(64bit) libXext.so.6()(64bit) libalglib.so.3()(64bit) libblas.so.3()(64bit) libc.so.6()(64bit) libdl.so.2()(64bit) libfltk.so.1.3()(64bit) libfltk_gl.so.1.3()(64bit) libfltk_images.so.1.3()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgmp.so.10()(64bit) libjpeg.so.62()(64bit) liblapack.so.3()(64bit) liblbfgs.so.1()(64bit) libm.so.6()(64bit) libmathex.so.0()(64bit) libmmg3d4.so.4()(64bit) libnglib.so.5()(64bit) libngmesh.so.0()(64bit) libngocc.so.0()(64bit) libpng16.so.16()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libvoro++.so.0()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) gmsh-mpich-devel (rpmlib, GLIBC filtered): gmsh-mpich(x86-64) libGmsh.so.2.8()(64bit) mpich-devel Provides -------- gmsh-devel: gmsh-devel gmsh-devel(x86-64) gmsh-mpich-libs: gmsh-mpich-libs gmsh-mpich-libs(x86-64) libGmsh.so.2.8()(64bit) gmsh-libs: gmsh-libs gmsh-libs(x86-64) libGmsh.so.2.8()(64bit) gmsh-demos: gmsh-demos gmsh-openmpi-devel: gmsh-openmpi-devel gmsh-openmpi-devel(x86-64) gmsh-common: application() application(gmsh.desktop) gmsh-common gmsh-openmpi-libs: gmsh-openmpi-libs gmsh-openmpi-libs(x86-64) libGmsh.so.2.8()(64bit) gmsh-mpich: gmsh-mpich gmsh-mpich(x86-64) gmsh-openmpi: gmsh-openmpi gmsh-openmpi(x86-64) gmsh: gmsh gmsh(x86-64) gmsh-mpich-devel: gmsh-mpich-devel gmsh-mpich-devel(x86-64) Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1111388 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
This is pending completion of the koji scratch build. [ ]: Package should compile and build into binary rpms on all supported architectures. ---> http://koji.fedoraproject.org/koji/taskinfo?taskID=7154865
Well, if so many rpmlints are considered as good, I have no idea...
(In reply to Christopher Meng from comment #7) > Well, if so many rpmlints are considered as good, I have no idea... Well, saying "good" is not a certification in any sense. As far as I am concerned, package is good because * it builds succesfully * it does not bundle libraries * spec is easy to follow and so on. Clearly the package is not approved and the packager is certainly going to work towards addressing the issues. I do not understand what your issue is here considering this is an ongoing review process. Perhaps, you have noticed something that I am not at all seeing (which I would not be surprised since this is a learning process for me)? I think it would be very helpful (speaking for myself) if you could clarify what you are trying to convey by your comment.
I haven't seen: fftw cgnslib. Sandro, comment?
@Christopher: cgnslib BR added fftw: see [1] "the FourierModel library is not publicly available." [1] http://geuz.org/pipermail/gmsh/2009/004007.html @Mukundan: All relevant rpmlint (fixable) rpmlint issues fixed. These gmsh.x86_64: W: no-documentation gmsh.x86_64: W: no-manual-page-for-binary gmsh gmsh-common.noarch: W: desktopfile-without-binary /usr/share/applications/gmsh.desktop gmsh gmsh-devel.x86_64: W: only-non-binary-in-usr-lib gmsh-devel.x86_64: W: no-documentation gmsh-libs.x86_64: W: no-documentation [etc for -openmpi, -mpich] are non-issues (documentation gets pulled in via dependencies, desktop file is common for all binaries, only-non-binary-in-usr-lib is probably because %lib contains only a symlink to the so). gmsh-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libGmsh.so.2.8.4 exit.5 needs to be considered upstream. Some unused-direct-shlib-dependency remain despite -Wl,--as-needed. Spec URL: http://smani.fedorapeople.org/review/gmsh.spec SRPM URL: http://smani.fedorapeople.org/review/gmsh-2.8.4-3.fc21.src.rpm %changelog * Thu Jul 17 2014 Sandro Mani <manisandro> - 2.8.4-3 - Fix encoding of file tutorial/t12.geo - Fix line endings of demos/component8.step - Fix incorrect changelog - Add -Wl,--as-needed - Add BRs: cgnslib-devel med-devel - Pass -DENABLE_CGNS=YES -DENABLE_MED=YES to cmake - Install onelab.py in %%{python2_sitelib} - Add missing Requires: gmsh-common
Sandro, 404 on the source rpm. :( Have you already uploaded the src.rpm? Also, Sorry for the delay - had to take care of something.
Ah, copy paste issue >.< (forgot f21 -> f22), sorry. No worries for the delay. Spec URL: http://smani.fedorapeople.org/review/gmsh.spec SRPM URL: http://smani.fedorapeople.org/review/gmsh-2.8.4-3.fc22.src.rpm
Alright. I have one question - [?]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments ---> Generation of tarball is documented sure. Is it a legal issue to even download the tarball and then get rid of mpeg in %prep instead of manual creation of the tarball? * There are lot of rpmlint errors but I am not sure how many of those can be addressed. Most of the potential "solutions" are already incorporated in the spec file (Would prefer to check again). Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - gtk-update-icon-cache is invoked in %postun and %posttrans if package contains icons. Note: icons in gmsh-common See: http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#Icon_Cache - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1392640 bytes in 64 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Header files in -devel subpackage, if present. [x]: ldconfig called in %post and %postun if required. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "GPL", "LGPL", "GPL (v2 or later)", "GPL (v3 or later)", "Unknown or generated", "MIT/X11 (BSD like)", "LGPL (with incorrect FSF address)", "LGPL (v2.1 or later)", "*No copyright* LGPL (v2.1 or later)", "GPL (v2)", "BSD (3 clause) LGPL (v2.1 or later)". 1480 files have unknown license. Detailed output of licensecheck in /home/mukundan/personal/pkgs/reviews/gmsh/1111388-gmsh/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: Package requires other packages for directories it uses. Note: No known owner of /usr/share/doc/gmsh [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/doc/gmsh [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x]: Package does not own files or directories owned by other packages. [x]: All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package do not use a name that already exist [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in gmsh-common , gmsh-libs , gmsh-devel , gmsh-openmpi , gmsh-openmpi-libs , gmsh- openmpi-devel , gmsh-mpich , gmsh-mpich-libs , gmsh-mpich-devel [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: Scriptlets must be sane, if used. [?]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: Dist tag is present (not strictly required in GL). [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Uses parallel make %{?_smp_mflags} macro. [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: gmsh-2.8.4-3.fc22.x86_64.rpm gmsh-common-2.8.4-3.fc22.noarch.rpm gmsh-libs-2.8.4-3.fc22.x86_64.rpm gmsh-demos-2.8.4-3.fc22.noarch.rpm gmsh-devel-2.8.4-3.fc22.x86_64.rpm gmsh-openmpi-2.8.4-3.fc22.x86_64.rpm gmsh-openmpi-libs-2.8.4-3.fc22.x86_64.rpm gmsh-openmpi-devel-2.8.4-3.fc22.x86_64.rpm gmsh-mpich-2.8.4-3.fc22.x86_64.rpm gmsh-mpich-libs-2.8.4-3.fc22.x86_64.rpm gmsh-mpich-devel-2.8.4-3.fc22.x86_64.rpm gmsh-2.8.4-3.fc22.src.rpm gmsh.x86_64: W: no-documentation gmsh.x86_64: W: no-manual-page-for-binary gmsh gmsh-common.noarch: W: desktopfile-without-binary /usr/share/applications/gmsh.desktop gmsh gmsh-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libGmsh.so.2.8.4 exit.5 gmsh-libs.x86_64: W: no-documentation gmsh-devel.x86_64: W: only-non-binary-in-usr-lib gmsh-devel.x86_64: W: no-documentation gmsh-openmpi.x86_64: W: summary-not-capitalized C gmsh compiled against openmpi gmsh-openmpi.x86_64: W: no-documentation gmsh-openmpi-libs.x86_64: W: summary-not-capitalized C gmsh libraries compiled against openmpi gmsh-openmpi-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/openmpi/lib/libGmsh.so.2.8.4 exit.5 gmsh-openmpi-libs.x86_64: W: no-documentation gmsh-openmpi-devel.x86_64: W: only-non-binary-in-usr-lib gmsh-openmpi-devel.x86_64: W: no-documentation gmsh-mpich.x86_64: W: summary-not-capitalized C gmsh compiled against mpich gmsh-mpich.x86_64: W: no-documentation gmsh-mpich-libs.x86_64: W: summary-not-capitalized C gmsh libraries compiled against mpich gmsh-mpich-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/mpich/lib/libGmsh.so.2.8.4 exit.5 gmsh-mpich-libs.x86_64: W: no-documentation gmsh-mpich-devel.x86_64: W: only-non-binary-in-usr-lib gmsh-mpich-devel.x86_64: W: no-documentation gmsh.src: W: patch-not-applied Patch0: gmsh_unbundle.patch gmsh.src: W: patch-not-applied Patch1: gmsh_alglib.patch gmsh.src: W: patch-not-applied Patch2: gmsh_sign.patch gmsh.src: W: patch-not-applied Patch3: gmsh_tetgen.patch gmsh.src: W: patch-not-applied Patch4: gmsh_install-dirs.patch gmsh.src: W: patch-not-applied Patch5: gmsh_onelab-install-dir.patch gmsh.src: W: invalid-url Source0: gmsh-2.8.4-source-fedora.tar.gz 12 packages and 0 specfiles checked; 0 errors, 28 warnings. Rpmlint (installed packages) ---------------------------- # rpmlint gmsh-devel gmsh-mpich-libs gmsh-libs gmsh-demos gmsh-openmpi-devel gmsh-common gmsh-openmpi-libs gmsh-mpich gmsh-openmpi gmsh gmsh-mpich-devel gmsh-devel.x86_64: W: only-non-binary-in-usr-lib gmsh-devel.x86_64: W: no-documentation gmsh-mpich-libs.x86_64: W: summary-not-capitalized C gmsh libraries compiled against mpich gmsh-mpich-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libGmsh.so.2.8.4 /lib64/liblbfgs.so.1 gmsh-mpich-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libGmsh.so.2.8.4 /usr/lib64/mpich/lib/libmpichcxx.so.12 gmsh-mpich-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libGmsh.so.2.8.4 /usr/lib64/mpich/lib/libopa.so.1 gmsh-mpich-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libGmsh.so.2.8.4 /usr/lib64/mpich/lib/libmpl.so.1 gmsh-mpich-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libGmsh.so.2.8.4 /lib64/librt.so.1 gmsh-mpich-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libGmsh.so.2.8.4 /lib64/libnglib.so.5 gmsh-mpich-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libGmsh.so.2.8.4 /lib64/libhdf5.so.8 gmsh-mpich-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libGmsh.so.2.8.4 /lib64/libTKSTEP209.so.8 gmsh-mpich-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libGmsh.so.2.8.4 /lib64/libTKSTEPAttr.so.8 gmsh-mpich-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libGmsh.so.2.8.4 /lib64/libTKSTEPBase.so.8 gmsh-mpich-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libGmsh.so.2.8.4 /lib64/libTKHLR.so.8 gmsh-mpich-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libGmsh.so.2.8.4 /lib64/libTKAdvTools.so.8 gmsh-mpich-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libGmsh.so.2.8.4 /lib64/libdl.so.2 gmsh-mpich-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libGmsh.so.2.8.4 /lib64/libSM.so.6 gmsh-mpich-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libGmsh.so.2.8.4 /lib64/libICE.so.6 gmsh-mpich-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/mpich/lib/libGmsh.so.2.8.4 /lib64/libXext.so.6 gmsh-mpich-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/mpich/lib/libGmsh.so.2.8.4 exit.5 gmsh-mpich-libs.x86_64: W: no-documentation gmsh-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libGmsh.so.2.8.4 /lib64/liblbfgs.so.1 gmsh-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libGmsh.so.2.8.4 /lib64/libnglib.so.5 gmsh-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libGmsh.so.2.8.4 /lib64/libhdf5.so.8 gmsh-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libGmsh.so.2.8.4 /lib64/libTKSTEP209.so.8 gmsh-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libGmsh.so.2.8.4 /lib64/libTKSTEPAttr.so.8 gmsh-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libGmsh.so.2.8.4 /lib64/libTKSTEPBase.so.8 gmsh-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libGmsh.so.2.8.4 /lib64/libTKHLR.so.8 gmsh-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libGmsh.so.2.8.4 /lib64/libTKAdvTools.so.8 gmsh-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libGmsh.so.2.8.4 /lib64/libdl.so.2 gmsh-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libGmsh.so.2.8.4 /lib64/libSM.so.6 gmsh-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libGmsh.so.2.8.4 /lib64/libICE.so.6 gmsh-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libGmsh.so.2.8.4 /lib64/libXext.so.6 gmsh-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libGmsh.so.2.8.4 exit.5 gmsh-libs.x86_64: W: no-documentation gmsh-openmpi-devel.x86_64: W: only-non-binary-in-usr-lib gmsh-openmpi-devel.x86_64: W: no-documentation gmsh-openmpi-libs.x86_64: W: summary-not-capitalized C gmsh libraries compiled against openmpi gmsh-openmpi-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/openmpi/lib/libGmsh.so.2.8.4 /lib64/liblbfgs.so.1 gmsh-openmpi-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/openmpi/lib/libGmsh.so.2.8.4 /lib64/libnglib.so.5 gmsh-openmpi-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/openmpi/lib/libGmsh.so.2.8.4 /lib64/libhdf5.so.8 gmsh-openmpi-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/openmpi/lib/libGmsh.so.2.8.4 /lib64/libTKSTEP209.so.8 gmsh-openmpi-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/openmpi/lib/libGmsh.so.2.8.4 /lib64/libTKSTEPAttr.so.8 gmsh-openmpi-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/openmpi/lib/libGmsh.so.2.8.4 /lib64/libTKSTEPBase.so.8 gmsh-openmpi-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/openmpi/lib/libGmsh.so.2.8.4 /lib64/libTKHLR.so.8 gmsh-openmpi-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/openmpi/lib/libGmsh.so.2.8.4 /lib64/libTKAdvTools.so.8 gmsh-openmpi-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/openmpi/lib/libGmsh.so.2.8.4 /lib64/libdl.so.2 gmsh-openmpi-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/openmpi/lib/libGmsh.so.2.8.4 /lib64/libSM.so.6 gmsh-openmpi-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/openmpi/lib/libGmsh.so.2.8.4 /lib64/libICE.so.6 gmsh-openmpi-libs.x86_64: W: unused-direct-shlib-dependency /usr/lib64/openmpi/lib/libGmsh.so.2.8.4 /lib64/libXext.so.6 gmsh-openmpi-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/openmpi/lib/libGmsh.so.2.8.4 exit.5 gmsh-openmpi-libs.x86_64: W: no-documentation gmsh-mpich.x86_64: W: summary-not-capitalized C gmsh compiled against mpich gmsh-mpich.x86_64: W: no-documentation gmsh-openmpi.x86_64: W: summary-not-capitalized C gmsh compiled against openmpi gmsh-openmpi.x86_64: W: no-documentation gmsh.x86_64: W: no-documentation gmsh.x86_64: W: no-manual-page-for-binary gmsh gmsh-mpich-devel.x86_64: W: only-non-binary-in-usr-lib gmsh-mpich-devel.x86_64: W: no-documentation 11 packages and 0 specfiles checked; 0 errors, 60 warnings. # echo 'rpmlint-done:' Requires -------- gmsh-devel (rpmlib, GLIBC filtered): gmsh-libs(x86-64) libGmsh.so.2.8()(64bit) gmsh-mpich-libs (rpmlib, GLIBC filtered): /sbin/ldconfig libANN.so.1()(64bit) libGL.so.1()(64bit) libGLU.so.1()(64bit) libICE.so.6()(64bit) libSM.so.6()(64bit) libTKAdvTools.so.8()(64bit) libTKBO.so.8()(64bit) libTKBRep.so.8()(64bit) libTKBool.so.8()(64bit) libTKFeat.so.8()(64bit) libTKFillet.so.8()(64bit) libTKG2d.so.8()(64bit) libTKG3d.so.8()(64bit) libTKGeomAlgo.so.8()(64bit) libTKGeomBase.so.8()(64bit) libTKHLR.so.8()(64bit) libTKIGES.so.8()(64bit) libTKMath.so.8()(64bit) libTKMesh.so.8()(64bit) libTKOffset.so.8()(64bit) libTKPrim.so.8()(64bit) libTKSTEP.so.8()(64bit) libTKSTEP209.so.8()(64bit) libTKSTEPAttr.so.8()(64bit) libTKSTEPBase.so.8()(64bit) libTKShHealing.so.8()(64bit) libTKTopAlgo.so.8()(64bit) libTKXSBase.so.8()(64bit) libTKernel.so.8()(64bit) libX11.so.6()(64bit) libXext.so.6()(64bit) libalglib.so.3()(64bit) libblas.so.3()(64bit) libc.so.6()(64bit) libcgns.so.3.2()(64bit) libdl.so.2()(64bit) libfltk.so.1.3()(64bit) libfltk_gl.so.1.3()(64bit) libfltk_images.so.1.3()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libgmp.so.10()(64bit) libhdf5.so.8()(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) liblapack.so.3()(64bit) liblbfgs.so.1()(64bit) libm.so.6()(64bit) libmathex.so.0()(64bit) libmed.so.1()(64bit) libmmg3d4.so.4()(64bit) libmpich.so.12()(64bit) libmpichcxx.so.12()(64bit) libmpl.so.1()(64bit) libnglib.so.5()(64bit) libngmesh.so.0()(64bit) libngocc.so.0()(64bit) libopa.so.1()(64bit) libpng16.so.16()(64bit) libpng16.so.16(PNG16_0)(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libvoro++.so.0()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) gmsh-libs (rpmlib, GLIBC filtered): /sbin/ldconfig libANN.so.1()(64bit) libGL.so.1()(64bit) libGLU.so.1()(64bit) libICE.so.6()(64bit) libSM.so.6()(64bit) libTKAdvTools.so.8()(64bit) libTKBO.so.8()(64bit) libTKBRep.so.8()(64bit) libTKBool.so.8()(64bit) libTKFeat.so.8()(64bit) libTKFillet.so.8()(64bit) libTKG2d.so.8()(64bit) libTKG3d.so.8()(64bit) libTKGeomAlgo.so.8()(64bit) libTKGeomBase.so.8()(64bit) libTKHLR.so.8()(64bit) libTKIGES.so.8()(64bit) libTKMath.so.8()(64bit) libTKMesh.so.8()(64bit) libTKOffset.so.8()(64bit) libTKPrim.so.8()(64bit) libTKSTEP.so.8()(64bit) libTKSTEP209.so.8()(64bit) libTKSTEPAttr.so.8()(64bit) libTKSTEPBase.so.8()(64bit) libTKShHealing.so.8()(64bit) libTKTopAlgo.so.8()(64bit) libTKXSBase.so.8()(64bit) libTKernel.so.8()(64bit) libX11.so.6()(64bit) libXext.so.6()(64bit) libalglib.so.3()(64bit) libblas.so.3()(64bit) libc.so.6()(64bit) libcgns.so.3.2()(64bit) libdl.so.2()(64bit) libfltk.so.1.3()(64bit) libfltk_gl.so.1.3()(64bit) libfltk_images.so.1.3()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libgmp.so.10()(64bit) libhdf5.so.8()(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) liblapack.so.3()(64bit) liblbfgs.so.1()(64bit) libm.so.6()(64bit) libmathex.so.0()(64bit) libmed.so.1()(64bit) libmmg3d4.so.4()(64bit) libnglib.so.5()(64bit) libngmesh.so.0()(64bit) libngocc.so.0()(64bit) libpng16.so.16()(64bit) libpng16.so.16(PNG16_0)(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libvoro++.so.0()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) gmsh-demos (rpmlib, GLIBC filtered): gmsh(x86-64) gmsh-devel(x86-64) gmsh-openmpi-devel (rpmlib, GLIBC filtered): gmsh-openmpi(x86-64) libGmsh.so.2.8()(64bit) openmpi-devel gmsh-common (rpmlib, GLIBC filtered): hicolor-icon-theme python(abi) gmsh-openmpi-libs (rpmlib, GLIBC filtered): /sbin/ldconfig libANN.so.1()(64bit) libGL.so.1()(64bit) libGLU.so.1()(64bit) libICE.so.6()(64bit) libSM.so.6()(64bit) libTKAdvTools.so.8()(64bit) libTKBO.so.8()(64bit) libTKBRep.so.8()(64bit) libTKBool.so.8()(64bit) libTKFeat.so.8()(64bit) libTKFillet.so.8()(64bit) libTKG2d.so.8()(64bit) libTKG3d.so.8()(64bit) libTKGeomAlgo.so.8()(64bit) libTKGeomBase.so.8()(64bit) libTKHLR.so.8()(64bit) libTKIGES.so.8()(64bit) libTKMath.so.8()(64bit) libTKMesh.so.8()(64bit) libTKOffset.so.8()(64bit) libTKPrim.so.8()(64bit) libTKSTEP.so.8()(64bit) libTKSTEP209.so.8()(64bit) libTKSTEPAttr.so.8()(64bit) libTKSTEPBase.so.8()(64bit) libTKShHealing.so.8()(64bit) libTKTopAlgo.so.8()(64bit) libTKXSBase.so.8()(64bit) libTKernel.so.8()(64bit) libX11.so.6()(64bit) libXext.so.6()(64bit) libalglib.so.3()(64bit) libblas.so.3()(64bit) libc.so.6()(64bit) libcgns.so.3.2()(64bit) libdl.so.2()(64bit) libfltk.so.1.3()(64bit) libfltk_gl.so.1.3()(64bit) libfltk_images.so.1.3()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_4.0.0)(64bit) libgmp.so.10()(64bit) libhdf5.so.8()(64bit) libjpeg.so.62()(64bit) libjpeg.so.62(LIBJPEG_6.2)(64bit) liblapack.so.3()(64bit) liblbfgs.so.1()(64bit) libm.so.6()(64bit) libmathex.so.0()(64bit) libmed.so.1()(64bit) libmmg3d4.so.4()(64bit) libmpi.so.1()(64bit) libmpi_cxx.so.1()(64bit) libnglib.so.5()(64bit) libngmesh.so.0()(64bit) libngocc.so.0()(64bit) libpng16.so.16()(64bit) libpng16.so.16(PNG16_0)(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.1)(64bit) libvoro++.so.0()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) gmsh-mpich (rpmlib, GLIBC filtered): gmsh-common gmsh-mpich-libs(x86-64) libANN.so.1()(64bit) libGL.so.1()(64bit) libGLU.so.1()(64bit) libGmsh.so.2.8()(64bit) libICE.so.6()(64bit) libSM.so.6()(64bit) libTKAdvTools.so.8()(64bit) libTKBO.so.8()(64bit) libTKBRep.so.8()(64bit) libTKBool.so.8()(64bit) libTKFeat.so.8()(64bit) libTKFillet.so.8()(64bit) libTKG2d.so.8()(64bit) libTKG3d.so.8()(64bit) libTKGeomAlgo.so.8()(64bit) libTKGeomBase.so.8()(64bit) libTKHLR.so.8()(64bit) libTKIGES.so.8()(64bit) libTKMath.so.8()(64bit) libTKMesh.so.8()(64bit) libTKOffset.so.8()(64bit) libTKPrim.so.8()(64bit) libTKSTEP.so.8()(64bit) libTKSTEP209.so.8()(64bit) libTKSTEPAttr.so.8()(64bit) libTKSTEPBase.so.8()(64bit) libTKShHealing.so.8()(64bit) libTKTopAlgo.so.8()(64bit) libTKXSBase.so.8()(64bit) libTKernel.so.8()(64bit) libX11.so.6()(64bit) libXext.so.6()(64bit) libalglib.so.3()(64bit) libblas.so.3()(64bit) libc.so.6()(64bit) libcgns.so.3.2()(64bit) libdl.so.2()(64bit) libfltk.so.1.3()(64bit) libfltk_gl.so.1.3()(64bit) libfltk_images.so.1.3()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgmp.so.10()(64bit) libhdf5.so.8()(64bit) libjpeg.so.62()(64bit) liblapack.so.3()(64bit) liblbfgs.so.1()(64bit) libm.so.6()(64bit) libmathex.so.0()(64bit) libmed.so.1()(64bit) libmmg3d4.so.4()(64bit) libmpich.so.12()(64bit) libmpichcxx.so.12()(64bit) libmpl.so.1()(64bit) libnglib.so.5()(64bit) libngmesh.so.0()(64bit) libngocc.so.0()(64bit) libopa.so.1()(64bit) libpng16.so.16()(64bit) libpthread.so.0()(64bit) librt.so.1()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libvoro++.so.0()(64bit) libz.so.1()(64bit) mpich rtld(GNU_HASH) gmsh-openmpi (rpmlib, GLIBC filtered): gmsh-common gmsh-openmpi-libs(x86-64) libANN.so.1()(64bit) libGL.so.1()(64bit) libGLU.so.1()(64bit) libGmsh.so.2.8()(64bit) libICE.so.6()(64bit) libSM.so.6()(64bit) libTKAdvTools.so.8()(64bit) libTKBO.so.8()(64bit) libTKBRep.so.8()(64bit) libTKBool.so.8()(64bit) libTKFeat.so.8()(64bit) libTKFillet.so.8()(64bit) libTKG2d.so.8()(64bit) libTKG3d.so.8()(64bit) libTKGeomAlgo.so.8()(64bit) libTKGeomBase.so.8()(64bit) libTKHLR.so.8()(64bit) libTKIGES.so.8()(64bit) libTKMath.so.8()(64bit) libTKMesh.so.8()(64bit) libTKOffset.so.8()(64bit) libTKPrim.so.8()(64bit) libTKSTEP.so.8()(64bit) libTKSTEP209.so.8()(64bit) libTKSTEPAttr.so.8()(64bit) libTKSTEPBase.so.8()(64bit) libTKShHealing.so.8()(64bit) libTKTopAlgo.so.8()(64bit) libTKXSBase.so.8()(64bit) libTKernel.so.8()(64bit) libX11.so.6()(64bit) libXext.so.6()(64bit) libalglib.so.3()(64bit) libblas.so.3()(64bit) libc.so.6()(64bit) libcgns.so.3.2()(64bit) libdl.so.2()(64bit) libfltk.so.1.3()(64bit) libfltk_gl.so.1.3()(64bit) libfltk_images.so.1.3()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgmp.so.10()(64bit) libhdf5.so.8()(64bit) libjpeg.so.62()(64bit) liblapack.so.3()(64bit) liblbfgs.so.1()(64bit) libm.so.6()(64bit) libmathex.so.0()(64bit) libmed.so.1()(64bit) libmmg3d4.so.4()(64bit) libmpi.so.1()(64bit) libmpi_cxx.so.1()(64bit) libnglib.so.5()(64bit) libngmesh.so.0()(64bit) libngocc.so.0()(64bit) libpng16.so.16()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libvoro++.so.0()(64bit) libz.so.1()(64bit) openmpi rtld(GNU_HASH) gmsh (rpmlib, GLIBC filtered): /bin/sh gmsh-common libANN.so.1()(64bit) libGL.so.1()(64bit) libGLU.so.1()(64bit) libGmsh.so.2.8()(64bit) libICE.so.6()(64bit) libSM.so.6()(64bit) libTKAdvTools.so.8()(64bit) libTKBO.so.8()(64bit) libTKBRep.so.8()(64bit) libTKBool.so.8()(64bit) libTKFeat.so.8()(64bit) libTKFillet.so.8()(64bit) libTKG2d.so.8()(64bit) libTKG3d.so.8()(64bit) libTKGeomAlgo.so.8()(64bit) libTKGeomBase.so.8()(64bit) libTKHLR.so.8()(64bit) libTKIGES.so.8()(64bit) libTKMath.so.8()(64bit) libTKMesh.so.8()(64bit) libTKOffset.so.8()(64bit) libTKPrim.so.8()(64bit) libTKSTEP.so.8()(64bit) libTKSTEP209.so.8()(64bit) libTKSTEPAttr.so.8()(64bit) libTKSTEPBase.so.8()(64bit) libTKShHealing.so.8()(64bit) libTKTopAlgo.so.8()(64bit) libTKXSBase.so.8()(64bit) libTKernel.so.8()(64bit) libX11.so.6()(64bit) libXext.so.6()(64bit) libalglib.so.3()(64bit) libblas.so.3()(64bit) libc.so.6()(64bit) libcgns.so.3.2()(64bit) libdl.so.2()(64bit) libfltk.so.1.3()(64bit) libfltk_gl.so.1.3()(64bit) libfltk_images.so.1.3()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgmp.so.10()(64bit) libhdf5.so.8()(64bit) libjpeg.so.62()(64bit) liblapack.so.3()(64bit) liblbfgs.so.1()(64bit) libm.so.6()(64bit) libmathex.so.0()(64bit) libmed.so.1()(64bit) libmmg3d4.so.4()(64bit) libnglib.so.5()(64bit) libngmesh.so.0()(64bit) libngocc.so.0()(64bit) libpng16.so.16()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libvoro++.so.0()(64bit) libz.so.1()(64bit) rtld(GNU_HASH) gmsh-mpich-devel (rpmlib, GLIBC filtered): gmsh-mpich(x86-64) libGmsh.so.2.8()(64bit) mpich-devel Provides -------- gmsh-devel: gmsh-devel gmsh-devel(x86-64) gmsh-mpich-libs: gmsh-mpich-libs gmsh-mpich-libs(x86-64) libGmsh.so.2.8()(64bit) gmsh-libs: gmsh-libs gmsh-libs(x86-64) libGmsh.so.2.8()(64bit) gmsh-demos: gmsh-demos gmsh-openmpi-devel: gmsh-openmpi-devel gmsh-openmpi-devel(x86-64) gmsh-common: application() application(gmsh.desktop) gmsh-common gmsh-openmpi-libs: gmsh-openmpi-libs gmsh-openmpi-libs(x86-64) libGmsh.so.2.8()(64bit) gmsh-mpich: gmsh-mpich gmsh-mpich(x86-64) gmsh-openmpi: gmsh-openmpi gmsh-openmpi(x86-64) gmsh: gmsh gmsh(x86-64) gmsh-mpich-devel: gmsh-mpich-devel gmsh-mpich-devel(x86-64) Generated by fedora-review 0.5.1 (bb9bf27) last change: 2013-12-13 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1111388 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api, C/C++ Disabled plugins: Java, SugarActivity, fonts, Haskell, Ocaml, Perl, R, PHP, Ruby Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG
> Is it a legal issue to even download the tarball and then get rid of mpeg in %prep instead of manual creation of the tarball? See http://fedoraproject.org/wiki/Packaging:SourceURL#When_Upstream_uses_Prohibited_Code Rpmlint: The output of the build below should be as follows: > gmsh.src: W: patch-not-applied PatchX: [...] False positive (autosetup) > gmsh.src: W: invalid-url Source0: gmsh-2.8.4-source-fedora.tar.gz As documented > gmsh.x86_64: W: no-documentation non-issue, docs are in -common which gets pulled in > gmsh.x86_64: W: no-manual-page-for-binary gmsh non-issue, manpage is in -common which gets pulled in > gmsh-common.noarch: W: desktopfile-without-binary /usr/share/applications/gmsh.desktop gmsh The desktop file is common to all gmsh executables, to which gmsh executable it points to depends on the environment (i.e. if an mpi env is loaded) > gmsh-libs.x86_64: W: unused-direct-shlib-dependency [...] Adding -Wl,--as-needed removed one of these, but not the others. Should not be a blocker though. > gmsh-libs.x86_64: W: shared-lib-calls-exit /usr/lib64/libGmsh.so.2.8.4 exit.5 Needs to be considered upstream > gmsh-devel.x86_64: W: only-non-binary-in-usr-lib False positive (lib is a symlink) > gmsh-devel.x86_64: W: no-documentation License is in -libs, which is a dependency > gmsh-openmpi.x86_64: W: summary-not-capitalized C gmsh compiled against openmpi Non-issue -> Same for gmsh-openmpi* and gmsh-mpich* Spec URL: http://smani.fedorapeople.org/review/gmsh.spec SRPM URL: http://smani.fedorapeople.org/review/gmsh-2.8.4-4.fc22.src.rpm %changelog * Tue Jul 22 2014 Sandro Mani <manisandro> - 2.8.4-4 - Rename gmsh-demos to gmsh-doc - Fix scriptlets for gmsh-common - Install license file with *-libs subpackages
(In reply to Sandro Mani from comment #14) > > Is it a legal issue to even download the tarball and then get rid of mpeg in %prep instead of manual creation of the tarball? > > See > http://fedoraproject.org/wiki/Packaging: > SourceURL#When_Upstream_uses_Prohibited_Code > I should not have asked this question based on my memory! :( > > Spec URL: http://smani.fedorapeople.org/review/gmsh.spec > SRPM URL: http://smani.fedorapeople.org/review/gmsh-2.8.4-4.fc22.src.rpm > > %changelog > * Tue Jul 22 2014 Sandro Mani <manisandro> - 2.8.4-4 > - Rename gmsh-demos to gmsh-doc > - Fix scriptlets for gmsh-common > - Install license file with *-libs subpackages Others are fine. I have no further issues. Package APPROVED.
Many thanks for the review! New Package SCM Request ======================= Package Name: gmsh Short Description: A three-dimensional finite element mesh generator Owners: smani Branches: f20 el6 epel7 InitialCC:
Git done (by process-git-requests).
Oh, forgot that there is now f21... Package Change Request ====================== Package Name: gmsh New Branches: f21 Owners: smani InitialCC:
Built for rawhide and F21, rest pending due to scotch issues.
gmsh-2.8.5-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/gmsh-2.8.5-2.fc20
gmsh-2.8.5-2.fc20 has been pushed to the Fedora 20 stable repository.