1111501 – REPORT_BUILD_ANALYTICS should be set to false by default

Bug 1111501 - REPORT_BUILD_ANALYTICS should be set to false by default

Summary: REPORT_BUILD_ANALYTICS should be set to false by default

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	OpenShift Container Platform
Classification:	Red Hat
Component:	Containers
Sub Component:
Version:	2.1.0
Hardware:	Unspecified
OS:	Unspecified
Priority:	low
Severity:	low
Target Milestone:	---
Target Release:	---
Assignee:	Miciah Dashiel Butler Masters
QA Contact:	libra bugs
Docs Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+	depends on / blocked

Reported:	2014-06-20 07:54 UTC by Gaoyun Pei
Modified:	2015-12-17 17:09 UTC (History)
CC List:	6 users (show)
Fixed In Version:	rubygem-openshift-origin-node-1.38.4.1-1.el6op
Doc Type:	Bug Fix
Doc Text:	By default, the REPORT_BUILD_ANALYTICS parameter in the /etc/openshift/node.conf file was set to `true`. With this default configuration, the OpenShift node attempted to notify the broker about application builds via a special REST API on the broker. However, the broker did not have this REST API in its default configuration which caused the node's attempt to result in the following spurious log message and a backtrace in the /var/log/openshift/broker/httpd/error_log file every time a user performed a `git push` to an application: 'Exception ActionController::RoutingError in Rack application object (No route matches [POST] "/broker/analytics")'. This bug fix changes the default value of the REPORT_BUILD_ANALYTICS parameter to `false.` As a result, the spurious log messages should no longer appear by default.
Clone Of:
Environment:
Last Closed:	2015-12-17 17:09:20 UTC
Target Upstream Version:
Embargoed:

Attachments	(Terms of Use)

Links
System	ID	Private	Priority	Status	Summary	Last Updated
Red Hat Product Errata	RHSA-2015:2666	0	normal	SHIPPED_LIVE	Important: Red Hat OpenShift Enterprise 2.2.8 security, bug fix, and enhancement update	2015-12-17 22:07:54 UTC

Description Gaoyun Pei 2014-06-20 07:54:37 UTC

Description of problem:
Every time an app deployment via git push finished, broker would send a POST to /broker/analytics, which would generate errors in httpd logs.
According to BZ#1061400, REPORT_BUILD_ANALYTICS parameter was introduced to prevent reporting analytic action on this occasion. But the default value is "true", which means these errors still could be seen with the default configuration of an ose env.
 

Version-Release number of selected component (if applicable):
2.1.z/2014-06-18.2
rubygem-openshift-origin-node-1.23.9.11-1.el6op.noarch

How reproducible:
always

Steps to Reproduce:
1.Setting up an ose-2.1 env, create an app, git push for some changes on the app
2.Monitoring /var/log/openshift/broker/httpd/error_log

Actual results:
Errors in /var/log/openshift/broker/httpd/error_log:
[ pid=16764 thr=12210300 file=utils.rb:176 time=2014-06-19 20:25:26.847 ]: *** Exception ActionController::RoutingError in Rack application object (No route matches [POST] "/broker/analytics") (process 16764, thread #<Thread:0x0000000174a0f8>):
	from /opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.8/lib/action_dispatch/middleware/debug_exceptions.rb:21:in `call'
	from /opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.8/lib/action_dispatch/middleware/show_exceptions.rb:56:in `call'
	from /opt/rh/ruby193/root/usr/share/gems/gems/railties-3.2.8/lib/rails/rack/logger.rb:26:in `call_app'
	from /opt/rh/ruby193/root/usr/share/gems/gems/railties-3.2.8/lib/rails/rack/logger.rb:16:in `call'
	from /opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.8/lib/action_dispatch/middleware/request_id.rb:22:in `call'
	from /opt/rh/ruby193/root/usr/share/gems/gems/rack-1.4.1/lib/rack/methodoverride.rb:21:in `call'
	from /opt/rh/ruby193/root/usr/share/gems/gems/rack-1.4.1/lib/rack/runtime.rb:17:in `call'
	from /opt/rh/ruby193/root/usr/share/gems/gems/activesupport-3.2.8/lib/active_support/cache/strategy/local_cache.rb:72:in `call'
	from /opt/rh/ruby193/root/usr/share/gems/gems/rack-1.4.1/lib/rack/lock.rb:15:in `call'
	from /opt/rh/ruby193/root/usr/share/gems/gems/actionpack-3.2.8/lib/action_dispatch/middleware/static.rb:62:in `call'
	from /opt/rh/ruby193/root/usr/share/gems/gems/rack-cache-1.2/lib/rack/cache/context.rb:136:in `forward'
	from /opt/rh/ruby193/root/usr/share/gems/gems/rack-cache-1.2/lib/rack/cache/context.rb:143:in `pass'
	from /opt/rh/ruby193/root/usr/share/gems/gems/rack-cache-1.2/lib/rack/cache/context.rb:155:in `invalidate'
	from /opt/rh/ruby193/root/usr/share/gems/gems/rack-cache-1.2/lib/rack/cache/context.rb:71:in `call!'
	from /opt/rh/ruby193/root/usr/share/gems/gems/rack-cache-1.2/lib/rack/cache/context.rb:51:in `call'
	from /opt/rh/ruby193/root/usr/share/gems/gems/railties-3.2.8/lib/rails/engine.rb:479:in `call'
	from /opt/rh/ruby193/root/usr/share/gems/gems/railties-3.2.8/lib/rails/application.rb:223:in `call'
	from /opt/rh/ruby193/root/usr/share/gems/gems/railties-3.2.8/lib/rails/railtie/configurable.rb:30:in `method_missing'
	from /opt/rh/ruby193/root/usr/share/gems/gems/passenger-3.0.21/lib/phusion_passenger/rack/request_handler.rb:97:in `process_request'
	from /opt/rh/ruby193/root/usr/share/gems/gems/passenger-3.0.21/lib/phusion_passenger/abstract_request_handler.rb:521:in `accept_and_process_next_request'
	from /opt/rh/ruby193/root/usr/share/gems/gems/passenger-3.0.21/lib/phusion_passenger/abstract_request_handler.rb:274:in `main_loop'
	from /opt/rh/ruby193/root/usr/share/gems/gems/passenger-3.0.21/lib/phusion_passenger/rack/application_spawner.rb:206:in `start_request_handler'
	from /opt/rh/ruby193/root/usr/share/gems/gems/passenger-3.0.21/lib/phusion_passenger/rack/application_spawner.rb:171:in `block in handle_spawn_application'
	from /opt/rh/ruby193/root/usr/share/gems/gems/passenger-3.0.21/lib/phusion_passenger/utils.rb:470:in `safe_fork'
	from /opt/rh/ruby193/root/usr/share/gems/gems/passenger-3.0.21/lib/phusion_passenger/rack/application_spawner.rb:166:in `handle_spawn_application'
	from /opt/rh/ruby193/root/usr/share/gems/gems/passenger-3.0.21/lib/phusion_passenger/abstract_server.rb:357:in `server_main_loop'
	from /opt/rh/ruby193/root/usr/share/gems/gems/passenger-3.0.21/lib/phusion_passenger/abstract_server.rb:206:in `start_synchronously'
	from /opt/rh/ruby193/root/usr/share/gems/gems/passenger-3.0.21/lib/phusion_passenger/abstract_server.rb:180:in `start'
	from /opt/rh/ruby193/root/usr/share/gems/gems/passenger-3.0.21/lib/phusion_passenger/rack/application_spawner.rb:129:in `start'
	from /opt/rh/ruby193/root/usr/share/gems/gems/passenger-3.0.21/lib/phusion_passenger/spawn_manager.rb:253:in `block (2 levels) in spawn_rack_application'
	from /opt/rh/ruby193/root/usr/share/gems/gems/passenger-3.0.21/lib/phusion_passenger/abstract_server_collection.rb:132:in `lookup_or_add'
	from /opt/rh/ruby193/root/usr/share/gems/gems/passenger-3.0.21/lib/phusion_passenger/spawn_manager.rb:246:in `block in spawn_rack_application'
	from /opt/rh/ruby193/root/usr/share/gems/gems/passenger-3.0.21/lib/phusion_passenger/abstract_server_collection.rb:82:in `block in synchronize'
	from <internal:prelude>:10:in `synchronize'
	from /opt/rh/ruby193/root/usr/share/gems/gems/passenger-3.0.21/lib/phusion_passenger/abstract_server_collection.rb:79:in `synchronize'
	from /opt/rh/ruby193/root/usr/share/gems/gems/passenger-3.0.21/lib/phusion_passenger/spawn_manager.rb:244:in `spawn_rack_application'
	from /opt/rh/ruby193/root/usr/share/gems/gems/passenger-3.0.21/lib/phusion_passenger/spawn_manager.rb:137:in `spawn_application'
	from /opt/rh/ruby193/root/usr/share/gems/gems/passenger-3.0.21/lib/phusion_passenger/spawn_manager.rb:275:in `handle_spawn_application'
	from /opt/rh/ruby193/root/usr/share/gems/gems/passenger-3.0.21/lib/phusion_passenger/abstract_server.rb:357:in `server_main_loop'
	from /opt/rh/ruby193/root/usr/share/gems/gems/passenger-3.0.21/lib/phusion_passenger/abstract_server.rb:206:in `start_synchronously'
	from /opt/rh/ruby193/root/usr/share/gems/gems/passenger-3.0.21/helper-scripts/passenger-spawn-server:102:in `<main>'


Expected results:
REPORT_BUILD_ANALYTICS should be set to false by default

Additional info:

Comment 1 openshift-github-bot 2015-10-14 22:15:43 UTC

Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/57e736b6117e7e1c630d67096a4ead26b55d26ec
REPORT_BUILD_ANALYTICS=false by default

Change the default value of REPORT_BUILD_ANALYTICS in node.conf and in
the code that uses this setting from true to false to avoid spurious
requests to /broker/analytics.

This commit fixes bug 1111501.

Comment 4 Gaoyun Pei 2015-11-12 09:32:50 UTC

Verify this bug with rubygem-openshift-origin-node-1.38.4.1-1.el6op.noarch.
After installation, REPORT_BUILD_ANALYTICS is set to false by default.
[root@node1 ~]# grep REPORT_BUILD_ANALYTICS /etc/openshift/node.conf
REPORT_BUILD_ANALYTICS=false

Comment 6 errata-xmlrpc 2015-12-17 17:09:20 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-2666.html

Note You need to log in before you can comment on or make changes to this bug.