Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1111565

Summary:	single_qxl_pci field in webadmin ui always defaults to true even if it is false
Product:	[Retired] oVirt	Reporter:	Kristaps Tigeris <kristapstigeris>
Component:	ovirt-engine-webadmin	Assignee:	Shahar Havivi <shavivi>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Pavel Novotny <pnovotny>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	3.4	CC:	ecohen, iheim, kristapstigeris, mavital, mgoldboi, ofrenkel, rbalakri, shavivi, usurse, yeylon
Target Milestone:	---	Keywords:	Triaged
Target Release:	3.5.0
Hardware:	Unspecified
OS:	Linux
Whiteboard:	virt
Fixed In Version:	ovirt-3.5.0-beta2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-10-17 12:36:28 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Virt	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Kristaps Tigeris 2014-06-20 11:32:42 UTC

Description of problem:
When editing VM in oVirt Webadmin UI, it seems that field single_qxl_pci always defaults to true, even if it is set to false. Since this field can not be edited while VM is running, it causes confusion when someone tries to edit fields like comment or description for some VM's, but gets an error that he has edited some field that can not be edited while VM is running.

When looking in API, I can see that single_qxl_pci is false, but when editing it in UI, it tries to set itself to true.

Version-Release number of selected component (if applicable):
3.4.2

How reproducible:
100%

Steps to Reproduce:
1. Have VM that has single_qxl_pci set to false and running
2. Open Edit window for VM
3. Don't change anything, press OK

Actual results:
This error is shown:
There was an attempt to change VM values while the VM is not down. Please shut down the VM in order to modify these properties.

in engine.log:
2014-06-20 13:29:14,053 ERROR [org.ovirt.engine.core.utils.ObjectIdentityChecker] (ajp--127.0.0.1-8702-8) [3fecc5e3] Field singleQxlPci can not be updated when status is Up
2014-06-20 13:29:14,054 WARN [org.ovirt.engine.core.utils.ObjectIdentityChecker] (ajp--127.0.0.1-8702-8) [3fecc5e3] ObjectIdentityChecker.IsUpdateValid:: Not updatable field 'singleQxlPci' was updated
2014-06-20 13:29:14,055 WARN [org.ovirt.engine.core.bll.UpdateVmCommand] (ajp--127.0.0.1-8702-8) [3fecc5e3] CanDoAction of action UpdateVm failed. Reasons:VAR__ACTION__UPDATE,VAR__TYPE__VM,VM_CANNOT_UPDATE_ILLEGAL_FIELD

Expected results:
Edit window for VM closes without errors.

Comment 1 Shahar Havivi 2014-06-22 10:58:21 UTC

Cannot reproduce on upstream,
In 3.4 you need to have Linux OS with Spice as display protocol to reproduce this scenario in edit VM.

Comment 2 Shahar Havivi 2014-06-26 13:32:05 UTC

Note for QE:
Please check that there is no regression in Template and Pool as well.
Try to change the display type to vnc as well, it should disable the Qxl in the Add/Edit Vm/Template/Pool dialog.

Comment 3 Shahar Havivi 2014-07-01 09:49:50 UTC

*** Bug 1113503 has been marked as a duplicate of this bug. ***

Comment 4 Pavel Novotny 2014-07-29 16:53:33 UTC

Verified in ovirt-engine-3.5.0-0.0.master.20140722232058.git8e1babc.el6.noarch (beta2).

Verified by following the reproducer:
1. Have VM that has single_qxl_pci set to false and running
2. Open Edit window for VM
3. Don't change anything, press OK
-plus-
3b. Update Comment field, press OK

Above steps also verified with VM with single_qxl_pci set to true.

No errors were encountered.

Comment 5 Sandro Bonazzola 2014-10-17 12:36:28 UTC

oVirt 3.5 has been released and should include the fix for this issue.